Re: RFR: JDK-8222406: Multiple arguments for the same option - aggragation broken.

2019-04-12 Thread Alexander Matveev
Hi Andy, Looks good. Thanks, Alexander On 4/12/2019 10:35 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222406 [2] http://c

Re: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

2019-04-12 Thread Jason Mehrens
Hi Goetz, Looking at the test cases I didn't see any tests for the single argument java.util.Objects.requireNonNull. Using this prototype is that method treated like a hidden frame? Cheers, Jason From: core-libs-dev on behalf of Lindenmaier, Goetz S

Re: RFR(trivial): 8222394: HashMap.compute() throws CME on an empty Map if clear() called concurrently

2019-04-12 Thread Stuart Marks
[I'm about to leave for a week's vacation, so I won't be able to respond further until after I return] Hi Patrick, A bit of background about my thinking on this proposal. The Collections Framework has a set of weird edge cases ("tricky", as you say) that I'll describe as "state-dependent" beh

[12u] RFR : 8221530: Caller sensitive methods not handling caller = null when invoked by JNI code with no java frames on stack + JDK-8222078, JDK-8222082, JDK-8222111

2019-04-12 Thread Ivan Gerasimov
Hello! This is request to review the combined backport for the four listed bugs (the later three are the test fixes). The first fix had to be slightly modified: 1) The spec change was removed from AccessibleObject.java, 2) The method jdk.test.lib.Platform.sharedLibraryPathVariableName(), whic

RFR: JDK-8222406: Multiple arguments for the same option - aggragation broken.

2019-04-12 Thread Andy Herrick
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222406 [2] http://cr.openjdk.java.net/~herrick/8222406/ /Andy

RE: ZipFileSystem performance regression

2019-04-12 Thread Langer, Christoph
Hi Lennart, sure, excited to hear it... 😉 Thanks Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Lennart Börjeson > Sent: Freitag, 12. April 2019 14:26 > To: core-libs-dev@openjdk.java.net > Subject: ZipFileSystem performance regression > > I've found what I believe

Re: ZipFileSystem performance regression

2019-04-12 Thread Claes Redestad
On 2019-04-12 14:25, Lennart Börjeson wrote: Is this the right forum to report such issues? I'm sure there are some friendly OpenJDK contributors around these parts who'd be interested in a description and a reproducer. /Claes

ZipFileSystem performance regression

2019-04-12 Thread Lennart Börjeson
I've found what I believe is a rather severe performance regression in ZipFileSystem. 1.8 and 11 runs OK, 12 does not. Is this the right forum to report such issues? Best regards, /Lennart Börjeson

Re: jpackaged .app not compatible with macOS sandboxing?

2019-04-12 Thread Kustaa Nyholm
> On 4 Apr 2019, at 16.13, Andy Herrick wrote: > > We will file a bug for this part, and address it soon. > > /Andy > Thanks. Is there a bug report number and where can I monitor the progress please? wbr Kusti

Re: RFE: JDK-8217895: jpackage --identifier purpose

2019-04-12 Thread Andy Herrick
On 4/11/2019 6:06 PM, semyon.sadet...@oracle.com wrote: On 4/11/19 12:05 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-82178

RFR: 8220715 JEP Draft: Add detailed message to NullPointerException describing what is null

2019-04-12 Thread Lindenmaier, Goetz
Hi, This JEP proposes to enhance the messages of NullPointerExceptions that are thrown if execution of a bytecode fails due to a null reference. https://bugs.openjdk.java.net/browse/JDK-8220715 A corresponding prototype exists and is submitted to the sandbox repo and is available as change 821862

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

2019-04-12 Thread Lindenmaier, Goetz
Hi, while waiting for progress on corresponding the JEP, I improved the implementation of generating the NPE message. It now uses a single outputStream. This removes several allocations of temporary data. I also removed TrackingStackSource. The analysis code originally addressed several use cas

RE: RFR(trivial): 8222394: HashMap.compute() throws CME on an empty Map if clear() called concurrently

2019-04-12 Thread Patrick Zhang OS
Created a ticket to track it, welcome any comments. Thanks. JBS https://bugs.openjdk.java.net/browse/JDK-8222394 Webrev: http://cr.openjdk.java.net/~qpzhang/map.clear/webrev.01 Regards Patrick -Original Message- From: core-libs-dev On Behalf Of Patrick Zhang OS Sent: Saturday, March

Re: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-12 Thread David Holmes
Hi Patrick, First apologies that it took me so long to get my head around this. :) Let me summarise the problem as I see it. The launcher specifies no particular semantics for -Xss0, to it 0 is just a very small size. However the VM maps -Xss to -XX:ThreadStackSize and for it 0 means "use th

RE: RFR: 8222334: java -Xss0 triggers StackOverflowError

2019-04-12 Thread Patrick Zhang OS
Moved this to core-libs-dev for review, thanks. Dropped and bcc'ed jdk-dev and jdk-updates-dev. Regards Patrick -Original Message- From: David Holmes Sent: Friday, April 12, 2019 3:43 PM To: Patrick Zhang OS ; jdk-...@openjdk.java.net Cc: jdk-updates-...@openjdk.java.net Subject: Re: R