Re: Throwable.addSuppressed again

2018-12-15 Thread Bernd Eckenfels
Just an Addition: looks like the OOME uses already enableSuppression=true (in most? Cases) so a change to check enableSuppression before checking self-supression seems like an very effective change (if it is decided to Keep this Assertion at all). Gruss Bernd -- http://bernd.eckenfels.net

Throwable.addSuppressed again

2018-12-15 Thread Bernd Eckenfels
Hello, a while back I reported a Problem with „self Suppression“ in the context of FilterOutputStream where a „cached“ exception thrown by flush() and close() resulted in a IllegalArgumentException: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-May/026743.html This was fixed for th

Re: jpackage EA Build 0

2018-12-15 Thread Sverre Moe
Den lør. 15. des. 2018 kl. 18:44 skrev Andy Herrick : > > > On 12/15/2018 11:26 AM, Sverre Moe wrote: > > Some feedback from using this new JDK12 jpackage. > > I have yet to find out how to specify the bundle resources. It tells to put > them on the class path, but that cannot be right, as jpackag

Re: JDK-8165199: UUID.fromString(str) compliance checking?

2018-12-15 Thread Joe Darcy
Hello, On 12/14/2018 2:00 PM, Andrew Leonard wrote: Yes, this was my concern, source compatibility... With the current implementation it is not too harmful to "sloppy" app code. If it's not causing any other underlying "bug" then I would be tempted to leave this "sleeping dog..." To use lan

Re: jpackage EA Build 0

2018-12-15 Thread Andy Herrick
On 12/15/2018 11:26 AM, Sverre Moe wrote: Some feedback from using this new JDK12 jpackage. The argument --version is no longer used for setting the bundler version. Thus one needs to specify bundle resources (spec for RPM and control for DEB), if the version is anything other than "1.0". Sor

Re: jpackage EA Build 0

2018-12-15 Thread Sverre Moe
Noticed now that there was an --app-version argument as replacement for the previous --version. Though I would like to see any examples during help how to specify the bundle resources to class path. /Sverre Den lør. 15. des. 2018 kl. 17:26 skrev Sverre Moe : > Some feedback from using this new

Re: 8215449: Several tests failing when jtreg run with -vmoption:--illegal-access=deny

2018-12-15 Thread Enrico Olivelli
Il sab 15 dic 2018, 17:12 Alan Bateman ha scritto: > On 15/12/2018 09:53, Enrico Olivelli wrote: > > Hi Alan, > > A little off-topic: Is there any plan to move to 'deny' by default in > > Java 12 ? > > > Not for JDK 12 as that release is in Rampdown Phase One. > Thanks Enrico > > -Alan > --

Re: jpackage EA Build 0

2018-12-15 Thread Sverre Moe
Some feedback from using this new JDK12 jpackage. The argument --version is no longer used for setting the bundler version. Thus one needs to specify bundle resources (spec for RPM and control for DEB), if the version is anything other than "1.0". I have yet to find out how to specify the bundle

Re: 8215449: Several tests failing when jtreg run with -vmoption:--illegal-access=deny

2018-12-15 Thread Alan Bateman
On 15/12/2018 09:53, Enrico Olivelli wrote: Hi Alan, A little off-topic: Is there any plan to move to 'deny' by default in Java 12 ? Not for JDK 12 as that release is in Rampdown Phase One. -Alan

Re: 8215449: Several tests failing when jtreg run with -vmoption:--illegal-access=deny

2018-12-15 Thread Claes Redestad
Hi Alan, On 2018-12-15 10:40, Alan Bateman wrote: This is test only change to fix a few tests that don't have complete @modules or --add-exports options and so fail when running jtreg with vmoption:--illegal-access=deny. The only change that might not be obvious is to langtools/tools/javac/p

Re: 8215449: Several tests failing when jtreg run with -vmoption:--illegal-access=deny

2018-12-15 Thread Enrico Olivelli
Hi Alan, A little off-topic: Is there any plan to move to 'deny' by default in Java 12 ? Enrico Il sab 15 dic 2018, 10:41 Alan Bateman ha scritto: > This is test only change to fix a few tests that don't have complete > @modules or --add-exports options and so fail when running jtreg with > vmo

8215449: Several tests failing when jtreg run with -vmoption:--illegal-access=deny

2018-12-15 Thread Alan Bateman
This is test only change to fix a few tests that don't have complete @modules or --add-exports options and so fail when running jtreg with vmoption:--illegal-access=deny. The only change that might not be obvious is to langtools/tools/javac/platform/CanHandleClassFilesTest.java. That test cre