On 28/08/2018 22:21, Stephen Colebourne wrote:
:
The key point here is that this all worked before Java 9 modules. But
since resources are now encapsulated, adding a new ClassLoader is no
longer sufficient to inject a resource, as it doesn't get the right
module encapsulation that way.
The articl
Anyone willing to help review the patch, please?
-Jaikiran
On 20/08/18 5:56 PM, Jaikiran Pai wrote:
> Hello everyone,
>
> I'm requesting a review of a documentation change which was discussed in
> a recent thread[1][2]. Here's an initial proposed draft, for a better
> documentation of Arrays.asL
Can I ask you guys a quick question. Does the VM development team plan on
implementing any pure pass by reference. Also I think we would like security
and RMI integration going forward with the VM directly. No way to hook memory
allocation seems like a miss.
Let me know with some feedback.
Hi,
Please help review the proposed change for JDK-8197398.
issue: https://bugs.openjdk.java.net/browse/JDK-8197398
webrev: http://cr.openjdk.java.net/~sherman/8197398/webrev
A little background:
The existing zipfs has an assumption that the "normal/healthy/secured"
zip/jar file should not
in
Hi Joe,
This is a typical currency data change, and does not involve any public
interface changes, so I think CSR is not needed. We haven't filed CSRs
for such changes in the past.
Naoto
On 8/28/18 6:33 PM, joe darcy wrote:
Hello,
Should these changes have CSR requests?
Cheers,
-Joe
On
Hello,
Should these changes have CSR requests?
Cheers,
-Joe
On 8/28/2018 10:09 AM, Naoto Sato wrote:
Hi Leo,
Looks good to me. Also, please work with sustaining wrt backports.
Naoto
On 8/28/18 7:56 AM, li.ji...@oracle.com wrote:
Hi,
Please review the changes for ISO 4217 Amendment #168
On Tue, 28 Aug 2018 at 20:43, Peter Levart wrote:
> Do you think this functionality is really needed in programs? It seems useful
> just for testing.
Why do people add classes at runtime? Might they not reasonably want
to also add resources for those classes?
The key point here is that this all
On 08/28/2018 06:38 PM, Stephen Colebourne wrote:
On 28 August 2018 at 08:17, Alan Bateman wrote:
On 28/08/2018 07:55, Peter Levart wrote:
Right, and any class injected with Lookup.defineClass can be located with
methods such as Class.forName or Lookup.findClass. There is no equivalent
for r
Hi Leo,
Looks good to me. Also, please work with sustaining wrt backports.
Naoto
On 8/28/18 7:56 AM, li.ji...@oracle.com wrote:
Hi,
Please review the changes for ISO 4217 Amendment #168 #169.
Bugs:
https://bugs.openjdk.java.net/browse/JDK-8208746 168
https://bugs.openjdk.java.net/browse/JD
On 28/08/2018 17:38, Stephen Colebourne wrote:
:
OK, so maybe we've established what could be done - a new method on
ClassLoader that would initially not work on implementations outside
the JDK.
So, there is a functionality gap here, but I'm guessing no particular
desire to make a change.
I don
http://cr.openjdk.java.net/~iignatyev//8210039/webrev.00/index.html
> 698 lines changed: 114 ins; 240 del; 344 mod
Hi all,
could you please review this clean up of jdk testlibrary?
the patch updates the tests to use jdk.test.lib.Platform instead of
jdk.testlibrary.OSInfo.OSType, cleans up OSInfo
On 28 August 2018 at 08:17, Alan Bateman wrote:
> On 28/08/2018 07:55, Peter Levart wrote:
> Right, and any class injected with Lookup.defineClass can be located with
> methods such as Class.forName or Lookup.findClass. There is no equivalent
> for resources, at least not without extending the Cla
Looks ok to me.
/Erik
On 2018-08-27 07:07, Maurizio Cimadamore wrote:
As I was about to push this, I realize there was a minor nit with the
way in which build.xml files found some classes inside the generated
.idea folder - that is, the path to this folder was defined in a
relative way from
Hi Volker,
Thanks for the corroboration. I’ll plan to push this tomorrow.
Brian
On Aug 28, 2018, at 5:12 AM, Volker Simonis wrote:
> Our internal testing was successful as well.
>
> Ready to push!
Hi,
Please review the changes for ISO 4217 Amendment #168 #169.
Bugs:
https://bugs.openjdk.java.net/browse/JDK-8208746 168
https://bugs.openjdk.java.net/browse/JDK-8209775 169
Only in amendment #168 has real currency data update for Java, but I
also updated the data version to #169 for con
Hi Andrew,
It was suggested that it would be preferable to dial down the compilation
settings for the fdlibm code rather than make a source code change. Was this
investigated?
Thanks,
Brian
On Aug 28, 2018, at 7:18 AM, Andrew Leonard wrote:
> We have discovered issues with gcc 7.3 on zLinux
Hi,
We have discovered issues with gcc 7.3 on zLinux, combined with OpenJDK's
default compiler options has highlighted a couple of native code issues,
with undefined behaviours:
- validating loop test array bounds
- left shifts of negative values
I have created bug https://bugs.openjdk.java
On Tue, Aug 28, 2018 at 2:26 AM Brian Burkhalter
wrote:
>
> Hi Volker,
>
> On Aug 27, 2018, at 6:53 AM, Volker Simonis wrote:
>
> sorry, I'm a little late in the game. I've just looked at your change
> and in general it looks good!
>
>
> Thanks: better late than never!
>
> There's one thing howev
On 08/28/2018 08:55 AM, Peter Levart wrote:
MethodHandles.Lookup.defineClass() allows a class to be pushed into an
existing ClassLoader & Module, but I'm unaware of an equivalent for
resources, and that seems like a gap, regardless of use case.
ClassLoader (the Java part of it at least, whic
On 28/08/2018 07:55, Peter Levart wrote:
:
What you are proposing as "defineResource()" API is therefore not a
parallel of defineClass(). ClassLoader API is all about "searching"
for resources (bytecode and other kinds) while defineClass() has
nothing to do with "searching" and everything to
20 matches
Mail list logo
