Hi,
can I please have a review for this trivial test fix?
http://cr.openjdk.java.net/~simonis/webrevs/2018/8206436/
https://bugs.openjdk.java.net/browse/JDK-8206436
The problem is that the test contains some non-ASCII characters in
comments which makes the compilation fail for non-Unicode locale
Hi,
On 6/07/2018 3:10 PM, Bhaktavatsal R Maram wrote:
Hi,
Sorry for the trouble. It had got compiled in my build environment, might be
due to encoding is different.
Yes likely the encoding.
Please check if following patch make sense.
Yes looks fine. Only the latter two are needed to fix
Thanks for opening the bug. I’ll fix it in an hour when I’m in the office.
Regards,
Volker
David Holmes schrieb am Fr. 6. Juli 2018 um 03:00:
> Filed: https://bugs.openjdk.java.net/browse/JDK-8206436
>
> David
>
> On 6/07/2018 7:51 AM, David Holmes wrote:
> > edit to TestIBMBugs.java contains n
Hi,
Sorry for the trouble. It had got compiled in my build environment, might be
due to encoding is different. Please check if following patch make sense.
diff -r 5cb2d4a8b8d4 test/jdk/sun/nio/cs/TestIBMBugs.java
--- a/test/jdk/sun/nio/cs/TestIBMBugs.java Tue Jun 12 13:00:50 2018 +0530
+++
Hello,
With javac support for -source/-target 6 and 1.6 planned to be removed
later in JDK 12 (JDK-8028563), please review the removal of usage of
these options in the non-manual jdk regression tests:
http://cr.openjdk.java.net/~darcy/8206440.0/
Patch below.
Thanks,
-Joe
--- old/test/
Hi Ioi,
Thanks for the review!
> On Jul 5, 2018, at 5:45 PM, Ioi Lam wrote:
>
> Hi Jiangli,
>
> Thank you so much for working on this. I think it's great that we can get the
> start-up improvement by archiving the ModuleDescriptor.
>
> I just have some coding style comments regarding heapShar
The test still fails in JDK 11 CI tier 2 after this patch was applied.
See link in bug report.
David
On 6/07/2018 3:44 AM, Jim Laskey wrote:
+1
On Jul 5, 2018, at 2:42 PM, Srinivas Dama wrote:
Hi,
Please review
Webrev: http://cr.openjdk.java.net/~sdama/8198405/webrev.00/
Bug: https://bugs
Filed: https://bugs.openjdk.java.net/browse/JDK-8206436
David
On 6/07/2018 7:51 AM, David Holmes wrote:
edit to TestIBMBugs.java contains non-ascii characters in the comments,
resulting in javac failure:
/scratch/opt/mach5/mesos/work_dir/jib-master/install/jdk11-jdk.1010/src.full/open/test/jd
Hi Jiangli,
Thank you so much for working on this. I think it's great that we can
get the
start-up improvement by archiving the ModuleDescriptor.
I just have some coding style comments regarding heapShared.cpp. This file
contains the code for coping objects and relocating pointers. By its natu
Hello,
Note that another approach would be to change the spec to match the
long-standing implementation. That is the the default resolution patch
in situations like this, but in this case I don't think it matters very
much how the matter is resolved.
Cheers,
-Joe
On 6/29/2018 7:21 PM, Iva
Volker,
This change breaks our testing. Your edit to TestIBMBugs.java contains
non-ascii characters in the comments, resulting in javac failure:
/scratch/opt/mach5/mesos/work_dir/jib-master/install/jdk11-jdk.1010/src.full/open/test/jdk/sun/nio/cs/TestIBMBugs.java:191:
error: unmappable charac
Hi Naoto,
Looks fine
Roger
On 7/5/2018 4:16 PM, Naoto Sato wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8206350
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8206350/webrev.00/
The fix is to set the script
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8206350
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8206350/webrev.00/
The fix is to set the script property explicitly empty so that the test
works on platforms that pro
Hi Joe,
The change looks fine as does the newly added test
> On Jul 5, 2018, at 3:29 PM, Joe Wang wrote:
>
> Hi,
>
> Please review a quick fix for a missing throw in what supposed to be a throw
> statement.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8206164
> webrev: http://cr.openjd
Hi,
Please review a quick fix for a missing throw in what supposed to be a
throw statement.
JBS: https://bugs.openjdk.java.net/browse/JDK-8206164
webrev: http://cr.openjdk.java.net/~joehw/jdk12/8206164/webrev/
Thanks,
Joe
+1
> On Jul 5, 2018, at 2:42 PM, Srinivas Dama wrote:
>
> Hi,
>
> Please review
> Webrev: http://cr.openjdk.java.net/~sdama/8198405/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8198405
>
> Regards,
> Srinivas
Hi,
Please review
Webrev: http://cr.openjdk.java.net/~sdama/8198405/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8198405
Regards,
Srinivas
On 7/4/18, 5:41 AM, Nasser Ebrahim wrote:
Hello,
Am starting this mail thread to discuss about adding new IBM extended
charsets. The questions is whether we need to add the new extended
charsets to jdk.charsets or to a new separate charset provider/module like
jdk.ibmcharsets. This discussion is
The null check will be removed as part of the next jsr166 integration.
http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/miscellaneous/index.html
On Wed, Jul 4, 2018 at 2:42 AM, Zheka Kozlov wrote:
> I noticed dead code in java.util.HashMap.merge():
>
> public V merge(K key, V va
19 matches
Mail list logo
