Re: RFR JDK-8205540: hotspot/jtreg/vmTestbase/nsk/jdb/trace/trace001/trace001.java fails with Debuggee did not exit after 15 commands

On 24/06/2018 4:16 PM, Alan Bateman wrote: On 23/06/2018 11:11, Peter Levart wrote: Please review the following tiny change that delays TerminatingThreadLocal class initialization until the 1st thread that actually uses thread locals, exits: http://cr.openjdk.java.net/~plevart/jdk-dev/82055

Re: RFR 8202292 : test/jdk/java/io/FileOutputStream/UnreferencedFOSClosesFd.java fails with "raw fd count wrong"

Hi Roger, On 23/06/2018 12:49 AM, Roger Riggs wrote: Hi Brian, Mandy, Listing the open file descriptors can be a useful utility. Originally I thought it was a temporary and throw away code. To be a utility it needed to be a bit more general (sending the output to a particular stream). Thanks

Re: RFR: jsr166 integration 2018-06

On 06/22/2018 01:28 PM, Paul Sandoz wrote: >> 8203864: Execution error in Java's Timsort >> http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/TimSort/index.html >> https://bugs.openjdk.java.net/browse/JDK-8203864 >> > > 406 if (n > 0 && runLen[n-1] <= runLen[n] + runL

Re: RFR: 8203629: Produce events in the JDK without a dependency on jdk.jfr

On 2018-06-24 19:00, Alan Bateman wrote: On 24/06/2018 12:42, Erik Gahlin wrote: I have updated jdk.internal.event.Event class with comments. http://cr.openjdk.java.net/~egahlin/8203629.2/ It is basically a copy the comments in jdk.jfr.Event, but without reference to classes in the JFR module

Re: RFR(JDK11/NIO) 8205058 throw CharacterCodingException --> Re: RFR (JDK11/NIO) 8201276: (fs) Add methods to Files for reading/writing a string from/to a file

On 20/06/2018 04:32, Joe Wang wrote: Thanks Alan.  I created 8205058 to capture your suggestions. Please see below for more details. Changed the internal APIs to throw CCE instead. In the same way as the previous changeset for 8201276, these methods are made specific for the use cases (though

Re: RFR: 8203629: Produce events in the JDK without a dependency on jdk.jfr

On 24/06/2018 12:42, Erik Gahlin wrote: I have updated jdk.internal.event.Event class with comments. http://cr.openjdk.java.net/~egahlin/8203629.2/ It is basically a copy the comments in jdk.jfr.Event, but without reference to classes in the JFR module. The rationale for using a class instea

Re: RFR: 8148188: Enhance the security libraries to record events of interest

Hi Sean, Some of the changes in the webrev belongs to JDK-8203629 and should be removed for clarity. Some initial comments: default.jfc, profile.jfr: The events should not have control="enable-exceptions". The purpose of the control attribute is so to provide parameterized configuration of

Re: RFR: 8203629: Produce events in the JDK without a dependency on jdk.jfr

On 2018-06-21 09:52, Alan Bateman wrote: On 20/06/2018 18:59, Erik Gahlin wrote: : Also all the methods are empty which makes me wonder if they should be abstract (as the class is abstract) or whether it should be an interface. Abstract is needed to prevent user from instantiating the class.