Re: RFR: 8201259: Fix warning with VS2017 in jdk.pack

2018-04-20 Thread Erik Joelsson
Looks good to me. /Erik On 2018-04-20 14:19, Kumar Srinivasan wrote: Hello, Please review fix [1] for VS2017 to compile pack200 native header file,  without warnings. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8201259/

RFR: 8201259: Fix warning with VS2017 in jdk.pack

2018-04-20 Thread Kumar Srinivasan
Hello, Please review fix [1] for VS2017 to compile pack200 native header file, without warnings. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8201259/

Re: RFR: 6805750: Improve handling of Attributes.Name

2018-04-20 Thread Xueming Shen
Claes, It loogsk good. One minor nit is that the "hashCode" check in Name.equals() might not be really necessary, given in most/normal use scenario the "Name" is used as a key in Attributes.map, which is a LinkedHashMap. Arguably the hashcode should be check already during lookup. Agreed what

Re: [jdk8u-dev] RFR: 8196491: Newlines in JAXB string values of SOAP-requests are escaped to " "

2018-04-20 Thread Lance Andersen
The changes look OK Aleks Best Lance > On Apr 20, 2018, at 12:40 PM, Aleks Efimov wrote: > > Hello, > > Would you, please, review the fix for JAXWS regression bug [1] that has been > introduced by a fix that tried to preserve whitespaces in WS parameters [2]. > The proposed fix addresses the r

[jdk8u-dev] RFR: 8196491: Newlines in JAXB string values of SOAP-requests are escaped to " "

2018-04-20 Thread Aleks Efimov
Hello, Would you, please, review the fix for JAXWS regression bug [1] that has been introduced by a fix that tried to preserve whitespaces in WS parameters [2]. The proposed fix addresses the reported UnsupportedOperationException and brings the JDK7 and JDK8 in-sync in terms of white-space pr

RFR: 6805750: Improve handling of Attributes.Name

2018-04-20 Thread Claes Redestad
Hi, please review this patch to address some of the legacy performance concerns arising when dealing extensively with java.util.jar.Attributes.Name (mainly when parsing jar Webrev: http://cr.openjdk.java.net/~redestad/6805750/open.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-6805750 Whil

Upload of drop-in replacement for Double:::toString(double)

2018-04-20 Thread raffaello . giulietti
Hi Brian, as agreed in [1], here is the first batch of my code. It includes everything needed to replace Double::toString(double), if so wished. It is accompanied by some JUnit tests in math.DoubleToDecimalTest and by straightforward benchmarks in math.D2DBenchmark The code still has notices attr

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-20 Thread Lindenmaier, Goetz
Hi David, What about this: java.lang.ArrayIndexOutOfBoundsException: Arraycopy source index -1 out-of-bounds for double[10]. java.lang.ArrayIndexOutOfBoundsException: Arraycopy target index 10 out-of-bounds for object array[10]. java.lang.ArrayIndexOutOfBoundsException: Negative len

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-20 Thread David Holmes
Hi Goetz, This is not a file by file review ... On 19/04/2018 10:24 PM, Lindenmaier, Goetz wrote: Hi, New webrev: http://cr.openjdk.java.net/~goetz/wr18/8201593-lenInAIOOB/02/ I admit my wording is not optimal. src/hotspot/share/oops/typeArrayKlass.cpp Sorry but this is still far too verbo

Re: RFR of JDK-8201469,test under java/rmi should be restricted to not run concurrently

2018-04-20 Thread Hamlin Li
Is someone available to review the following patch? Thank you -Hamlin On 19/04/2018 4:17 PM, Hamlin Li wrote: would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8201469 http://cr.openjdk.java.net/~mli/8201469/webrev.00/ ( For othervm.dirs property, I