Please review a small simplification of the initialization of System
properties for
language, country, script, and variant. Some steps for initializing
them are unnecessary.
The tests pass; a careful review would be appreciated so as to avoid
breakage.
Webrev:
http://cr.openjdk.java.net/~rr
On Fri, Mar 16, 2018 at 8:58 AM, Stephen Colebourne
wrote:
> On 14 March 2018 at 23:05, Michael Hixson wrote:
>> For example, does ``.lines() produce an empty stream?
>
> I believe `` is a compile error.
> (A mistake IMO, but necessary if you have unlimited delimiters)
Ah, oops. I meant to ask
Hi Ian, Thomas,
Some background on the bulk copying for byte buffers after talking with Mikael
who worked on these changes a few years ago.
Please correct the following if needed as our memory is hazy :-)
IIRC at the time we felt this was a reasonable thing to do because C2 did not
strip mine
On 14 March 2018 at 23:05, Michael Hixson wrote:
> For example, does ``.lines() produce an empty stream?
I believe `` is a compile error.
(A mistake IMO, but necessary if you have unlimited delimiters)
Stephen
Hi Patrick,
Looks good,
If there are no more comments, I can sponsor the commit.
Thanks, Roger
On 3/16/18 2:10 AM, Patrick Reinhart wrote:
Just coming back on my webrev [1]. Are there any more feedbacks implementation
wise to that latest version? If no I would need a commit sponsor for this
Hi ROger,
On Mar 16, 2018, at 7:59 AM, Roger Riggs wrote:
> ByteArrayOutputStream: 166: Add spaces after "," in the code.
Done: webrev.01 updated in place.
> Write:
> Thanks for converting to TestNG.
> There are probably some more testng'ish ways of coding the test but its fine
> as is.
>
Hi Brian,
ByteArrayOutputStream: 166: Add spaces after "," in the code.
Write:
Thanks for converting to TestNG.
There are probably some more testng'ish ways of coding the test but
its fine as is.
All set as far as I'm concerned.
Thanks, Roger
On 3/15/18 5:52 PM, Brian Burkhalter wrote:
O
Martin,
I have been following this work that Shura is doing. The checks are
fairly expensive, and we would not want to perform them during routine
test execution.
However, one option would be to include a separate binary in the jtreg
family, that can be run separately.
There are no plans a
Sorry, that was an error on my part, caused by too much context
switching. I've posted an update at
https://github.com/dmlloyd/openjdk/commit/zlib-bytebuffer-v13 which is
also attached.
On Wed, Mar 14, 2018 at 8:53 PM, Xueming Shen wrote:
> Hi David,
>
> https://github.com/dmlloyd/openjdk/commit
On 03/16/2018 02:18 AM, Tagir Valeev wrote:
> Hello!
>
> Experimenting with code static analysis I found several always false
> expressions in ConcurrentHashMap source. See addCount method:
>
> http://hg.openjdk.java.net/jdk/jdk/file/422615764e12/src/java.base/share/classes/java/util/concurrent/C
On 15/03/2018 22:40, Alexandre (Shura) Iline wrote:
Hi,
Please take a quick look on fix adding missing module dependencies to tests in
:tier1 jdk tests.
Webrev: http://cr.openjdk.java.net/~shurailine/8199616/webrev.00
Some of these dependences weren't obvious until I skimmed more of the
test
11 matches
Mail list logo
