Thanks for the updates, Paul!
Some comments inlined.
On 23.08.2017 1:38, Paul Sandoz wrote:
First, implied `genericMethodType(N)` still fails with N > 255. It could safely
be `genericMethodType(M)` though.
Well spotted! I tweaked it to:
* Determine the general type {@code TN} of {@code N} a
Hi Adam,
Copying hotspot-dev.
Please find my answers inline.
On Wed, Aug 23, 2017 at 8:51 PM, Adam Farley8
wrote:
> Hi Thomas,
>
> First, thank you for your time. :)
>
> The exit hook you recommend sounds like a fine workaround, though I
> suggest a return code would make a better long term so
Hi Adam,
cc'ing hotspot runtime dev as runtime own JNI and the invocation API -
and some of the problematic code resides in the VM.
On 24/08/2017 1:54 AM, Adam Farley8 wrote:
Hi All,
Problem: Several of Java's "c" files call exit(0) if you pass certain
command-line options to JNI_CreateJavaV
On 8/23/17 8:58 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8186613/webrev.00/index.html
58 lines changed: 0 ins; 57 del; 1 mod; 64 unchg
Hi all,
could you please review this tiny patch which removes ClassFileInstaller from
jdk/test/lib/testlibrary and updates the tests t
http://cr.openjdk.java.net/~iignatyev//8186613/webrev.00/index.html
> 58 lines changed: 0 ins; 57 del; 1 mod; 64 unchg
Hi all,
could you please review this tiny patch which removes ClassFileInstaller from
jdk/test/lib/testlibrary and updates the tests to use ClassFileInstaller from
/test/lib?
Looks good.
I would rename pme to something like mismatchedProviders
On Wed, Aug 23, 2017 at 6:05 PM, Xueming Shen
wrote:
> Hi
>
> Please help review the change for JDK-8186142.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8186142
> Webrev: http://cr.openjdk.java.net/~sherman/8186142/web
Hi
Please help review the change for JDK-8186142.
Issue: https://bugs.openjdk.java.net/browse/JDK-8186142
Webrev: http://cr.openjdk.java.net/~sherman/8186142/webrev/
Thanks,
Sherman
On 8/23/17 4:02 PM, Jonathan Gibbons wrote:
Removed ArrayDeque from patch.
Updated webrev and API
Webrev: http://cr.openjdk.java.net/~jjg/8186684/webrev.01/index.html
API: http://cr.openjdk.java.net/~jjg/8186684/api.01/overview-summary.html
src/java.base/share/classes/java/lang/module/Config
Removed ArrayDeque from patch.
Updated webrev and API
Webrev: http://cr.openjdk.java.net/~jjg/8186684/webrev.01/index.html
API: http://cr.openjdk.java.net/~jjg/8186684/api.01/overview-summary.html
-- Jon
On 08/23/2017 03:29 PM, Martin Buchholz wrote:
Jon, please just drop ArrayDeque. We'll fix
On Wed, Aug 23, 2017 at 3:37 PM, Jonathan Gibbons <
jonathan.gibb...@oracle.com> wrote:
> Martin,
>
> Understood.
>
> Do you want to file a followup JBS issue, or shall I?
>
It'll just arrive as part of the next jsr166 integration; train is already
en route.
Martin,
Understood.
Do you want to file a followup JBS issue, or shall I?
-- Jon
On 08/23/2017 03:29 PM, Martin Buchholz wrote:
Jon, please just drop ArrayDeque. We'll fix it separately by renaming
the private add method.
On Wed, Aug 23, 2017 at 3:17 PM, Jonathan Gibbons
mailto:jonathan.g
On 2017-08-23 18:35, Aleksey Shipilev wrote:
Sure, mind if I defer that to a future RFE, though?:-)
Oh, c'mon, that should be a simple change:) And it makes the patch (that we
would have to backport
some day) more readable!
Ok then:
http://cr.openjdk.java.net/~redestad/8186500/jdk.04/
/C
Jon, please just drop ArrayDeque. We'll fix it separately by renaming the
private add method.
On Wed, Aug 23, 2017 at 3:17 PM, Jonathan Gibbons <
jonathan.gibb...@oracle.com> wrote:
>
> On 08/23/2017 03:12 PM, Martin Buchholz wrote:
>
>
>
> On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons <
> j
On 08/23/2017 03:16 PM, Martin Buchholz wrote:
On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons
mailto:jonathan.gibb...@oracle.com>> wrote:
javadoc is at fault for not giving the warning, and if we fixed
the tool first, we would just get the warnings, and would still
have to
On 08/23/2017 03:12 PM, Martin Buchholz wrote:
On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons
mailto:jonathan.gibb...@oracle.com>> wrote:
Although it is not immediately clear in the webrev, the underlying
characteristic of all places where I had to add an empty arg list
is t
On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons <
jonathan.gibb...@oracle.com> wrote:
>
> javadoc is at fault for not giving the warning, and if we fixed the tool
> first, we would just get the warnings, and would still have to fix the
> comments.
>
Yeah, but you get synergy - fixing the warnin
On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons <
jonathan.gibb...@oracle.com> wrote:
>
> Although it is not immediately clear in the webrev, the underlying
> characteristic of all places where I had to add an empty arg list is that
> there was a private field of the same name in scope.
>
I too
Hi Martin,
On 08/23/2017 02:41 PM, Martin Buchholz wrote:
I would be inclined to "fix the tool first" if it's not too hard.
Both should be fixed. Going back in time, the spec has long said:
http://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#specifyingname
If any met
Hi Jon
The changes provided look reasonable
> On Aug 23, 2017, at 5:15 PM, Jonathan Gibbons
> wrote:
>
> Please review a reasonably simple patch to fix most of the broken links in
> the API docs for java.base module.
> All the fixes are in the small "typo" category, and so should not material
The changes in these packages look good.
Brian
On Aug 23, 2017, at 2:15 PM, Jonathan Gibbons
wrote:
> java.nio.channels.spi
> java.nio.file
> java.nio.file.attribute
I would be inclined to "fix the tool first" if it's not too hard.
---
Shouldn't the below have a proper arglist?
Consider instead
{@link #add(Object) add(E)}
Consider fixing the javadoc tool so that one can actually write {@link
#add(E)}
--- old/src/java.base/share/classes/java/util/ArrayDeque.
src/java.base/share/classes/java/util/jar/package-info.java
src/java.base/share/classes/java/util/zip/Deflater.java
src/java.base/share/classes/java/util/zip/Inflater.java
looks good.
On 8/23/17, 2:15 PM, Jonathan Gibbons wrote:
Please review a reasonably simple patch to fix most of th
On Wed, Aug 23, 2017 at 6:36 AM, Alan Bateman
wrote:
> On 22/08/2017 01:49, Tom Hood wrote:
>
>> Thanks, Mandy. I was beginning to think my followup question might have
>> gotten lost and I was considering a new post.
>>
>> I'm unable to get --illegal-access=permits to work for our webstart app
Please review a reasonably simple patch to fix most of the broken links
in the API docs for java.base module.
All the fixes are in the small "typo" category, and so should not
materially affect the specification.
I've provided a copy of the API, in case folk want to test the updated
links. Th
Hi Thomas,
First, thank you for your time. :)
The exit hook you recommend sounds like a fine workaround, though I
suggest a return code would make a better long term solution.
Especially if the exit hook might be broken. :)
I don't think we can expect new JNI users to be familiar with the exit
Hi Adam,
would the JNI exit hook not solve your problem (JavaVMOption "exit")? One
could use it to intercept any exit(2) calls.
However, I am not sure it always fires, and if it does not, whether this
should be considered a bug. The official JNI documentation is pretty sparse
(
http://docs.oracle
On 08/23/2017 06:31 PM, Claes Redestad wrote:
>
>
> On 08/23/2017 06:31 PM, Aleksey Shipilev wrote:
>> On 08/23/2017 06:26 PM, Claes Redestad wrote:
>>> On 08/23/2017 06:08 PM, Aleksey Shipilev wrote:
332 Object value = Objects.requireNonNull(cnst);
333 if
On 08/23/2017 06:31 PM, Aleksey Shipilev wrote:
On 08/23/2017 06:26 PM, Claes Redestad wrote:
On 08/23/2017 06:08 PM, Aleksey Shipilev wrote:
332 Object value = Objects.requireNonNull(cnst);
333 if (!value.getClass().isPrimitive()) {
334 this.v
On 08/23/2017 06:26 PM, Claes Redestad wrote:
> On 08/23/2017 06:08 PM, Aleksey Shipilev wrote:
>> 332 Object value = Objects.requireNonNull(cnst);
>> 333 if (!value.getClass().isPrimitive()) {
>> 334 this.value = String.valueOf(cnst);
>> 335
On 08/23/2017 06:08 PM, Aleksey Shipilev wrote:
On 08/23/2017 01:52 PM, Claes Redestad wrote:
What I wasn't sure about is *when* the String.valueOf should happen, but as
makeConcatWithConstants specify "If necessary, the factory would call toString
to
perform a one-time String conversion" then
Thank you David.
Do I need a second reviewer here?
cheers
> On Aug 22, 2017, at 9:15 PM, David Holmes wrote:
>
> Hi Gerard,
>
> On 23/08/2017 3:41 AM, Gerard Ziemski wrote:
>> hi all,
>> The FlatProfiler (i.e. -Xprof) has been deprecated in jdk9, and now it’s the
>> time to remove the code
On 08/23/2017 01:52 PM, Claes Redestad wrote:
> What I wasn't sure about is *when* the String.valueOf should happen, but as
> makeConcatWithConstants specify "If necessary, the factory would call
> toString to
> perform a one-time String conversion" then I think we could (should?) do this
> at
>
Hi All,
Problem: Several of Java's "c" files call exit(0) if you pass certain
command-line options to JNI_CreateJavaVM, which can terminate the C++ code
JNI users use to initialise the JVM.
Example: If you write some C++ code that calls JNI_CreateJavaVM, and uses
the option "-agentlib:jdwp=hel
On 8/23/17 6:36 AM, Alan Bateman wrote:
On 22/08/2017 01:49, Tom Hood wrote:
Thanks, Mandy. I was beginning to think my followup question might have
gotten lost and I was considering a new post.
I'm unable to get --illegal-access=permits to work for our webstart
app by
setting it in the Ja
On 22/08/2017 01:49, Tom Hood wrote:
Thanks, Mandy. I was beginning to think my followup question might have
gotten lost and I was considering a new post.
I'm unable to get --illegal-access=permits to work for our webstart app by
setting it in the Java Control Panel with the 9+181 build. It ap
Right,
the Wrapper.* code appears to work fine, but makeConcatWithConstants has
pre-existing issues with non-primitive, non-String constants.
What I wasn't sure about is *when* the String.valueOf should happen, but as
makeConcatWithConstants specify "If necessary, the factory would call
toStrin
36 matches
Mail list logo
