Re: RFR: JDK-8133680 add Stream.foldLeft() terminal operation

2017-08-16 Thread Tagir Valeev
Hello, Rémi! People don't use forEachOrdered not because they don't care about order, but because they don't care about parallelism and forEach does the same (for sequential stream) with a shorter name. Similar to foldLeft. Currently people often use reduce instead of missing foldLeft, feeding red

Re: RFR JDK-8186227: jdk/nio/zipfs/ZeroDate.java fails on Windows with "IllegalArgumentException: Illegal character in opaque part at index 13"

2017-08-16 Thread Martin Buchholz
Thanks! On Wed, Aug 16, 2017 at 12:36 PM, Xueming Shen wrote: > Hi Martin, > > Confirmed it fixed the issue on windows platforms. > > issue: https://bugs.openjdk.java.net/browse/JDK-8186227 > webrev: http://cr.openjdk.java.net/~sherman/8186227 > > Please help review the change. > > Thanks, > She

Re: Manifest Add-Exports vs. command line --add-exports

2017-08-16 Thread Tom Hood
Thanks Richard. Sorry I didn't see your post before hitting send. So does this mean there is no workaround for a webstart app that requires a lot of the --add-export options? On Wed, Aug 16, 2017 at 2:12 PM, Tom Hood wrote: > I found Alan's video (

Re: Manifest Add-Exports vs. command line --add-exports

2017-08-16 Thread Tom Hood
I found Alan's video (time: about 27:35) that goes with the slides pdf link and he mentions the Add-Exports line need to go in the manifest of the jar with the Main-Class. I just now tried that and it still didn't take effect. I'm still getting the sa

Re: Manifest Add-Exports vs. command line --add-exports

2017-08-16 Thread Richard Opalka
Hi Tom, Add-Exports option in manifest is used if and only if jar is executed via 'java -jar your.jar' command. The manifest Add-Exports option is ignored for jars on classpath. Rio On Wed, Aug 16, 2017 at 10:30 PM, Tom Hood wrote: > Hi, > > I need a little help understanding the difference

RFR: 8186314: code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change

2017-08-16 Thread Vicente Romero
Hi, Please review the fix for issue [1]. The fix can be found at [2]. The fix is minimal, reproduced below: --- old/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/soap/MessageImpl.java 2017-08-16 16:31:21.403085344 -0400 +++ new/src/java.xml.ws/share/classes/com/sun/xml/i

Manifest Add-Exports vs. command line --add-exports

2017-08-16 Thread Tom Hood
Hi, I need a little help understanding the difference between "Add-Exports:" in a jar's manifest vs. the command line arg --add-exports. I can get --add-exports to work, but not Add-Exports. JDK Version: 9 build 181 windows 64 Slide 23 of http://openjdk.java.net/projects/jigsaw/talks/prepare- f

Re: RFR JDK-8186227: jdk/nio/zipfs/ZeroDate.java fails on Windows with "IllegalArgumentException: Illegal character in opaque part at index 13"

2017-08-16 Thread Roger Riggs
Hi Sherman, Looks good Regards, Roger On 8/16/2017 3:36 PM, Xueming Shen wrote: Hi Martin, Confirmed it fixed the issue on windows platforms. issue: https://bugs.openjdk.java.net/browse/JDK-8186227 webrev: http://cr.openjdk.java.net/~sherman/8186227 Please help review the change. Thanks, S

RFR JDK-8186227: jdk/nio/zipfs/ZeroDate.java fails on Windows with "IllegalArgumentException: Illegal character in opaque part at index 13"

2017-08-16 Thread Xueming Shen
Hi Martin, Confirmed it fixed the issue on windows platforms. issue: https://bugs.openjdk.java.net/browse/JDK-8186227 webrev: http://cr.openjdk.java.net/~sherman/8186227 Please help review the change. Thanks, Sherman

Re: RFR: JDK-8133680 add Stream.foldLeft() terminal operation

2017-08-16 Thread Remi Forax
Yes, reconsidering old decision is healthy, but you need provide some data/good reason to explain what has changed. By example, I'm curious about the number of occurrences of forEachOrdered in the wild, given that fold left (a kind of reduce) will be even less used than a forEachOrdered (a kin

Re: RFR: JDK-8133680 add Stream.foldLeft() terminal operation

2017-08-16 Thread Remi Forax
:) let say that fold left is not as useful as one may think when used in parallel. Remi On August 15, 2017 4:49:44 PM GMT+02:00, Brian Goetz wrote: >It's an overstatement to say that forEachOrdered/foldLeft cannot >exploit >parallelism. If I have a stream: > > stream.parallel() >

Re: java.util.stream 'map' method, proposal of method name change

2017-08-16 Thread Remi Forax
On August 15, 2017 6:51:00 PM GMT+02:00, Jonathan Bluett-Duncan wrote: >Hi Krunoslav, > >I think the reason the method was named `map` rather than `replaceWith` >or >an equivalent name, is because `map` is a well-known name for this >sort of *higher-order >function*. The name itself has been ar