Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

2017-06-09 Thread Alan Bateman
On 09/06/2017 19:36, Igor Ignatyev wrote: Alan, Chris, it seems I had some problems uploading the webrev, I have reuploaded it to the same place -- http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html -- Igor This mostly looks okay but there are still a few tests being penaliz

Re: Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

2017-06-09 Thread Jonathan Gibbons
On 06/06/2017 07:14 PM, Weijun Wang wrote: On 06/06/2017 01:43 PM, Felix Yang wrote: Missed "Add back read access" before trying to delete it? Based on my test results (local and JPRT), it deleted w/o any exceptions. This was originally added by Max in https://bugs.openjdk.java.net/browse/

Re: RFR 10: JDK-8161207: Remove extra MethodHandle subclass in MethodHandleImpl

2017-06-09 Thread Paul Sandoz
+1 Minor thing, update the dates on the license in LambdaFormEditor and MethodHandleImpl. Paul. > On 9 Jun 2017, at 07:49, Ron Pressler wrote: > > Hi. > > Please review, > Bug: https://bugs.openjdk.java.net/browse/JDK-8161207 > Webrev: > http://cr.openjdk.java.net/~rpressler/jdk10/JDK-81612

Re: [jdk9] RFR 8181824 Broken javadoc link in java.util.BitSet

2017-06-09 Thread Brian Burkhalter
+1 Brian On Jun 9, 2017, at 10:53 AM, Paul Sandoz wrote: > Hi, > > Please review this simple doc fix. > > Thanks, > Paul. > > diff -r ed1e99c1bba2 src/java.base/share/classes/java/util/BitSet.java > --- a/src/java.base/share/classes/java/util/BitSet.java Wed Jun 07 06:45:09 > 2017 -0700 > +

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

2017-06-09 Thread Igor Ignatyev
Alan, Chris, it seems I had some problems uploading the webrev, I have reuploaded it to the same place -- http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html -- Igor > On Jun 9, 2017, at 2:01 AM, Alan Bateman wrote: > > On 09/06/2017 07:42, Igor Ignatyev wrote: >> here is t

Re: [jdk9] RFR 8181824 Broken javadoc link in java.util.BitSet

2017-06-09 Thread Martin Buchholz
Looks good! (But RFE: one should be able to do this via @link syntax somehow ...) On Fri, Jun 9, 2017 at 10:53 AM, Paul Sandoz wrote: > Hi, > > Please review this simple doc fix. > > Thanks, > Paul. > > diff -r ed1e99c1bba2 src/java.base/share/classes/java/util/BitSet.java > --- a/src/java.base

[jdk9] RFR 8181824 Broken javadoc link in java.util.BitSet

2017-06-09 Thread Paul Sandoz
Hi, Please review this simple doc fix. Thanks, Paul. diff -r ed1e99c1bba2 src/java.base/share/classes/java/util/BitSet.java --- a/src/java.base/share/classes/java/util/BitSet.java Wed Jun 07 06:45:09 2017 -0700 +++ b/src/java.base/share/classes/java/util/BitSet.java Fri Jun 09 10:50:07 2017 -0

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

2017-06-09 Thread Mandy Chung
> On Jun 8, 2017, at 8:17 AM, Kumar Srinivasan > wrote: > > > Oops here are the webrevs: > Delta webrev: > http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/webrev.delta/ > Full webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/ > Looks good. Mandy

Re: [8u-dev] RFR (JAXWS): 8172297: In java 8, the marshalling with JAX-WS does not escape carriage return

2017-06-09 Thread Roman Grigoriadi
Looks good to me. Just a side note that escape handler can be overridden by "setting com.sun.xml.bind.characterEscapeHandler" or “com.sun.xml.bind.marshaller.CharacterEscapeHandler" properties on Marshaller. This is respected by XMLStreamWriterOutput escape handling. Roman > On 9 Jun 2017, a

Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

2017-06-09 Thread Alan Bateman
On 09/06/2017 09:41, Felix Yang wrote: Excuse me, Alan, could you have a look at this patch? This update looks okay. -Alan

RFR 10: JDK-8161207: Remove extra MethodHandle subclass in MethodHandleImpl

2017-06-09 Thread Ron Pressler
Hi. Please review, Bug: https://bugs.openjdk.java.net/browse/JDK-8161207 Webrev: http://cr.openjdk.java.net/~rpressler/jdk10/JDK-8161207-intrinsicmethodhandle/webrev/

[8u-dev] RFR (JAXWS): 8172297: In java 8, the marshalling with JAX-WS does not escape carriage return

2017-06-09 Thread Aleks Efimov
Hello, Please, help to review the fix that helps JAXWS marshaller to properly escape new-line and carriage return symbols in webservice string parameters: http://cr.openjdk.java.net/~aefimov/8172297/8/00 The source part of this fix is a partial backport of JAXWS-RI sync changes that addressed

Re: RFR 8181832: Broken link in javax/sql/rowset/spi/package-summary.html

2017-06-09 Thread Lance Andersen
> On Jun 9, 2017, at 9:26 AM, Alan Bateman wrote: > > > > On 09/06/2017 14:15, Lance Andersen wrote: >> Hi all, >> >> This patches addresses the broken link reported in JDK-8181832 >> >> >> $ hg diff >> diff -r 67ad6b89dd96 >> src/java.sql.rowset/share/classes/javax/sql/rowset/spi/pack

Re: RFR 8181832: Broken link in javax/sql/rowset/spi/package-summary.html

2017-06-09 Thread Alan Bateman
On 09/06/2017 14:15, Lance Andersen wrote: Hi all, This patches addresses the broken link reported in JDK-8181832 $ hg diff diff -r 67ad6b89dd96 src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package.html --- a/src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package.html

RFR 8181832: Broken link in javax/sql/rowset/spi/package-summary.html

2017-06-09 Thread Lance Andersen
Hi all, This patches addresses the broken link reported in JDK-8181832 $ hg diff diff -r 67ad6b89dd96 src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package.html --- a/src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package.html Wed Jun 07 15:05:35 2017 -0400 +++ b/src

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

2017-06-09 Thread Chris Hegarty
On 09/06/17 07:42, Igor Ignatyev wrote: here is the refreshed version of patch : http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html I get 404 Not Found on many links, e.g. http://cr.openjdk.java.net/~iig

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

2017-06-09 Thread Magnus Ihse Bursie
Looks good to me. /Magnus On 2017-06-08 17:17, Kumar Srinivasan wrote: Oops here are the webrevs: Delta webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/webrev.delta/ Full webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/ Kumar 1. Added a comment in the LauncherCo

Re: RFR(XXS) : 8181820: jdk/test/lib/Platform should not depend on jdk/test/lib/Utils

2017-06-09 Thread Chris Hegarty
On 08/06/17 23:52, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8181820/webrev.00/index.html 12 lines changed: 10 ins; 0 del; 2 mod; Hi all, could you please review this small patch which removes dependency on Utils from Platform test class? this patch is basically a part of

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

2017-06-09 Thread Alan Bateman
On 09/06/2017 07:42, Igor Ignatyev wrote: here is the refreshed version of patch : http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html there might be some new @build actions, b/c I have analyzed class file

Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

2017-06-09 Thread Felix Yang
Excuse me, Alan, could you have a look at this patch? Thanks, Felix On 2017/6/7 15:04, Felix Yang wrote: Hi Alan, updated patch. Keep the first version of OtherResourcesTest with clean-up. http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.02/ Thanks, Felix On 2017/6/7 0:36, Alan B