Re: RFR: jsr166 jdk? integration wave ?

2017-02-24 Thread Martin Buchholz
On Fri, Feb 24, 2017 at 2:59 AM, Chris Hegarty wrote: > Martin, > > > On 22 Feb 2017, at 20:30, Martin Buchholz wrote: > > > > We half promised "no more jdk9 changes", but ... > > > > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/ > jsr166-jdk9-integration/ > > > > as usual, I think they s

Re: Soften interface for javax.management.ObjectName.getInstance and friends

2017-02-24 Thread Daniel Fuchs
Hi Dave, I'm not sure this is quite a good idea because order doesn't count when comparing ObjectNames. So the folder analogy would just be a lure: /a/b/c would be equal to /a/c/b That said - I can see value in trying to get rid of the legacy Hashtable - so adding a new method that takes a Map

Re: RFR: JDK-8175177 - org/omg/CORBA/OrbPropertiesTest.java changes JDK under test

2017-02-24 Thread Alan Bateman
On 24/02/2017 11:52, Mark Sheppard wrote: thanks for the feedback Alan, Joe, Lance I'll look into the I18N runtime copy strategy ... might go with the expeditious manual test option for this one An alternative is to have the test run jlink to create a runtime image with java.corba, you'll

Re: RFR: JDK-8175177 - org/omg/CORBA/OrbPropertiesTest.java changes JDK under test

2017-02-24 Thread Mark Sheppard
thanks for the feedback Alan, Joe, Lance I'll look into the I18N runtime copy strategy ... might go with the expeditious manual test option for this one regards Mark On 24/02/2017 10:28, Alan Bateman wrote: On 24/02/2017 00:00, Mark Sheppard wrote: Hi, please oblige and review the foll

Re: RFR: jsr166 jdk? integration wave ?

2017-02-24 Thread Chris Hegarty
Martin, > On 22 Feb 2017, at 20:30, Martin Buchholz wrote: > > We half promised "no more jdk9 changes", but ... > > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ > > as usual, I think they should go into jdk9, but y'all probably tell me it's > too late (and that'

Re: RFR: JDK-8175177 - org/omg/CORBA/OrbPropertiesTest.java changes JDK under test

2017-02-24 Thread Alan Bateman
On 24/02/2017 00:00, Mark Sheppard wrote: Hi, please oblige and review the following change http://cr.openjdk.java.net/~msheppar/8175177/webrev/ for the issue reported in https://bugs.openjdk.java.net/browse/JDK-8175177 the test now explicitly removes the orb.properties file created by the