Re: RFR of JDK-8019538: TEST_BUG: java/rmi/activation/rmidViaInheritedChannel tests may fail

Is some one available to review the patch? Thank you -Hamlin On 2016/11/23 17:49, Hamlin Li wrote: Would you please review the fix for below bug? bug: https://bugs.openjdk.java.net/browse/JDK-8019538 webrev: http://cr.openjdk.java.net/~mli/8019538/webrev.00/ There are 4 issues in the bug, 2 i

RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

http://cr.openjdk.java.net/~weijun/8170408/webrev.00/ A lambda inside JDK is dumped, we should not count it in this test. Thanks Max

Re: RFR[9]: 8133719 java.lang.InternalError in java.lang.invoke.MethodHandleImpl$BindCaller.bindCaller

> On 23 Nov 2016, at 22:11, shilpi.rast...@oracle.com wrote: > > Hi All, > > Please review fix for > > https://bugs.openjdk.java.net/browse/JDK-8133719 > http://cr.openjdk.java.net/~srastogi/8133719/webrev.01/ > +1 Paul.

Re: RFR 8170248, Problem list javax/rmi/PortableRemoteObject/8146975/RmiIiopReturnValueTest.java

Hi Felix, The change looks fine, if you still want to put it on the ProblemList. Roger On 11/23/2016 12:17 AM, Felix Yang wrote: Excuse me, On 2016/11/23 13:15, Felix Yang wrote: Hi, this test fails frequently on Linux platforms. I suggest to exclude it until JDK-8169737 is fixed. Th

Re: RFR: 8169191: (tz) Support tzdata2016j

Thanks as always for keeping the tzdata pipeline moving! Looks good to me. On Mon, Nov 28, 2016 at 1:24 AM, Ramanand Patil wrote: > Hi all, > Please review the latest TZDATA integration (tzdata2016j) to JDK9. > Bug: https://bugs.openjdk.java.net/browse/JDK-8170316 > Webrev: http://cr.openjdk.jav

Re: RFR 8170155: StringBuffer and StringBuilder stream methods are not late-binding

> On 25 Nov 2016, at 02:47, Tobias Hartmann wrote: > >> I'm not sure if it is still desired to do the same boundary check in case of >> LATIN1 >> for the benefit of consistency. Assume there might be concurrent >> access/operation >> between val = this.value and count = this.count; (for Strin

Re: RFR: 8169631: [JAXP] XALAN: transformation of XML via namespace-unaware SAX input yields a different result than namespace-unaware DOM input

Hi Christoph, The changes look good. I also run the other tests (smoke test and etc.), and they all passed. Best, Joe On 11/25/16, 4:25 AM, Langer, Christoph wrote: Hi Joe, when trying to finish this up, I had a closer look again. I found out that it's necessary to look at attributes as we

Re: RFR(s) PPC64/s390x/aarch64: Poor StrictMath performance due to non-optimized compilation

Looks good. /Erik On 2016-11-28 17:28, Gustavo Romero wrote: Hi all, I'm re-sending due to JDK title update to include s390x and aarch64 archs. Could the following webrev be reviewed, please? webrev 1/2: http://cr.openjdk.java.net/~gromero/8170153/v2/ webrev 2/2: http://cr.openjdk.java.net/

RFR(s) PPC64/s390x/aarch64: Poor StrictMath performance due to non-optimized compilation

Hi all, I'm re-sending due to JDK title update to include s390x and aarch64 archs. Could the following webrev be reviewed, please? webrev 1/2: http://cr.openjdk.java.net/~gromero/8170153/v2/ webrev 2/2: http://cr.openjdk.java.net/~gromero/8170153/v2/jdk/ bug:https://bugs.openjdk.java.net

Re: [NEW BUG]: Reduce allocations in sun.reflect.annotation.AnnotationInvocationHandler.invoke()

On 2016-11-28 15:35, Christoph Dreis wrote: doing a bit of digging it appears a similar improvement - along with a lot of other things - was suggested and filed a few years back: https://bugs.openjdk.java.net/browse/JDK-8029019 Really sorry for missing that! Nothing to be sorry about: you b

Re: [NEW BUG]: Reduce allocations in sun.reflect.annotation.AnnotationInvocationHandler.invoke()

> doing a bit of digging it appears a similar improvement - along with a > lot of other things - was suggested and filed a few years back: > https://bugs.openjdk.java.net/browse/JDK-8029019 Really sorry for missing that!

Re: [NEW BUG]: Reduce allocations in sun.reflect.annotation.AnnotationInvocationHandler.invoke()

Hi, doing a bit of digging it appears a similar improvement - along with a lot of other things - was suggested and filed a few years back: https://bugs.openjdk.java.net/browse/JDK-8029019 Peter, this enhancement is currently assigned to you, but I guess you're not actively working on it. Any ob

Re: RFR 8170364: FilePermission path modified during merge

On 28/11/2016 08:40, Wang Weijun wrote: Hi Alan Updated webrev at http://cr.openjdk.java.net/~weijun/8170364/webrev.01 Changes since webrev.00: - a private constructor that can clones 4 fields and modifies 5 others - using lambda - test enhancement This looks much better. A minor nit

Re: [NEW BUG]: Reduce allocations in sun.reflect.annotation.AnnotationInvocationHandler.invoke()

Hi, Thank you for the quick response. I've signed the OCA already according to the contribution guidelines - I just wasn't sure where to put such a trivial enhancement. In a 10 minute profile I had around 600MB of allocations for cloning the types, so roughly 1MB/s. If you need the screensh

Re: [NEW BUG]: Reduce allocations in sun.reflect.annotation.AnnotationInvocationHandler.invoke()

Hi, for general guidelines on contributing: http://openjdk.java.net/contribute/ [1] As for the patch I think it looks good, but out of curiosity I wonder if you have any numbers on how much allocations you see in these methods and how much this patch helps? A non-escaping clone like this shoul

Re: RFR(s) 8170153: PPC64: Poor StrictMath performance due to non-optimized compilation

Hi Volker, Sorry for not replying earlier, it was day-off on Friday here... On 25-11-2016 11:32, Volker Simonis wrote: > Hi Gustavo, > > we've realized that we have exactly the same problem on Linux/s390 so > I hope you don't mind that I've updated the bug and the webrev to also > include the fi

[NEW BUG]: Reduce allocations in sun.reflect.annotation.AnnotationInvocationHandler.invoke()

Hey, I'm new to the OpenJDK and not sure (yet) how the procedure especially for new bugs/enhancement is. So I apologise upfront if I made any mistakes. I'm working mostly with the Spring-Framework/Spring-Boot in my current projects. In these frameworks a lot of dynamic proxying can happen.

RFR: 8169191: (tz) Support tzdata2016j

Hi all, Please review the latest TZDATA integration (tzdata2016j) to JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8170316 Webrev: http://cr.openjdk.java.net/~rpatil/8170316/webrev.00/ All the TimeZone related tests are passed after integration. Regards, Ramanand.

Re: RFR 8170364: FilePermission path modified during merge

Hi Alan Updated webrev at http://cr.openjdk.java.net/~weijun/8170364/webrev.01 Changes since webrev.00: - a private constructor that can clones 4 fields and modifies 5 others - using lambda - test enhancement Thanks Max