Would you please review below fix?
bug: https://bugs.openjdk.java.net/browse/JDK-8168975
webrev: http://cr.openjdk.java.net/~mli/8168975/webrev.00/
Root Cause: There is a time window between RMID.start() and
RMID.restart(), interloper can step in and bind to the port used by RMID
in RMID.start
> On Nov 15, 2016, at 4:41 AM, Zoltán Majó wrote:
>
>
> I think the sentence in webrev.01
>
> (1) "If a registered referenceceases to be strongly reachable itself, then it
> may never be enqueued."
>
> is sufficient. I think we want to make a statement only about what happens
> when a refer
Hi Zoltan,
First, I'm okay with latest webrev.
Second, I don't want to confuse things but need to correct one thing ...
On 15/11/2016 10:41 PM, Zoltán Majó wrote:
Hi Mandy,
thank you for looking at this! Please find more details below.
On 11/15/2016 02:51 AM, Mandy Chung wrote:
On Nov 14,
> On Nov 15, 2016, at 4:21 PM, Mandy Chung wrote:
>
>
>> On Nov 15, 2016, at 4:04 PM, David DeHaven wrote:
>>
>>
> Please review the (fairly straightforward) JDK changes needed to support
> launching JavaFX applications in a named module.
>
> JBS:
> https://bugs.openjdk
> On Nov 15, 2016, at 4:04 PM, David DeHaven wrote:
>
>
Please review the (fairly straightforward) JDK changes needed to support
launching JavaFX applications in a named module.
JBS:
https://bugs.openjdk.java.net/browse/JDK-8169289
Webrev:
http://cr.op
>>> Please review the (fairly straightforward) JDK changes needed to support
>>> launching JavaFX applications in a named module.
>>>
>>> JBS:
>>> https://bugs.openjdk.java.net/browse/JDK-8169289
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ddehaven/8169289/jdk.0/
>>>
>>>
>>
>> Would it b
Hi.
Your change looks fine to me.
Thanks,
iris
-Original Message-
From: Aleks Efimov
Sent: Tuesday, November 15, 2016 1:48 PM
To: core-libs-dev
Subject: [9] RFR(S): 8160999: GPL header missing comma in year
Hi,
jaxws/src/java.xml.bind/share/classes/com/sun/xml/internal/bind/v2/uti
+1
Mandy
> On Nov 15, 2016, at 1:48 PM, Aleks Efimov wrote:
>
> Hi,
>
> jaxws/src/java.xml.bind/share/classes/com/sun/xml/internal/bind/v2/util/XmlFactory.java
> file contains incorrect GPL header which fails make/scripts/lic_check.sh
> script check.
>
> Failure is caused by missing comma a
Hi,
jaxws/src/java.xml.bind/share/classes/com/sun/xml/internal/bind/v2/util/XmlFactory.java
file contains incorrect GPL header which fails make/scripts/lic_check.sh
script check.
Failure is caused by missing comma after modification years. Please,
help to review its addition:
diff -r 26c
Hi Brunoais,
Java is not and will never be only what comes with the OpenJDK,
it's a big (really big) community full of libraries for whatever you wish and
even sometimes what you don't wish.
So beside readline, you can also take a look at Jansi
https://github.com/fusesource/jansi
it's the packa
+1
> On Nov 15, 2016, at 4:26 PM, joe darcy wrote:
>
> Hello,
>
> The test
>
> javax/rmi/PortableRemoteObject/8146975/RmiIiopReturnValueTest.java
>
> has been seen in intermittently fail in various test systems and should be
> marked accordingly.
>
> Please review the patch below to do this.
Hello,
The test
javax/rmi/PortableRemoteObject/8146975/RmiIiopReturnValueTest.java
has been seen in intermittently fail in various test systems and should
be marked accordingly.
Please review the patch below to do this.
Thanks,
-Joe
diff -r 99b7853cfbd8
test/javax/rmi/PortableRemoteObjec
>> Please review the (fairly straightforward) JDK changes needed to support
>> launching JavaFX applications in a named module.
>>
>> JBS:
>> https://bugs.openjdk.java.net/browse/JDK-8169289
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ddehaven/8169289/jdk.0/
>>
>>
>
> Would it be better to
Hi,
What are your thoughts on adding these default convenience methods to the
java.lang.Comparable interface?
public interface Comparable {
int compareTo(T o);
default boolean isGreaterThan(T o) {
return compareTo(o) > 0;
}
default boolean isGreaterThanOrEqualTo(T o) {
return compareTo(o
> On Nov 10, 2016, at 9:38 AM, David DeHaven wrote:
>
>
> Please review the (fairly straightforward) JDK changes needed to support
> launching JavaFX applications in a named module.
>
> JBS:
> https://bugs.openjdk.java.net/browse/JDK-8169289
>
> Webrev:
> http://cr.openjdk.java.net/~ddehaven
Hi Brunoais,
Largely, because most people don't interact with java from a terminal
and the simple stream
oriented access has been sufficient. Take a look for layered libraries
that can handle
fancier terminals that have color and various positioning (ANSI) escape
sequences
that might meet yo
I also noticed now that this does not allow placing the cursor in
arbitrary places.
With the same restrictions as jline, I could use javacurses.
https://sourceforge.net/projects/javacurses/
Unfortunately, it also requires using extra native libraries to work
because java does not include such
jLine requires a .dll on windows making it not OS agnostic. If this
existed in java itself, this problem would not be a problem because java
internal dll are signed by java and can be included without issues.
But then, why doesn't java have this?
On 15/11/2016 15:12, Roger Riggs wrote:
Hi,
http://cr.openjdk.java.net/~jlaskey/8169505/webrev/index.html
https://bugs.openjdk.java.net/browse/JDK-8169505
Ping? Kumar?
-DrD-
> On Nov 10, 2016, at 9:38 AM, David DeHaven wrote:
>
>
> Please review the (fairly straightforward) JDK changes needed to support
> launching JavaFX applications in a named module.
>
> JBS:
> https://bugs.openjdk.java.net/browse/JDK-8169289
>
> Webrev:
> http://cr.openj
Looks fine.
Roger
On 11/15/2016 11:31 AM, Daniel Fuchs wrote:
Hi,
Please find below a trivial patch for
JBS: https://bugs.openjdk.java.net/browse/JDK-8169723
webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8169723/webrev.00/
The org.w3c.dom.xpath package is now exported by the jdk.xml.dom
Hi,
Please find below a trivial patch for
JBS: https://bugs.openjdk.java.net/browse/JDK-8169723
webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8169723/webrev.00/
The org.w3c.dom.xpath package is now exported by the jdk.xml.dom package.
Somehow this copyright file was copied instead of being
> On 14 Nov 2016, at 17:56, Paul Sandoz wrote:
>
> Hi,
>
> Please review this patch implementing a spliterator for BitSet:
>
>
> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8072784-bitset-stream-spliterator/webrev/
>
> The spliterator is SIZED but not SUBSIZED, the bit set’s cardinality is
On 11/15/2016 01:41 PM, Zoltán Majó wrote:
Here is the updated webrev:
http://cr.openjdk.java.net/~zmajo/8169000/webrev.02/
+1
Regards, Peter
+1
Really nice, thank you.
> On Nov 15, 2016, at 11:16 AM, Denis Kononenko
> wrote:
>
>
> Hi,
>
> Please do re-review for these changes.
>
> 1) tests for list --include were rewritten accordingly to
> https://bugs.openjdk.java.net/browse/JDK-8167384;
> 2) removed tests for '@filename', see
Hi,
You might find an open source package like JLine would have the full
featured terminal support you are looking for.
http://jline.sourceforge.net/
Roger
On 11/13/2016 5:35 AM, Brunoais wrote:
Since java 6, a class named Console was created. This class allows
reading and writing directl
Hi,
Please do re-review for these changes.
1) tests for list --include were rewritten accordingly to
https://bugs.openjdk.java.net/browse/JDK-8167384;
2) removed tests for '@filename', see
https://bugs.openjdk.java.net/browse/JDK-8169720;
3) two new CRs were submitted:
https://bugs.openjdk.ja
Hi Team,
Please review a small fix for tests.
BugID: https://bugs.openjdk.java.net/browse/JDK-8169721
Web review: http://cr.openjdk.java.net/~skovalev/8169721/webrev.00/
Issue: most tests has missed dependency om java.naming module.
Solution: add missed module declaration for tests. If this pos
Hi Mandy,
thank you for looking at this! Please find more details below.
On 11/15/2016 02:51 AM, Mandy Chung wrote:
On Nov 14, 2016, at 6:28 AM, Zoltán Majó wrote:
Here is the updated webrev with the updated text:
http://cr.openjdk.java.net/~zmajo/8169000/webrev.01/
This spec uses “unreac
Hi David,
On 11/14/2016 11:52 PM, David Holmes wrote:
[...]
I don't think you need the "(i.e ...)". You are cross referencing to
the Reachability section where "strongly reachable" is defined.
I see. OK, I've removed the "i.e.,".
The fewer the changes the better - the key part is to make
Hi Peter,
On 11/14/2016 10:59 PM, Peter Levart wrote:
Hi Zoltan,
On 11/14/2016 03:28 PM, Zoltán Majó wrote:
[...]
thank you for the suggestion and for the example program!
Here is the updated webrev with the updated text:
http://cr.openjdk.java.net/~zmajo/8169000/webrev.01/
Does that look
31 matches
Mail list logo
