Re: RFR 8163798: Add a versionedStream method to JarFile

Hi Steve, in the line 597 Map> versionsMap = stream() I miss space after the comma. In the line 626 return finalNames.stream().map(nm -> getJarEntry(nm)); You can use a method reference instead of lambda: 626 return finalNames.stream().map(this::getJarEntry); And if

Re: RFR 8163798: Add a versionedStream method to JarFile

Hello! Small nitpick: versionsMap.keySet().forEach(v -> { Stream names = versionsMap.get(v).stream().map(nm -> nm.name); if (v == versionMajor) { // add all entries of the version we are interested in finalNames.addAll(names.collect(Collectors.toSet())); } else {

Re: RFR (S): JDK-8164086: Checked JNI pending exception check should be cleared when returning to Java frame

Hi David, I'm missing some pieces of this puzzle I'm afraid. On 25/08/2016 8:05 PM, David Simms wrote: Updated the webrev here: http://cr.openjdk.java.net/~dsimms/8164086/webrev1/ hotspot/src/share/vm/prims/whitebox.cpp First I'm not sure that Whitebox isn't a special case here that could b

RFR 8163798: Add a versionedStream method to JarFile

Hi, Please review this changeset that adds a versionedStream method to JarFile. webrev: http://cr.openjdk.java.net/~sdrach/8163798/webrev.00/ issue: https://bugs.openjdk.java.net/browse/JDK-8163798

RFR 8164814: Deprecate Atomic*.weakCompareAndSet and defer to Atomic*.weakCompareAndSetPlain

Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8164814--atomics-weakCompareAndSet-deprecate/webrev/ This patch deprecates weakCompareAndSet and adds a new method weakCompare

Re: RFR: 8164739: Remove computation of predefined interpreter forms

CDE (Code Deletion Engineering) at its finest! On Aug 25, 2016, at 4:38 AM, Claes Redestad wrote: > On 2016-08-25 12:30, Vladimir Ivanov wrote: >> Looks good. > > Thanks! Pushed. > > /Claes > >> >> Best regards, >> Vladimir Ivanov

RFR (JAXB): 8159240: XSOM parser incorrectly processes type names with whitespaces

Hello, Please, help to review the JDK9 changes in JAXB XSOM parser that solves issue [0] with incorrectly collapsed namespaces within schema types names definitions/usages: http://cr.openjdk.java.net/~aefimov/8159240/9/00/ Problem description: The XMLSchema defines that whitespaces should be c

Re: RFR: 8164739: Remove computation of predefined interpreter forms

On 2016-08-25 12:30, Vladimir Ivanov wrote: Looks good. Thanks! Pushed. /Claes Best regards, Vladimir Ivanov On 8/24/16 7:48 PM, Claes Redestad wrote: Hi, LambdaForm predefines a number of forms for the benefit of the LF and NF interpreters, which doesn't appear useful at all at this po

Re: RFR: 8164739: Remove computation of predefined interpreter forms

Looks good. Best regards, Vladimir Ivanov On 8/24/16 7:48 PM, Claes Redestad wrote: Hi, LambdaForm predefines a number of forms for the benefit of the LF and NF interpreters, which doesn't appear useful at all at this point. JIRA: https://bugs.openjdk.java.net/browse/JDK-8164739 Webrev: http:

Re: RFR (S): JDK-8164086: Checked JNI pending exception check should be cleared when returning to Java frame

Updated the webrev here: http://cr.openjdk.java.net/~dsimms/8164086/webrev1/ core-libs & Kumar: java launcher: are you okay with the CHECK_EXCEPTION_PRINT macro, or would you rather it was silent (i.e. CHECK_EXCEPTION_RETURN) ? In-line... On 23/08/16 14:16, David Holmes wrote: Hi David O