Re: RFR(XXS): 8140514: [TESTBUG] enable sun/security/pkcs11 tests on Linux/ppc64

2015-10-29 Thread Bradford Wetmore
Most of us have been at JavaOne this week. Looks ok to me. Brad On 10/27/2015 11:02 AM, Volker Simonis wrote: Resend to core-libs-dev to attract a broader audience :) On Mon, Oct 26, 2015 at 3:32 PM, Volker Simonis wrote: Hi, can somebody please review the following trivial fix to enabl

Re: RFR (JAXP) : 8081248: Implement JEP 268: XML Catalog API

2015-10-29 Thread Lance Andersen
Hi Joe, The current spediff, webrev seems OK to me. Thank you for your diligence on this Best Lance On Oct 15, 2015, at 3:52 AM, huizhe wang wrote: > Hi all, > > Please help review JEP 268 implementation: > https://bugs.openjdk.java.net/browse/JDK-8081248 > > Catalog specification: > https:

Re: RFR [9] 8140606: Update library code to use internal Unsafe

2015-10-29 Thread Martin Buchholz
Here's the plan: - There will be an upcoming "round two" of jsr166 integration, focusing on jtreg tests. - We already need to massage jsr166 sources for integration, and adjusting sun.misc.Unsafe to the new blessed name is relatively trivial. - (There will be confusion and resistance to locking dow

Re: RFR(S): 8131129: Attempt to define a duplicate BMH$Species class

2015-10-29 Thread Michael Haupt
Hi Vladimir, Peter, once more, thanks for all your comments. The revised webrev is at http://cr.openjdk.java.net/~mhaupt/8131129/webrev.01/. Best, Michael > Am 28.10.2015 um 17:37 schrieb Vladimir Ivanov : > > Peter, > >> Hi Vladimir, I think you are right. The proposed fix alone even >> inc

Re: RFR [9] 8140606: Update library code to use internal Unsafe

2015-10-29 Thread Alan Bateman
On 29/10/2015 14:12, Chris Hegarty wrote: : Yes, good point. I updated just the corba webrev. http://cr.openjdk.java.net/~chegar/8140606/01/corba/ I’ll be tackling ManageLocalsThread separately in the near future so have done just the minimum in corba for now. This looks good to me. -Al

Re: RFR [9] 8140606: Update library code to use internal Unsafe

2015-10-29 Thread Chris Hegarty
On 28 Oct 2015, at 21:42, Martin Buchholz wrote: > This will cause jsr166 CVS code to no longer be able to run on jdk8, as it > does today. We will probably need to fork soon anyways due to Paul's > VarHandle code, but we had not expected it to be necessary before then. Is > there any easy

Re: CharSequence.subSequence optimizations

2015-10-29 Thread Aleksey Shipilev
On 10/29/2015 01:36 PM, Pavel Rappo wrote: >> On 29 Oct 2015, at 00:48, Aleksey Shipilev >> wrote: >> Doesn't that break when CharSequence implementation is mutable? >> E.g. with StringBuilder, you cannot return "this" when "end == >> StringBuilder.length()" at the time of .subSequence() call. >

Re: [RFR] (S) 8140189: [TESTBUG] Get rid of "@library /../../test/lib" in jtreg tests

2015-10-29 Thread Staffan Larsen
Looks good (still)! Thanks, /Staffan > On 28 okt. 2015, at 06:42, Chris Plummer wrote: > > Hello, > > I've fixed the new jvmci tests. New webrevs found here: > > http://cr.openjdk.java.net/~cjplummer/8140189/webrev.01/webrev.hotspot > http://cr.openjdk.java.net/~cjplummer/8140189/webrev.01/web

Re: RFR [9] 8140606: Update library code to use internal Unsafe

2015-10-29 Thread Chris Hegarty
On 28 Oct 2015, at 22:14, Alan Bateman wrote: > On 28/10/2015 19:55, Chris Hegarty wrote: >> Following on from 8139891 "Prepare Unsafe for true encapsulation” [1], >> the JDK library code should use the internal Unsafe class, and not >> sun.misc.Unsafe. >> >> http://cr.openjdk.java.net/~chegar/

Re: CharSequence.subSequence optimizations

2015-10-29 Thread Pavel Rappo
> On 29 Oct 2015, at 00:48, Aleksey Shipilev > wrote: > > Doesn't that break when CharSequence implementation is mutable? > E.g. with StringBuilder, you cannot return "this" when "end == > StringBuilder.length()" at the time of .subSequence() call. True. This trick cannot be used in cases wher

RFR(XS): 8139863: [TESTBUG] Need to port tests for JDK-8134903 to 8u-dev

2015-10-29 Thread Michael Haupt
Dear all, cross-posted to jdk8u-dev and core-libs-dev. Please review this change. Issue: https://bugs.openjdk.java.net/browse/JDK-8139863 Webrev: http://cr.openjdk.java.net/~mhaupt/8139863/webrev.00 This adds a missing test to 8u-dev that was not pushed along with the feature backport it belong

Re: [concurrency-interest] Spin Loop Hint support: Draft JEP proposal

2015-10-29 Thread Gil Tene
[Sorry for the 4 day delay in response. JavaOne sort of got in the way] I think we are looking at two separate and almost opposite motivations, each of which is potentially independently valid. Each can be characterized by answering the question: "How does adding this to an empty while(!ready) {