Low hanging fruit in JBS for the Adoption Group Hackdays to tackle?

2015-03-28 Thread Martijn Verburg
Hi all, We had a short discussion in Adoption Group about having its members triaging issues in JBS to identify low-hanging fruit for new OpenJDK developers to tackle. Dalibor sensibly suggested that each project/group was far more familiar with which issues would be appropriate and that we shoul

Re: RFR 8073056: Repeating annotations throws java.security.AccessControlException with a SecurityManager

2015-03-28 Thread Joel Borggrén-Franck
> On 28 Mar 2015, at 13:42, Peter Levart wrote: > On 03/28/2015 11:24 AM, Joel Borggrén-Franck wrote: >> Hi, >> >> >>> On 27 Feb 2015, at 11:06, Peter Levart >>> wrote: >>> On 02/27/2015 10:27 AM, Joel Borggrén-Franck wrote: >>> > On 26 feb 2015, at 22:35, Peter Levart > > wro

Re: [9] RFR 8074840: Resolve disabled warnings for libjli and libjli_static

2015-03-28 Thread Kumar Srinivasan
Hi Mikael, Thank you so much for making these changes!. Looks generally good. ergo_i586.c: why ? MacOSX ? cmdtoargs.c: URK!. :-[ Thanks Kumar On 3/20/2015 11:02 AM, Mikael Vidstedt wrote: Please review the following change which fixes a number of native compilation warnings in files relat

Re: RFR 8073056: Repeating annotations throws java.security.AccessControlException with a SecurityManager

2015-03-28 Thread Peter Levart
On 03/28/2015 11:24 AM, Joel Borggrén-Franck wrote: Hi, On 27 Feb 2015, at 11:06, Peter Levart wrote: On 02/27/2015 10:27 AM, Joel Borggrén-Franck wrote: On 26 feb 2015, at 22:35, Peter Levart wrote: On 02/26/2015 10:27 PM, Peter Levart wrote: The m.setAccessible(true) for the methods

Re: RFR 8073056: Repeating annotations throws java.security.AccessControlException with a SecurityManager

2015-03-28 Thread Joel Borggrén-Franck
Hi, > On 27 Feb 2015, at 11:06, Peter Levart wrote: > On 02/27/2015 10:27 AM, Joel Borggrén-Franck wrote: >>> On 26 feb 2015, at 22:35, Peter Levart >>> wrote: >>> On 02/26/2015 10:27 PM, Peter Levart wrote: >>> The m.setAccessible(true) for the methods is needed to access methods of >>>

Re: RFR: 8071571: Move substring of same string to slow path

2015-03-28 Thread Remi Forax
On 03/27/2015 10:59 PM, Martin Buchholz wrote: [...] OTOH, if you touch code that uses the denigrated char foo[] please change it to char[] foo This is yet another of those global changes to the entire jdk sources that nobody ever gets around to. on the same subject, the Java grammar all

Re: RFR: 8071571: Move substring of same string to slow path

2015-03-28 Thread Remi Forax
On 03/27/2015 11:01 PM, Martin Buchholz wrote: On Fri, Mar 27, 2015 at 2:57 PM, Roger Riggs wrote: Hi, @Martin: does the final have some functional reason to be present? I see it just bulks up the source, reducing readability. If it is useful to improve performance then fine. If you use t