Looks good. Not surprising no one ever noticed, since the code is
intentionally trying to reduce the number of buckets. I would encapsulate
serialization mechanics in a separate serialClone method, as done elsewhere
e.g.
@SuppressWarnings("unchecked")
private static T serialClone(T o)
On 3/01/2015 9:24 PM, Peter Firmstone wrote:
Thanks Brian,
Those are good questions, some thoughts and examples inline:
- Original message -
Overall the direction seems promising. Poking at it a bit...
- ReadSerial methods are caller-sensitive and only show a class a view
of i
On 1/4/15 12:25 PM, Alan Bateman wrote:
On 04/01/2015 19:18, Xueming Shen wrote:
:
I agree with Alan that the general interface "Appendable" probably
should not get
into the specific "formatting" functionality here. And I also think
the "line.separator"
should not be in the "Writer" as well,
For the record I would be very happy to update the implementation to use
System.lineSeparator() in PrintWriter/BufferedWriter rather than reading
line.separator, thus removing the unspecified behavior to be able to
hack the
current implementation via manipulating system properties. This might br
On 04/01/2015 19:18, Xueming Shen wrote:
:
I agree with Alan that the general interface "Appendable" probably
should not get
into the specific "formatting" functionality here. And I also think
the "line.separator"
should not be in the "Writer" as well, writer/reader does not deal
with "format
On 04.01.2015 22:50, Alan Bateman wrote:
On 03/01/2015 17:39, Ivan Gerasimov wrote:
Currently, there are tree variants of ClassLoaderHelper: for Windows,
for Unix and for MacOS.
We have to either duplicate code in Unix and MacOS realizations, or
introduce another Helper class for initializin
Hi Peter!
There were other cases where one wanted to consolidate duplicated
code, but couldn't easily because of subtle differences among OS
platforms (UNIXProcess is one of such cases). Perhaps we need
something like this:
http://cr.openjdk.java.net/~plevart/misc/OS/webrev/
With this compi
On 03/01/2015 17:39, Ivan Gerasimov wrote:
Currently, there are tree variants of ClassLoaderHelper: for Windows,
for Unix and for MacOS.
We have to either duplicate code in Unix and MacOS realizations, or
introduce another Helper class for initializing paths only, which
would have only two re
I'm very concerned every time when I see someone tries to achieve
something by
manipulating the system property, given the lesson we have learned from
the past,
(property file.encoding, for example). In that particular stackoverflow
sample, I
would assume the better suggestion is to override t
Hi,
While investigating the following issue:
https://bugs.openjdk.java.net/browse/JDK-8029891
I noticed there's a bug in deserialization code of java.util.Hashtable
(from day one probably):
https://bugs.openjdk.java.net/browse/JDK-8068427
The fix is a trivial one-character replaceme
Hi Brad,
So I created another webrev (just removed the unneeded import and
left-over System.out.println from test):
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.06/
I'll leave it here to rest for a couple of days and if no one objects,
I'll push it to jdk9-
On 2015-01-04 11:06, Alan Bateman wrote:
On 02/01/2015 15:38, Claes Redestad wrote:
Hi,
this is a proposal to resolve concerns that
PrintWriter/BufferedWriter behave
inconsistently with j.u.Formatter when setting the line.separator
property to override
system-appropriate line breaks.
Ins
- Original message -
>
> On 01/04/2015 02:48 AM, Peter Firmstone wrote:
> > class B extends A {
> >
> > public final int cur;
> >
> > private static ReadSerial check(ReadSerial rs) {
> > A a = new A(rs);
>
> What to do if A is abstract?
:)
Create an anonymous instance, or create a sta
On 01/03/2015 06:39 PM, Ivan Gerasimov wrote:
On 03.01.2015 11:50, Alan Bateman wrote:
On 26/12/2014 10:02, Ivan Gerasimov wrote:
Hi!
I changed my mind about handling only entirely quoted entries in PATH.
The webrev was updated.
Now, on Windows paths with quoted parts are supported.
If the
On 01/04/2015 02:48 AM, Peter Firmstone wrote:
class B extends A {
public final int cur;
private static ReadSerial check(ReadSerial rs) {
A a = new A(rs);
What to do if A is abstract?
Regards, Peter
int cur = rs.getInt("cur");
if ( a.lower> cur || cur> a.upper )
On 02/01/2015 15:38, Claes Redestad wrote:
Hi,
this is a proposal to resolve concerns that
PrintWriter/BufferedWriter behave
inconsistently with j.u.Formatter when setting the line.separator
property to override
system-appropriate line breaks.
Instead of providing a set of new constructors
16 matches
Mail list logo
