Re: Explicit Serialization API and Security

2015-01-03 Thread Peter Firmstone
On 4/01/2015 9:55 AM, Peter Levart wrote: - Original message - > > As Brian points out, this scheme can only validate intra-class > invariants. It can't validate class-against-subclass state. Sorry, I meant it can't validate class -against-superclass state. Did he say that? Not dir

Re: Explicit Serialization API and Security

2015-01-03 Thread Peter Levart
On 01/03/2015 09:29 PM, Peter Firmstone wrote: - Original message - > > As Brian points out, this scheme can only validate intra-class > invariants. It can't validate class-against-subclass state. Sorry, I meant it can't validate class -against-superclass state. Did he say that? N

Re: Explicit Serialization API and Security

2015-01-03 Thread Peter Firmstone
P.S. Thanks for engaging this difficult subject. It's worth remembering the finalizer attack isn't the only issue, a subclass will have a reference after construction completes, it has a thread of execution and if the superclass hasn't checked invarients, because circular links haven't been wir

Re: Explicit Serialization API and Security

2015-01-03 Thread Peter Firmstone
- Original message - > > As Brian points out, this scheme can only validate intra-class > invariants. It can't validate class-against-subclass state. Did he say that? It's true that a superclass can't validate subclass state, it can't be expected to know much about it, but it can validat

Re: Explicit Serialization API and Security

2015-01-03 Thread Chris Hegarty
Just a quick comment about the finalization aspect ( as I have been thinking about this too ). On 3 Jan 2015, at 15:36, Peter Levart wrote: > On 01/03/2015 01:38 PM, Peter Firmstone wrote: >> >> > Hi, >> > >> > I would like to know what are the potential issues with simple >> > constructor chai

Re: RFR: 8067951: System.loadLibrary cannot find library when path contains quoted entry

2015-01-03 Thread Ivan Gerasimov
On 03.01.2015 11:50, Alan Bateman wrote: On 26/12/2014 10:02, Ivan Gerasimov wrote: Hi! I changed my mind about handling only entirely quoted entries in PATH. The webrev was updated. Now, on Windows paths with quoted parts are supported. If the quoted fragment of the path contains the delimit

Re: Explicit Serialization API and Security

2015-01-03 Thread Peter Levart
On 01/03/2015 01:38 PM, Peter Firmstone wrote: > Hi, > > I would like to know what are the potential issues with simple > constructor chaining where each constructor checks the invariant of its > class state (with the already initialized state of superclass(es)). Finalizer attack; a subclass c

Re: Explicit Serialization API and Security

2015-01-03 Thread Peter Firmstone
> Hi, > > I would like to know what are the potential issues with simple > constructor chaining where each constructor checks the invariant of its > class state (with the already initialized state of superclass(es)). Finalizer attack; a subclass can override the finalize method and receive a t

Re: Explicit Serialization API and Security

2015-01-03 Thread Peter Firmstone
Thanks Brian, Those are good questions, some thoughts and examples inline: - Original message - > Overall the direction seems promising.  Poking at it a bit... > >    - ReadSerial methods are caller-sensitive and only show a class a view > of its own fields. >    - Invariant checking i

Re: Explicit Serialization API and Security

2015-01-03 Thread Peter Levart
On 01/02/2015 11:53 PM, Brian Goetz wrote: Overall the direction seems promising. Poking at it a bit... - ReadSerial methods are caller-sensitive and only show a class a view of its own fields. - Invariant checking is separate from deserialization, and does not seem entirely built-in -- su

Re: RFR: 8067951: System.loadLibrary cannot find library when path contains quoted entry

2015-01-03 Thread Alan Bateman
On 26/12/2014 10:02, Ivan Gerasimov wrote: Hi! I changed my mind about handling only entirely quoted entries in PATH. The webrev was updated. Now, on Windows paths with quoted parts are supported. If the quoted fragment of the path contains the delimiter -- ';', it will be preserved as a part