Hi Brad,
On 01/01/2015 02:46 AM, Bradford Wetmore wrote:
To the actual proposal:
http://cr.openjdk.java.net/~plevart/jdk9-dev/SystemRandom/webrev.03/
Overall, I'm ok with what's proposed. This is more straightforward to
parse/understand than trying to adjust NativeSeedGenerator to
create/ca
On 01/01/2015 08:56 PM, Chris Hegarty wrote:
This looks very nice Peter.
Just a small comment on the test; it may avoid future problems if the
test use deleteFileWithRetry, from the test library [1], rather than
file.delete().
-Chris.
[1]
http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/
Hi Brad,
Here's next webrev which tries to cover all your comments:
http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.04/
Answers inline...
On 12/30/2014 02:48 AM, Bradford Wetmore wrote:
I'm looking at this version of the webrev.
http://cr.openjdk.java.net/~ple
This looks very nice Peter.
Just a small comment on the test; it may avoid future problems if the test use
deleteFileWithRetry, from the test library [1], rather than file.delete().
-Chris.
[1]
http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/test/lib/testlibrary/jdk/testlibrary/FileUtils.jav
On 12/29/2014 04:51 PM, Alan Bateman wrote:
On 29/12/2014 09:45, Peter Levart wrote:
Thanks for looking at this, Alan.
You're right about File.getCanonicalFile(). It already checks read
permission for a file. The additional explicit check is superfluous.
I have removed it.
With explicit c
Subclass example:
class SubFoo extends BaseFoo {
public static ReadSerial check(ReadSerial rs){
if (rs.getInt("y") > 128) throw Exception("too big");
return rs;
}
private final int y;
public SubFoo( int x , int y) {
super(x);
this.y = y;
}
