Re: RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

I'm looking at this version of the webrev. http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.03/ I just assigned 8047769 to you. My username is wetmore, Alan is alanb. On 12/24/2014 3:37 AM, Peter Levart wrote: Looks like you have a committer status, will you

JDK 9 RFR of 4026465: Provide more byte array constructors for BigInteger

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-4026465 Patch: http://cr.openjdk.java.net/~bpb/4026465/webrev.00/ Should this issue not look to be worth addressing after all, then I propose that it should be resolved as “Won’t Fix” rather than be left danglin

Re: RFR 8066085: Need a sanity test for rmic -iiop

Hi Felix, Thanks for the updates. I've pushed the changeset. [1] Sorry for the delay; holidays, you know. s'marks [1] http://hg.openjdk.java.net/jdk9/dev/jdk/rev/af229cf4a61a On 12/24/14 7:27 AM, FELIX YANG wrote: Hi Stuart, this is the updated webrev: http://cr.openjdk.java.net/~xiao

RFR: 8068347: Add java/lang/ClassLoader/deadlock/GetResource.java to ProblemList.txt

Hi, The java/lang/ClassLoader/deadlock/GetResource.java test has started causing problems for Hotspot nightly testing. A "real" fix is being worked on under [1], but in the meantime, this test should be added to the ProblemList. Bug: https://bugs.openjdk.java.net/browse/JDK-8068347 The di

Re: Explicit Serialization API and Security

So, if I understand this correctly, the way this would get used is: class BaseFoo implements Serializable { private final int x; public BaseFoo(ReadSerial rs) { this(rs.getInt("x")); } public BaseFoo(int x) { this.x = x; } } Right? What happens with subclas

Re: JDK 9 RFR of 8064463: BigDecimal should populate NumberFormatException message

On Dec 29, 2014, at 12:46 AM, Alan Bateman wrote: >> Patch: http://cr.openjdk.java.net/~bpb/8064463/webrev.00/ >> >> […] >> >> > This looks okay to me. A minor inconsistency is that one of the "Exponent > overflow " cases has a trailing dot, the other doesn't. Thanks. I’ll add a dot a

Re: RFR: 8068338: Better message about incompatible zlib in Deflater.init

On 29/12/2014 11:40, Ivan Gerasimov wrote: Hello! It it proposed to enhance the error message in the manner it was done in JDK-8008759. Would you please help review this simple change? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8068338 WEBREV: http://cr.openjdk.java.net/~igerasim/80683

Re: RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

On 29/12/2014 09:45, Peter Levart wrote: Thanks for looking at this, Alan. You're right about File.getCanonicalFile(). It already checks read permission for a file. The additional explicit check is superfluous. I have removed it. With explicit check I wanted the API to behave uniformly rega

RFR: 8068338: Better message about incompatible zlib in Deflater.init

Hello! It it proposed to enhance the error message in the manner it was done in JDK-8008759. Would you please help review this simple change? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8068338 WEBREV: http://cr.openjdk.java.net/~igerasim/8068338/0/webrev/ Sincerely yours, Ivan

Re: RFR: 8068230: java.util.zip.Deflater.init throws InternalError

Thanks Sherman and Alan for the reference to JDK-8008759! It does seem to be the root cause of this issue also. I've just requested an approval to backport that fix into jdk 7u. To improve the error message of Deflater.init, I've created another issue: JDK-8068338. Sincerely yours, Ivan On 2

Re: RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

On 12/29/2014 10:08 AM, Alan Bateman wrote: On 24/12/2014 11:37, Peter Levart wrote: Hi Brad, Thanks for looking into this. Here's updated webrev: http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.02/ This mostly looks good to me too, except the permission che

Re: RFR: 8067889: 4 pack200 tests fail on mac since jdk became modular

On 26/12/2014 17:42, Kumar Srinivasan wrote: New webrev uploaded with comment suggested by Amy Lu. The revised patch is here: http://cr.openjdk.java.net/~ksrini/8067889/webrev.1/webrev.delta/index.html The full patch: http://cr.openjdk.java.net/~ksrini/8067889/webrev.1 Updated patch looks

Re: RFR: 8066834: tools/pack200/CommandLineTests.java does not conform ProblemList.txt style

On 24/12/2014 18:56, Kumar Srinivasan wrote: Hello, Please review this simple fix, enclosed. Thanks in advance. Kumar diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++ b/test/ProblemList.txt @@ -267,7 +267,7 @@ # Tests take too long, on sparcs see 714327

Re: RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

On 24/12/2014 11:37, Peter Levart wrote: Hi Brad, Thanks for looking into this. Here's updated webrev: http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.02/ This mostly looks good to me too, except the permission checking. As I read it, getInputStream uses get

Re: JDK 9 RFR of 8064463: BigDecimal should populate NumberFormatException message

On 22/12/2014 21:13, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8064463 Patch: http://cr.openjdk.java.net/~bpb/8064463/webrev.00/ Summary: Ensure that the message strings of all NumberFormatExceptions are populated with appropr