Style nit: all the
int cache[]
should be
int[] cache
Also not clear if 8061651-lookup-index-open-v2 is latest webrev ??
Thanks,
David
On 25/10/2014 9:38 AM, Ioi Lam wrote:
Hi Mandy,
Thanks for the review. please see comments in-line
On 10/24/14, 2:33 PM, Mandy Chung wrote:
On 10/23/2014
>
> 55 java/lang/reflect jtreg tests still pass. As they did before, which
> means that we don't have a coverage for such cases. I'll see where I can
> add such a case (EnumSet for example, which inherits from Set interface and
> AbstractColection class via two different paths, so Set.size()/iterat
On 10/26/2014 09:25 PM, Peter Levart wrote:
19657 classes loaded in 1.987373401 seconds.
494141 methods obtained in 1.02493941 seconds.
vs.
19657 classes loaded in 2.084409717 seconds.
494124 methods obtained in 0.915928578 seconds.
Hi,
As you might have noticed, the number of methods obtai
On Mon, Oct 27, 2014 at 12:36 AM, Peter Levart
wrote:
>
> On 10/26/2014 11:21 PM, Stanimir Simeonoff wrote:
>
> Great effort.
>
> From first glance: the hashCode and equals of MethodList use
> m.getParameterTypes() which is cloned. I'd rather pay the collision costs
> and rely on the default has
On 10/26/2014 11:21 PM, Stanimir Simeonoff wrote:
Great effort.
From first glance: the hashCode and equals of MethodList use
m.getParameterTypes() which is cloned. I'd rather pay the collision
costs and rely on the default hashCode/equals of Method itself
(hashCode ignores the parameters). P
Great effort.
>From first glance: the hashCode and equals of MethodList use
m.getParameterTypes() which is cloned. I'd rather pay the collision costs
and rely on the default hashCode/equals of Method itself (hashCode ignores
the parameters). Possibly hashCode can include the returnType but equals
Hi Alan,
I think this looks better but I have a few comments on the API.
>
Thanks for taking the time to look at this - most appreciated. I've pushed
the latest iteration to
http://cr.openjdk.java.net/~rwarburton/string-patch-webrev-8/.
For String(ByteBuffer, Charset) then it's still inconsisten
Hi all,
I revamped the Class.getMethods() implementation so that it is faster
for common cases and O(n) at the same time, which makes Martin's test
happy (at least in part that measures getMethods() speed - the class
loading / linkage in VM is a separate issue).
With the following test that
