On 2014-10-11 02:31, Mandy Chung wrote:
On 10/10/2014 8:10 AM, Claes Redestad wrote:
Hi all,
please review this patch which attempts to clean up synchronization
and improve scalability when
defining and getting java.lang.Package objects.
I agree with David that getting Package objects are
Chris wrote:
>Webrev:
>http://cr.openjdk.java.net/~chegar/8060052/webrev.00/webrev/
An aside remark:
Every time some nanos timeout needs to be kept track of, and that
remaining time does not need to be returned, one could consider
the timeout to be infinite (timed = false) above, say, Long.M
On 10/11/2014 09:40 AM, John Rose wrote:
On Oct 10, 2014, at 2:20 PM, Remi Forax wrote:
I have another question about inOptimizer(),
thinkint a little about it, if there is a code like
if (unsafe.inOptimizer()) {
...
}
this code will always trigger a recompilation, at least once,
On 10/11/2014 8:17 AM, Remi Forax wrote:
Hi Mandy,
On 10/11/2014 02:31 AM, Mandy Chung wrote:
[...]
webrev: http://cr.openjdk.java.net/~redestad/8060130/webrev.02/
ClassLoader.java
line 272: can you change the declared type as Map.
I think it's a bad idea, the class doesn't work if yo
The commented annotation in ClassLoader.java must be removed (line 268)
// @GuardedBy("itself")
Stanimir
On Fri, Oct 10, 2014 at 6:10 PM, Claes Redestad
wrote:
> Hi all,
>
> please review this patch which attempts to clean up synchronization and
> improve scalability when
> defining and gettin
Hi Mandy,
On 10/11/2014 02:31 AM, Mandy Chung wrote:
[...]
webrev: http://cr.openjdk.java.net/~redestad/8060130/webrev.02/
ClassLoader.java
line 272: can you change the declared type as Map.
I think it's a bad idea, the class doesn't work if you replace the
ConcurrentHashMap by any Map
Thanks for the review Martin.
Since this change may be backported to 8u, then I’ll keep the test, as the
JCK8(a) may not contain the new TCK test from the 166 CVS.
-Chris.
On 10 Oct 2014, at 18:40, Martin Buchholz wrote:
> Thanks and approved!
>
> Seems suitable for a backport to 8u if you w
On 09/10/2014 06:50, Amy Lu wrote:
Updated name "lib" to "testdir":
http://cr.openjdk.java.net/~weijun/8058855/webrev.01/
Thanks for taking this one, the updated version looks good to me too.
-Alan
On Oct 10, 2014, at 2:20 PM, Remi Forax wrote:
> I have another question about inOptimizer(),
> thinkint a little about it, if there is a code like
> if (unsafe.inOptimizer()) {
> ...
> }
>
> this code will always trigger a recompilation, at least once, because in the
> interpreter, the
