Hi Otávio
I see TABs in the first page of sun_security.diff, too long line in
javax_security.diff.
Also, it's unfortunate that you will need to rename the file names to the new
style with modules. See
http://cr.openjdk.java.net/~chegar/docs/portingScript.html for how to do this.
I can create
Sergey,
JSR 305 is officially marked "dormant" in the JCP:
https://www.jcp.org/en/jsr/detail?id=305
At this point, the addition of annotations in that vein should probably
occur under the banner of a different effort.
Cheers,
-Joe
On 08/19/2014 11:16 AM, Sergey Bylokhov wrote:
Hi, Joe
Pushed. Thanks for the contribution.
Mandy
On 8/19/14 6:40 AM, Amy Lu wrote:
Thank you Mandy and Sherman for your review.
I'll need your help to push this.
Thanks,
Amy
On 8/19/14, 1:31 AM, Mandy Chung wrote:
On 8/18/14 12:08 AM, Amy Lu wrote:
There are two tests under jdk/test/java/util/Ba
Hi, Joe.
There are no news about this jsr in jdk9? I guess it will be useful in
jdk development also.
On 20.09.2011 23:00, Joe Darcy wrote:
Hello.
First, a procedural point, the party responsible for making progress on
a JSR is the spec lead, which in the case of JSR 305 is Bill Pugh.
When I
On 08/19/2014 06:50 AM, Amy Lu wrote:
On 8/19/14, 3:09 AM, Mandy Chung wrote:
On 8/18/14 12:49 AM, Amy Lu wrote:
There are jdk tests that have dependency on sun.misc.DoubleConsts
and sun.misc.FloatConsts.
This fix is to remove above internal API dependency from the tests.
bug: https://bugs.op
Thanks Joe.
I will move the tests to [openjdk]/jaxp repo then.
Tristan
> On Aug 19, 2014, at 10:32 AM, huizhe wang wrote:
>
> By the way, the plan has been that all of the JAXP SQE and Unit tests be
> migrated into [openjdk]/jaxp repo under jaxp/test. Tests currently in the jdk
> repo shall be
By the way, the plan has been that all of the JAXP SQE and Unit tests be
migrated into [openjdk]/jaxp repo under jaxp/test. Tests currently in
the jdk repo shall be moved to jaxp/test as well. I see that your webrev
was generated in jdk9/dev/jdk. I hope it doesn't mean you're checking
tests int
Hi Otávio,
The new alignment in DataLine.java/JColorChooser.java looks strange.
Wrong change in BasicTableUI.java:
-plainStr.deleteCharAt(plainStr.length() -
1).append("\n");
+plainStr.deleteCharAt(plainStr.length() -
1).append('\t');
On 13.08.2014 3:01,
Brian,
Yes, this works fine in cases when 'whatever' is a j.u.Collection (though some may argue that it's an overkill already). However we
need even more thinking and transformations in case when 'whatever' is one of
these:
* j.u.Iterator
* j.l.Iterable
* j.u.Enumeration
* CharSeque
Stanimir,
Looks like the int overflow on the metered stream is an issue that hasn't been
tracked. The other issues have been reported under
https://bugs.openjdk.java.net/browse/JDK-6433253
and https://bugs.openjdk.java.net/browse/JDK-8028786
Jason
---
On 8/15/14 10:32 PM, Mandy Chung wrote:
> Looks good. Nit: adding a space between catch and ( would be good.
Thanks Mandy.
I took that opportunity to also fix the spaces before and after '+' in
print statements.
For the record the new webrev I'm going to push is here:
http://cr.openjdk.java.ne
On 8/19/14, 3:09 AM, Mandy Chung wrote:
On 8/18/14 12:49 AM, Amy Lu wrote:
There are jdk tests that have dependency on sun.misc.DoubleConsts and
sun.misc.FloatConsts.
This fix is to remove above internal API dependency from the tests.
bug: https://bugs.openjdk.java.net/browse/JDK-8042003
webre
Thank you Mandy and Sherman for your review.
I'll need your help to push this.
Thanks,
Amy
On 8/19/14, 1:31 AM, Mandy Chung wrote:
On 8/18/14 12:08 AM, Amy Lu wrote:
There are two tests under jdk/test/java/util/Base64 that have
dependency on internal API sun.misc.BASE64Encoder sun.misc.BASE64
Re-added lost diff
On 19.08.2014 16:58, Evgeniya Stepanova wrote:
Hi all,
Could you please review fix for 8055393
Problem:Some tests are being executed and fail under profiles
Solution:
-test java/lang/ProcessBuilder/InheritIO/InheritIO.sh changed to use
COMPILEJAVA (set by jtreg harness) java
Hi all,
Could you please review fix for 8055393
Problem:Some tests are being executed and fail under profiles
Solution:
-test java/lang/ProcessBuilder/InheritIO/InheritIO.sh changed to use
COMPILEJAVA (set by jtreg harness) javac instead of TESTJAVA (which is absent
in profiles)
-java/lang/anno
java.util.logging.FileHandler uses ints to track the written bytes
that can cause negative value for
java.util.logging.FileHandler.MeteredStream.written as there is no
check in any of the write methods.
The overflow prevents the check in FileHandler.publish(LogRecord)
meter.written >= limit to ever
16 matches
Mail list logo
