On 09.08.2014 4:44, Claes Redestad wrote:
Looks good to me, if that matters...
Thanks Claes!
Not sure if worth considering, but for simple cases like
src/share/classes/java/util/PropertyPermission.java, you could return
the possible constant values instead:
static String getActions(int ma
Thanks Joe!
I should have been more accurate with keeping the original delimiters.
Please find the updated webrev here:
http://cr.openjdk.java.net/~igerasim/8054714/1/webrev/
Sincerely yours,
Ivan
On 09.08.2014 5:38, Joe Darcy wrote:
Hello,
In src/share/classes/java/util/PropertyPermissio
I've noticed there's not much interest in improving Serialization on these
lists. This makes me wonder if java Serialization has lost relevance in recent
years with the rise of protocol buffers apache thrift and other means of data
transfer over byte streams.
The burden of implementing Seriali
Hello,
In src/share/classes/java/util/PropertyPermission.java, I believe the
separator in
327 static String getActions(int mask) {
328 StringJoiner sj = new StringJoiner(", ");
should be "," (a single comma) rather than ", " (a comma followed by a
space).
In src/share/classes
Looks good to me, if that matters...
Not sure if worth considering, but for simple cases like
src/share/classes/java/util/PropertyPermission.java, you could return
the possible constant values instead:
static String getActions(int mask) {
switch (mask & 0x3) {
case 1:
On 8/7/14, 1:48 AM, Florian Weimer wrote:
On 07/29/2014 01:09 AM, Ioi Lam wrote:
Hi Folks,
Please review the following clean up and refactoring of the CDS code,
for JDK9
http://cr.openjdk.java.net/~iklam/8046070-cds-cleanup-v2/
https://bugs.openjdk.java.net/browse/JDK-8046070
Can you c
On 8/6/14, 8:25 PM, David Holmes wrote:
A couple of responses inline ...
Cheers,
David
On 7/08/2014 11:25 AM, Ioi Lam wrote:
Hi David,
Thanks for the reviews. I will incorporate your suggestions. See
additional comments below:
On 8/6/14, 3:20 AM, David Holmes wrote:
Hi Ioi,
Continuing ...
Hello everyone!
This is a follower of the recently fixed [8051382] -- Optimize
java.lang.reflect.Modifier.toString().
I found a dozen+ other places in jdk, where using the StringJoiner makes
the code shorter and cleaner.
Would you please help review the fix?
http://cr.openjdk.java.net/~ige
Looks good!
I've scanned through the webrev and found no issues.
I'm not an official reviewer though.
Sincerely yours,
Ivan
On 08.08.2014 21:14, Lance Andersen wrote:
Hi Ivan,
Here is the revised with your additional input. I think I needed
extra coffee this morning
http://cr.openjdk.java.n
Hi Ivan,
Here is the revised with your additional input. I think I needed extra coffee
this morning http://cr.openjdk.java.net/~lancea/8054555/webrev.02/
Best,
Lance
On Aug 8, 2014, at 9:39 AM, Ivan Gerasimov wrote:
> Hi Lance!
>
> 1)
> src/share/classes/java/sql/CallableStatement.java
>
>
Dne Pá 8. srpna 2014 15:02:41, Stanimir Simeonoff napsal(a):
> The snippet is likely to just result into a NPE at obj.toString() than
> anything else as "obj" must be a member and volatile to even compile.
Well, it is just pseudo-code. Please notice that variables don't even have
right types.
My
Hi Lance!
1)
src/share/classes/java/sql/CallableStatement.java
+ * is less than zero; if the number of bytes in the "{@code
InputStream}
should be
+ * is less than zero; if the number of bytes in the {@code InputStream}
3)
src/share/classes/javax/sql/RowSet.java
+ * The reader mu
On 08/08/2014 11:55 AM, Jaroslav Tulach wrote:
> Dne Pá 8. srpna 2014 10:01:14, Andrew Haley napsal(a):
>
>> On 08/08/14 09:01, Jaroslav Tulach wrote:
>> > Given the fact that WeakReference & co. has been introduced in JDK
>> > 1.2 and that version was released at the end of 1998, I bet it was
>>
Hi Jaroslav,
The snippet is likely to just result into a NPE at obj.toString() than
anything else as "obj" must be a member and volatile to even compile.
Stanimir
On Fri, Aug 8, 2014 at 11:01 AM, Jaroslav Tulach wrote:
> Hello Doug,
> thanks for your reply and clarification about finalization
Hi Joe, Ivan,
Thank you for the feedback.
Attached is the revised webrev
http://cr.openjdk.java.net/~lancea/8054555/webrev.01/
Best,
Lance
On Aug 7, 2014, at 8:16 PM, Ivan Gerasimov wrote:
> And a few more duplicates under jdk/src/share/classes/java/sql:
>
> ./NClob.java: * which provides pr
Dne Pá 8. srpna 2014 10:01:14, Andrew Haley napsal(a):
> On 08/08/14 09:01, Jaroslav Tulach wrote:
> > Given the fact that WeakReference & co. has been introduced in JDK
> > 1.2 and that version was released at the end of 1998, I bet it was
> > just a communication problem, as Andrew must have been
On 08/08/14 09:01, Jaroslav Tulach wrote:
> Given the fact that WeakReference & co. has been introduced in JDK
> 1.2 and that version was released at the end of 1998, I bet it was
> just a communication problem, as Andrew must have been talking about
> something else than WeakReference + Reference
Roger Riggs wrote:
> I can't help but ask how this differs from sun.misc.Cleaner?
> One concern is about security and robustness of the code that is run on
> the system threads.
> I don't have the history but these are very sensitive areas of operation.
Thanks for bringing Cleaner into the picture
Hello Doug,
thanks for your reply and clarification about finalization. May I ask for one
more
clarification, this time about WeakReference behavior?
There has been a claim made in this thread that an object which is "really
gone" (from
a point of view of WeakReference) may have its instance m
19 matches
Mail list logo
