Re: please review draft JEP: Convenience Factory Methods for Collections

Regarding why you didn't choose a straight vararg solution, I prefer you do allow any number of key/values as long as you throw an exception if the array is not an even sized. Cheers, Paul On Wed, Jul 16, 2014 at 8:58 PM, Stuart Marks wrote: > On 7/16/14 6:03 PM, Remi Forax wrote: > >> On 07/

Re: please review draft JEP: Convenience Factory Methods for Collections

On 7/16/14 6:03 PM, Remi Forax wrote: On 07/17/2014 02:46 AM, Stuart Marks wrote: Please review this draft JEP for Convenience Factory Methods for Collections: https://bugs.openjdk.java.net/browse/JDK-8048330 Brief background: several times over the years there have been proposals to add "

Re: RFR: JDK-8042589: String.toLowerCase do not work for some concatenated strings

On 07/09/2014 01:04 PM, Xueming Shen wrote: Hi, Please help review the change for JDK-8042589. Issue:https://bugs.openjdk.java.net/browse/JDK-8042589 webrev: http://cr.openjdk.java.net/~sherman/8042589/webrev/ This is a regression caused by the following change for #JDK-8032012, issue:

Re: RFR (JAXP): 8049514: FEATURE_SECURE_PROCESSING can not be turned off on a validator through SchemaFactory

Thanks Lance. Joe On 7/16/2014 4:21 PM, Lance Andersen wrote: Seems fine Joe… On Jul 16, 2014, at 11:47 AM, huizhe wang > wrote: Hi, JAXP SecurityManager was re-designed to XMLSecurityManager to manage jaxp related limits or restrictions. Previously, the ex

Re: please review draft JEP: Convenience Factory Methods for Collections

On 07/17/2014 02:46 AM, Stuart Marks wrote: Hi all, Please review this draft JEP for Convenience Factory Methods for Collections: https://bugs.openjdk.java.net/browse/JDK-8048330 Brief background: several times over the years there have been proposals to add "collection literals" to th

Re: JDK 9 RFR of JDK-8050798: New unchecked warning introduced in com.sun.jndi.ldap.Connection

Looks good. Mandy On 7/16/2014 5:24 PM, Joe Darcy wrote: Hello, Please review the patch below for JDK-8050798: New unchecked warning introduced in com.sun.jndi.ldap.Connection which addresses a newly-introduced unchecked warning in core libs. Thanks, -Joe diff -r e4a6f3779797 src/sha

please review draft JEP: Convenience Factory Methods for Collections

Hi all, Please review this draft JEP for Convenience Factory Methods for Collections: https://bugs.openjdk.java.net/browse/JDK-8048330 Brief background: several times over the years there have been proposals to add "collection literals" to the language. The most recent round of this was in

Re: JDK 9 RFR of JDK-8050798: New unchecked warning introduced in com.sun.jndi.ldap.Connection

+1 On Jul 16, 2014, at 8:24 PM, Joe Darcy wrote: > Hello, > > Please review the patch below for > >JDK-8050798: New unchecked warning introduced in > com.sun.jndi.ldap.Connection > > which addresses a newly-introduced unchecked warning in core libs. > > Thanks, > > -Joe > > diff -r e4a

JDK 9 RFR of JDK-8050798: New unchecked warning introduced in com.sun.jndi.ldap.Connection

Hello, Please review the patch below for JDK-8050798: New unchecked warning introduced in com.sun.jndi.ldap.Connection which addresses a newly-introduced unchecked warning in core libs. Thanks, -Joe diff -r e4a6f3779797 src/share/classes/com/sun/jndi/ldap/Connection.java --- a/src/shar

Re: FYC: 7197183 : Provide CharSequence.subSequenceView which allows for sub-sequence views of character sequences.

If I recall correctly, CharBuffer.wrap(charSequence).subSequence(from, to) has equivalent semantics without requiring a new implementation, even if the implementation is fairly simple. On Wed, Jul 16, 2014 at 5:09 PM, Mike Duigou wrote: > Hello all; > > In Java 7u6 there was a significant chang

FYC: 7197183 : Provide CharSequence.subSequenceView which allows for sub-sequence views of character sequences.

Hello all; In Java 7u6 there was a significant change in the implementation of java.lang.String (JDK-6924259). This was done to reduce the size of String instances and it has been generally regarded as a positive change. As with almost any significant change to a class as core to Java as String

Re: RFR (JAXP): 8049514: FEATURE_SECURE_PROCESSING can not be turned off on a validator through SchemaFactory

Seems fine Joe… On Jul 16, 2014, at 11:47 AM, huizhe wang wrote: > Hi, > > JAXP SecurityManager was re-designed to XMLSecurityManager to manage jaxp > related limits or restrictions. Previously, the existence of a > SecurityManager was equivalent to setting FEATURE_SECURE_PROCESSING to true.

Re: RFR: JDK-8042589: String.toLowerCase do not work for some concatenated strings

Still need a reviewer. On 07/09/2014 01:04 PM, Xueming Shen wrote: Hi, Please help review the change for JDK-8042589. Issue:https://bugs.openjdk.java.net/browse/JDK-8042589 webrev: http://cr.openjdk.java.net/~sherman/8042589/webrev/ This is a regression caused by the following change for

Re: Review request for 8050804: (jdeps) Recommend supported API to replace use of JDK internal API

Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8050804/webrev.01/ I plan to backport this to 8u40. Mandy On 7/16/14 8:09 AM, Mandy Chung wrote: My first version prints a separate table of the replacements following the new warning message at the end of the jdeps output. I like

Re: RFR: [6904367]: (coll) IdentityHashMap is resized before exceeding the expected maximum size

Hi, took me some time to setup Maven/JMH and learn the basics. (two tools in a day, phew, that's more than I usually do in a year! :) >JIT can sometimes optimize the code so aggressively I was trying to bench this aggressively optimized version of the code, with the idea that: - If the JVM th

Re: [9] RFR (M): 8050052: Small cleanups in java.lang.invoke code

On 07/16/2014 05:14 PM, Peter Levart wrote: On 07/15/2014 09:51 PM, John Rose wrote: On Jul 11, 2014, at 10:56 AM, Remi Forax wrote: On 07/11/2014 06:18 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8050052 I've fo

Re: RFR JDK-8050869: Convert runtime dependency to Applet to a static dependency in cosnaming

On 7/16/14 8:59 AM, Chris Hegarty wrote: This looks like a reasonable reversal of 6898747 [1], so good for me. Yes this dependency is no longer an issue. It looks okay to keep the static reference. Mandy -Chris. [1] http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/a368ebcfeeb6 On 16/07/14

[9] RFR (S): 8050887: Intrinsify constants for default values

http://cr.openjdk.java.net/~vlivanov/8050887/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8050887 Intrinsify MethodHandles.constant() for default values. Testing: jdk/java/lang/invoke, jdk/java/util/streams, nashorn, octane w/ "-ea -esa" and COMPILE_THRESHOLD={0,30}. Reviewed-by: vlivan

[9] RFR (M): 8050884: Intrinsify ValueConversions.identity() functions

http://cr.openjdk.java.net/~vlivanov/8050884/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8050884 Replace ValueConversions.identity() functions with intrinsics. Testing: jdk/java/lang/invoke, jdk/java/util/streams, nashorn, octane w/ "-ea -esa" and COMPILE_THRESHOLD={0,30}. Reviewed-by

[9] RFR (M): 8050877: Improve code for pairwise argument conversions and value boxing/unboxing

http://cr.openjdk.java.net/~vlivanov/8050877/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8050877 Improved MethodHandleImpl.makePairwiseConvert & ValueConversions.unbox and small cleanups in related code. Also, improved method handle caching in ValueConversions. MethodHandleImpl.makePa

Re: JDK 9 RFR of JDK-8030942: Explicitly state floating-point summation requirements on non-finite inputs

On Jul 16, 2014, at 5:39 PM, Joe Darcy wrote: > Hi Paul, > > On 07/16/2014 07:46 AM, Paul Sandoz wrote: >> On Jul 16, 2014, at 2:29 AM, Joe Darcy wrote: >> >>> Hello, >>> >>> Please review my changes to address: >>> >>>JDK-8030942: Explicitly state floating-point summation requirements on

Re: RFR JDK-8050869: Convert runtime dependency to Applet to a static dependency in cosnaming

On 16/07/2014 16:41, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8050869? http://cr.openjdk.java.net/~prappo/8050869/webrev.00/ This looks okay to me too. As we've since established, this dependency is no longer an issue. -Alan

Re: RFR JDK-8050869: Convert runtime dependency to Applet to a static dependency in cosnaming

This looks like a reasonable reversal of 6898747 [1], so good for me. -Chris. [1] http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/a368ebcfeeb6 On 16/07/14 16:41, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8050869? http://cr.openjdk.java.net/~prappo/8050869/webre

RFR (JAXP): 8049514: FEATURE_SECURE_PROCESSING can not be turned off on a validator through SchemaFactory

Hi, JAXP SecurityManager was re-designed to XMLSecurityManager to manage jaxp related limits or restrictions. Previously, the existence of a SecurityManager was equivalent to setting FEATURE_SECURE_PROCESSING to true. After the change, secure processing became a property of XMLSecurityManager

RFR JDK-8050869: Convert runtime dependency to Applet to a static dependency in cosnaming

Hi everyone, Could you please review my change for JDK-8050869? http://cr.openjdk.java.net/~prappo/8050869/webrev.00/ Thanks -Pavel

Re: [9] RFR (M): 8050052: Small cleanups in java.lang.invoke code

On 07/15/2014 09:51 PM, John Rose wrote: On Jul 11, 2014, at 10:56 AM, Remi Forax wrote: On 07/11/2014 06:18 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8050052 I've found myself writing the very same code as Me

Re: JDK 9 RFR of JDK-8030942: Explicitly state floating-point summation requirements on non-finite inputs

Hi Paul, On 07/16/2014 07:46 AM, Paul Sandoz wrote: On Jul 16, 2014, at 2:29 AM, Joe Darcy wrote: Hello, Please review my changes to address: JDK-8030942: Explicitly state floating-point summation requirements on non-finite inputs http://cr.openjdk.java.net/~darcy/8030942.0/ Patch

Re: [9] RFR (M): 8050052: Small cleanups in java.lang.invoke code

On 07/15/2014 09:51 PM, John Rose wrote: On Jul 11, 2014, at 10:56 AM, Remi Forax wrote: On 07/11/2014 06:18 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8050052/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8050052 I've found myself writing the very same code as Met

Re: Review request for 8050804: (jdeps) Recommend supported API to replace use of JDK internal API

My first version prints a separate table of the replacements following the new warning message at the end of the jdeps output. I like the first version better than this version replacing rt.jar with "Use..." message. I might be too anxious getting developers to take action using the supporte

Re: JDK 9 RFR of JDK-8030942: Explicitly state floating-point summation requirements on non-finite inputs

On Jul 16, 2014, at 2:29 AM, Joe Darcy wrote: > Hello, > > Please review my changes to address: > >JDK-8030942: Explicitly state floating-point summation requirements on > non-finite inputs >http://cr.openjdk.java.net/~darcy/8030942.0/ > > Patch below. > That looks a reasonable des

Re: Covariant overrides on the Buffer Hierarchy redux

On 16/07/2014 13:58, Paul Sandoz wrote: Hi, There was discussion here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-April/026458.html https://bugs.openjdk.java.net/browse/JDK-4774077 http://cr.openjdk.java.net/~rwarburton/buffer-overrides-1/

Re: Review request for 8050804: (jdeps) Recommend supported API to replace use of JDK internal API

Hi Mandy, here is a typical output - with names mangled to save space: s.u.l.p.LPA (rt.jar) -> s.s.a.GP JDK internal API (Use j.s.PA @since 1.1) -> s.u.c.CLDRLPA JDK internal API (rt.jar) In the first dependency line, the archive name has been replaced by the 'Use ...' message. I wo

Covariant overrides on the Buffer Hierarchy redux

Hi, There was discussion here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-April/026458.html https://bugs.openjdk.java.net/browse/JDK-4774077 http://cr.openjdk.java.net/~rwarburton/buffer-overrides-1/ The patch looks good. I have just one comment: can you check the tests t

Policy Provider and Extensible RMI Performance.

Who said security and RMI had to be performance dogs? Anyone ever notice it's native code that uses all the CPU? 100% CPU Utilisation 0% monitor Peak live threads 99 Test run time 2 minutes. 4891 Remote Object Invocations, includes remote code downloading and class loading (thread confined).

Re: Review request for 8050804: (jdeps) Recommend supported API to replace use of JDK internal API

On Jul 16, 2014, at 1:25 PM, Remi Forax wrote: > > On 07/16/2014 01:35 AM, Mandy Chung wrote: >> jdeps -jdkinternals flags use of JDK internal APIs. We have created a wiki >> page to keep track of the JDK internal APIs and its replacement: >> https://wiki.openjdk.java.net/display/JDK8/Java+Depe

Re: Review request for 8050804: (jdeps) Recommend supported API to replace use of JDK internal API

On 07/16/2014 01:35 AM, Mandy Chung wrote: jdeps -jdkinternals flags use of JDK internal APIs. We have created a wiki page to keep track of the JDK internal APIs and its replacement: https://wiki.openjdk.java.net/display/JDK8/Java+Dependency+Analysis+Tool not sure to understand why Shenandoa

Re: [9] RFR (M): 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle

On Jul 16, 2014, at 12:53 PM, Vladimir Ivanov wrote: > Paul, thanks for review. > > On 7/16/14 12:34 PM, Paul Sandoz wrote: >> >> On Jul 14, 2014, at 4:04 PM, Vladimir Ivanov >> wrote: >> >>> http://cr.openjdk.java.net/~vlivanov/8050166/webrev.00/ >>> https://bugs.openjdk.java.net/browse/J

Re: [9] RFR (M): 8050200: Make LambdaForm intrinsics detection more robust

Paul, thanks for review. http://cr.openjdk.java.net/~vlivanov/8050200/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8050200 Replace pattern matching sequences of LambdaForm names during compilation with explicit marks on MethodHandles. Intrinsic ID is associated with a method handle usi

Re: [9] RFR (M): 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle

Paul, thanks for review. On 7/16/14 12:34 PM, Paul Sandoz wrote: On Jul 14, 2014, at 4:04 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8050166/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8050166 Get rid of the following methods in j.l.i.MethodHandle: * convertA

Re: [9] RFR (M): 8050057: Improve caching of MethodHandle reinvokers

Thank you, Paul. Looks good. Juste one comment. BoundMethodHandle The following fields can be made final: 132 private static int FIELD_COUNT_THRESHOLD = 12; // largest convenient BMH field count 133 private static int FORM_EXPRESSION_THRESHOLD = 24; // largest convenient BMH expres

Re: [9] RFR (M): 8050200: Make LambdaForm intrinsics detection more robust

On Jul 14, 2014, at 7:10 PM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8050200/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8050200 > > Replace pattern matching sequences of LambdaForm names during compilation > with explicit marks on MethodHandles. Intrinsic ID i

Re: [9] RFR (M): 8050057: Improve caching of MethodHandle reinvokers

On Jul 14, 2014, at 5:17 PM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8050057/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8050057 > > Cache MethodHandle reinvokers per basic type. > For BoundMethodHandles, rebinding is no-op unless underlying LF is too > complex

Re: [9] RFR (XS): 8050174: Support overriding of isInvokeSpecial flag in WrappedMember

On Jul 14, 2014, at 4:47 PM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8050174/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8050174 > > Support overriding of isInvokeSpecial flag in WrappedMember. > > Testing: jdk/java/lang/invoke, jdk/java/util/streams, nashorn,

Re: [9] RFR (S) 8050173: Generalize BMH.copyWith API to all method handles

On Jul 14, 2014, at 4:37 PM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8050173/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8050173 > > Added j.l.i.MethodHandle.copyWith(MethodType, LambdaForm) and provided > implementation for all subclasses. > > Also, some clea

Re: [9] RFR (M): 8050166: Get rid of some package-private methods on arguments in j.l.i.MethodHandle

On Jul 14, 2014, at 4:04 PM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8050166/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8050166 > > Get rid of the following methods in j.l.i.MethodHandle: > * convertArguments(MethodType newType) > * bindArgument(int pos, Basi

Re: RFR: 7130985: Four helper classes missing in Sun JDK

Hi Alan, we retrieved the IDL from the OMG web site http://www.omg.org/spec/CORBAe/20080201/CORBA_TypeCode.idl to regenerate the Helper classes ... this didn't compile properly and had to be manipulated to get the relevant exceptions required IvalidName is defined in http://www.omg.org/spec/CO

Re: [9] RFR (M): 8050052: Small cleanups in java.lang.invoke code

Thank you, Paul. Best regards, Vladimir Ivanov On 7/16/14 11:35 AM, Paul Sandoz wrote: On Jul 15, 2014, at 3:42 PM, Vladimir Ivanov wrote: Another update: http://cr.openjdk.java.net/~vlivanov/8050052//webrev.01/ Tentative diff: http://cr.openjdk.java.net/~vlivanov/8050052/webrev.diff.01-0

Re: [9] RFR (M): 8050053: Improve caching of different invokers

Thank you, Paul. Best regards, Vladimir Ivanov On 7/16/14 11:28 AM, Paul Sandoz wrote: On Jul 15, 2014, at 3:48 PM, Vladimir Ivanov wrote: Update: http://cr.openjdk.java.net/~vlivanov/8050053/webrev.01 Diff: http://cr.openjdk.java.net/~vlivanov/8050053/webrev.diff.00-01/ Got rid of vararg

Re: [9] RFR (M): 8050052: Small cleanups in java.lang.invoke code

On Jul 15, 2014, at 3:42 PM, Vladimir Ivanov wrote: > Another update: > http://cr.openjdk.java.net/~vlivanov/8050052//webrev.01/ > > Tentative diff: > http://cr.openjdk.java.net/~vlivanov/8050052/webrev.diff.01-02/ > +1 Paul.

Re: [9] RFR (M): 8050053: Improve caching of different invokers

On Jul 15, 2014, at 3:48 PM, Vladimir Ivanov wrote: > Update: http://cr.openjdk.java.net/~vlivanov/8050053/webrev.01 > Diff: http://cr.openjdk.java.net/~vlivanov/8050053/webrev.diff.00-01/ > > Got rid of varargs & spread invokers. > +1 Paul.