Re: Review Request for 8027481: jdeps to handle classes with the same package name ...

2013-10-29 Thread Mandy Chung
I have added the test cases to verify dependency on javax.crypto and also a class in a SE package (javax.activity in the test case). The updated webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/webrev.01/ Mandy On 10/29/2013 2:37 PM, Mandy Chung wrote: On 10/29/13 2:19 PM, Dan

Re: JDK 8 RFR, redux, for JDK-8005294 : Consider default methods for additions to AnnotatedElement

2013-10-29 Thread Joe Darcy
On 10/29/2013 06:37 PM, Joe Darcy wrote: Hi Joel, On 10/29/2013 09:20 AM, Joel Borggrén-Franck wrote: Hi Joe, Peter, On 29 okt 2013, at 07:09, Joe Darcy wrote: Your comments, along with some spec refinements from the other OpenJDK list, are reflected in the next iteration of the webrev:

RFR: 8023863: deprecate support for statically-generated stubs from RMI (JRMP)

2013-10-29 Thread Stuart Marks
Hi all, Please review the following specification change to deprecate RMI/JRMP static stubs. This change consists only of deprecations and spec clarifications. There are no actual API changes (classes, method signatures, etc.), nor are there any behavioral or functional differences. This does

Re: JDK 8 RFR, redux, for JDK-8005294 : Consider default methods for additions to AnnotatedElement

2013-10-29 Thread Joe Darcy
Hi Joel, On 10/29/2013 09:20 AM, Joel Borggrén-Franck wrote: Hi Joe, Peter, On 29 okt 2013, at 07:09, Joe Darcy wrote: Your comments, along with some spec refinements from the other OpenJDK list, are reflected in the next iteration of the webrev: http://cr.openjdk.java.net/~darcy/80052

Re: RFR (JAXP): 8024378 : StAX parser shall support JAXP properties

2013-10-29 Thread huizhe wang
I updated the webrev to also fix the error message that showed the actual number of attributes parsed rather than the limit itself. http://cr.openjdk.java.net/~joehw/jdk8/8024378/webrev/ Thanks, Joe On 10/29/2013 4:49 PM, huizhe wang wrote: It appears the previous patch was one line short of s

core-libs-dev@openjdk.java.net

2013-10-29 Thread michael . fang
Changeset: bede752d1e3c Author:mfang Date: 2013-10-29 16:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bede752d1e3c 8025521: [de] mnemonic conflict in FileChooser for GTK Style feel&look Reviewed-by: naoto ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_de.

RFR (JAXP): 8024378 : StAX parser shall support JAXP properties

2013-10-29 Thread huizhe wang
It appears the previous patch was one line short of supporting setting the JAXP's new property ElementAttributeLimit through the StAX factory, that is, resetting the variable in reset(PropertyManager propertyManager) as well. Other than that, I also moved the common reset items from reset(XMLC

hg: jdk8/tl/jdk: 2 new changesets

2013-10-29 Thread michael . fang
Changeset: 8cfc73ad9f31 Author:mfang Date: 2013-10-29 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8cfc73ad9f31 8008647: [es] minor cosmetic issues in translated java command line outputs Reviewed-by: naoto ! src/share/classes/sun/tools/jar/resources/jar_es.propertie

hg: jdk8/tl/jaxp: 8027484: Implementation error in SAX2DOM.java

2013-10-29 Thread huizhe . wang
Changeset: 1af33ab1bc58 Author:joehw Date: 2013-10-29 14:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1af33ab1bc58 8027484: Implementation error in SAX2DOM.java Reviewed-by: alanb, lancea ! src/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2DOM.java

Re: Review Request for 8027481: jdeps to handle classes with the same package name ...

2013-10-29 Thread Mandy Chung
On 10/29/13 2:19 PM, Daniel Fuchs wrote: Hi Mandy, The changes look good to me - though I am a novice in this area: so I could have missed a few things. As a general comment I would say that this code could benefit from some more commenting - if you don't know what it's supposed to do then it i

Re: Review Request for 8027481: jdeps to handle classes with the same package name ...

2013-10-29 Thread Daniel Fuchs
Hi Mandy, The changes look good to me - though I am a novice in this area: so I could have missed a few things. As a general comment I would say that this code could benefit from some more commenting - if you don't know what it's supposed to do then it is a bit difficult to reverse-engineer :-)

Re: RFR (JAXP): 8027484 : Implementation error in SAX2DOM.java

2013-10-29 Thread Lance Andersen - Oracle
+1 On Oct 29, 2013, at 5:13 PM, huizhe wang wrote: > A quick fix to add the missing braces and correct the misspellings. > > webrevs: http://cr.openjdk.java.net/~joehw/jdk8/8027484/webrev/ > > The following is where the braces were missing, others were a global > substitution of the misspelling

RFR (JAXP): 8027484 : Implementation error in SAX2DOM.java

2013-10-29 Thread huizhe wang
A quick fix to add the missing braces and correct the misspellings. webrevs: http://cr.openjdk.java.net/~joehw/jdk8/8027484/webrev/ The following is where the braces were missing, others were a global substitution of the misspelling. if (_factory == null) { -if (useServic

hg: jdk8/tl/jdk: 8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing since JDK-8004926

2013-10-29 Thread jaroslav . bachorik
Changeset: a3ac9c0b19a9 Author:jbachorik Date: 2013-10-29 21:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3ac9c0b19a9 8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing since JDK-8004926 Reviewed-by: alanb, egahlin ! test/sun/management/jmxre

Review Request for 8027481: jdeps to handle classes with the same package name ...

2013-10-29 Thread Mandy Chung
Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8027481 This patch fixes a couple of small jdeps issues: 1) jdeps doesn't handle the same package name being used in more than one JAR files. It currently incorrectly shows t

hg: jdk8/tl/jdk: 3 new changesets

2013-10-29 Thread michael . fang
Changeset: 6fc2889fe7d0 Author:mfang Date: 2013-10-29 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6fc2889fe7d0 8026108: [it, ja, zh_CN] wrong translation in jar example. Reviewed-by: okutsu, yhuang ! src/share/classes/sun/tools/jar/resources/jar_it.properties ! src/

hg: jdk8/tl/jdk: 8027466: Revert jdk/THIRD_PARTY_README to known good version

2013-10-29 Thread chris . hegarty
Changeset: 121c34517841 Author:chegar Date: 2013-10-29 17:21 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/121c34517841 8027466: Revert jdk/THIRD_PARTY_README to known good version Reviewed-by: alanb ! THIRD_PARTY_README

Re: JDK 8 RFR, redux, for JDK-8005294 : Consider default methods for additions to AnnotatedElement

2013-10-29 Thread Joel Borggrén-Franck
Hi Joe, Peter, On 29 okt 2013, at 07:09, Joe Darcy wrote: > > Your comments, along with some spec refinements from the other OpenJDK list, > are reflected in the next iteration of the webrev: > > http://cr.openjdk.java.net/~darcy/8005294.5/ > > Thanks, > 259 if (result.length =

Re: RFR: revert THIRD_PARTY_README

2013-10-29 Thread Alan Bateman
On 29/10/2013 15:56, Chris Hegarty wrote: Hi, This is a trivial change to revert the jdk/THIRD_PARTY_README file to a previous known good version. A recent push from Jim accidentally changed this file. I exchanged mail with him offline, and he is happy for me to revert it. This looks fine

RFR: revert THIRD_PARTY_README

2013-10-29 Thread Chris Hegarty
Hi, This is a trivial change to revert the jdk/THIRD_PARTY_README file to a previous known good version. A recent push from Jim accidentally changed this file. I exchanged mail with him offline, and he is happy for me to revert it. diff -r f5c9333b6129 THIRD_PARTY_README --- a/THIRD_PARTY_R

hg: jdk8/tl/jdk: 27 new changesets

2013-10-29 Thread james . laskey
Changeset: a8bbd962f34a Author:jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8bbd962f34a 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.las...@oracle.com ! THIRD_PARTY_README ! make/launchers/Makef

hg: jdk8/tl: 26 new changesets

2013-10-29 Thread james . laskey
Changeset: 3dc55f0c1b6f Author:jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3dc55f0c1b6f 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.las...@oracle.com ! common/autoconf/generated-configure.sh ! comm

hg: jdk8/tl/nashorn: 3 new changesets

2013-10-29 Thread james . laskey
Changeset: 7985ec3782b5 Author:hannesw Date: 2013-10-25 10:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7985ec3782b5 8027042: Evaluation order for binary operators can be improved Reviewed-by: lagergren, jlaskey, attila ! src/jdk/nashorn/internal/codegen/CodeGenerat

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-29 Thread Aleksej Efimov
Alan, I want to keep this test until I'll came up with new regression test . And I might will come up with some idea on this test modifications instead of deletion. So thats why I put it to ProblemsList.txt instead of deletion - some sort put it on hold with no impact to JDK 8 release process.

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-29 Thread Alan Bateman
On 24/10/2013 14:32, Aleksej Efimov wrote: Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proceed with closing this bug. Can I ask you to sponsorship this change in such case? The hg patch located here: http://cr.openjdk.java.net/~aefimov/8026772/8026772_jdk8.patc

hg: jdk8/tl/jdk: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-29 Thread sean . coffey
Changeset: d34c5e860d5f Author:aefimov Date: 2013-10-24 17:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d34c5e860d5f 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing Reviewed-by: okutsu, mfang, alanb ! test/ProblemList.txt ! test/sun/util/resources/Time

RFR: 8016725: TEST_BUG: java/lang/reflect/Method/DefaultMethodModeling.java failing intermittently

2013-10-29 Thread Andreas Lundblad
Hi, Please review the fix for JDK-8016725 below. Description: DefaultMethodModeling.java and Equals.java in jdk/test/java/lang/reflect/Method interfered with each other since both tests defines a class named 'A'. In this patch DefaultMethodModeling.java is moved to its own subdirectory. Link t

hg: jdk8/tl/jdk: 8027371: Add JDI tests for breakpointing and stepping in lambda code

2013-10-29 Thread staffan . larsen
Changeset: ecba02f6be31 Author:sla Date: 2013-10-29 08:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecba02f6be31 8027371: Add JDI tests for breakpointing and stepping in lambda code Reviewed-by: mchung, sspitsyn + test/com/sun/jdi/LambdaBreakpointTest.java + test/com/su