hg: jdk8/tl/langtools: 6499673: Assertion check for TypeVariable.getUpperBound() fails.

2013-09-23 Thread eric . mccorkle
Changeset: 09301757bb32 Author:emc Date: 2013-09-23 15:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09301757bb32 6499673: Assertion check for TypeVariable.getUpperBound() fails. Summary: Fix TypeVariable.getUpperBound to return results as specified Reviewed-by: jjg

Re: RFR: 8009719: core reflection should get type annotation data from the VM lazily

2013-09-23 Thread Erik Joelsson
I'm happy with the build part now. /Erik On 2013-09-23 16:00, Joel Borggren-Franck wrote: Hi all, Updated webrev: http://cr.openjdk.java.net/~jfranck/8009719/webrev.02/ Adds Field.c to make/java/java/FILES_c.gmk (old build) Renames parameter in Field.c from method to field Thanks for the sug

Re: Update JAX-WS RI integration to 2.2.9-b130918.1732

2013-09-23 Thread Alan Bateman
On 23/09/2013 02:19, Miroslav Kos wrote: Hi everybody, There is another update syncing JAX-WS sources in jdk8/tl/jaxws to most recent development version. As usually, it is quite big changeset (6k+ LOC changed) and includes several bug fixes, for details see the issue description: https://b

Re: Review java.time test refactoring

2013-09-23 Thread Stephen Colebourne
The change looks fine AFAICT. I would prefer to see the new serial package test classes have names that end in "Serialization", eg "TCKLocalDateSerialization", but if that does not happen it is not the end of the world. Stephen On 18 September 2013 22:31, roger riggs wrote: > A review of the TCK

hg: jdk8/tl/langtools: 8022567: Javac Should Generate Warnings For Raw Array Type

2013-09-23 Thread jan . lahoda
Changeset: 8d1c48de706d Author:jlahoda Date: 2013-09-19 17:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8d1c48de706d 8022567: Javac Should Generate Warnings For Raw Array Type Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/ja

hg: jdk8/tl/langtools: 8023835: TreeMaker.QualIdent() too leafy

2013-09-23 Thread jan . lahoda
Changeset: 41599b57d262 Author:jlahoda Date: 2013-09-20 16:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/41599b57d262 8023835: TreeMaker.QualIdent() too leafy Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java + test/tools/javac/tree/MakeQ

Re: Fwd: Re: type anno test code check in

2013-09-23 Thread Charlie Wang
OK, here's the link http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation1/webrev/ Also I would appreciate it if you could check in the code once you are OK with it, because these tests have gone through numerous rounds of review and I would like to wrap it up asap. If others have comments,

hg: jdk8/tl/langtools: 4881267: improve diagnostic for "instanceof T" for type parameter T

2013-09-23 Thread alexander . zuev
Changeset: 64e79d38bd07 Author:kizune Date: 2013-09-23 18:29 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64e79d38bd07 4881267: improve diagnostic for "instanceof T" for type parameter T Reviewed-by: vromero, jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java

Re: RFR: 8009719: core reflection should get type annotation data from the VM lazily

2013-09-23 Thread Joel Borggren-Franck
Hi all, Updated webrev: http://cr.openjdk.java.net/~jfranck/8009719/webrev.02/ Adds Field.c to make/java/java/FILES_c.gmk (old build) Renames parameter in Field.c from method to field Thanks for the suggestions/fixes! cheers /Joel On 2013-09-21, Joel Borggren-Franck wrote: > Hi > > A while ag

hg: jdk8/tl/langtools: 7154966: CRs found to be in Fixed state with no test and no noreg- keyword.

2013-09-23 Thread alexander . zuev
Changeset: 809a50f24d6f Author:kizune Date: 2013-09-23 17:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/809a50f24d6f 7154966: CRs found to be in Fixed state with no test and no noreg- keyword. Reviewed-by: ksrini + test/tools/javac/T7090499.java + test/tools/javac/

hg: jdk8/tl/langtools: 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()

2013-09-23 Thread joel . franck
Changeset: 5f915a0c9615 Author:alundblad Date: 2013-09-23 10:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5f915a0c9615 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb() Summary: Static factory method ListBuffer.lb removed. Replaced by constructor cal

hg: jdk8/tl/nashorn: 4 new changesets

2013-09-23 Thread sundararajan . athijegannathan
Changeset: 279f47b353f3 Author:sundar Date: 2013-09-20 20:55 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/279f47b353f3 8025147: Trailing comma is not allowed in JSONArray and JSONObject Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/parser/JSONParser.java ! s

hg: jdk8/tl/langtools: 8024988: javac, LVT test harness should generate tests .class files in the scratch folder

2013-09-23 Thread joel . franck
Changeset: 1fe358ea75ff Author:alundblad Date: 2013-09-23 10:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1fe358ea75ff 8024988: javac, LVT test harness should generate tests .class files in the scratch folder Summary: Set the CLASS_OUTPUT location to the scratch d

Update JAX-WS RI integration to 2.2.9-b130918.1732

2013-09-23 Thread Miroslav Kos
Hi everybody, There is another update syncing JAX-WS sources in jdk8/tl/jaxws to most recent development version. As usually, it is quite big changeset (6k+ LOC changed) and includes several bug fixes, for details see the issue description: https://bugs.openjdk.java.net/browse/JDK-8025054 P

Re: RFR: 8009719: core reflection should get type annotation data from the VM lazily

2013-09-23 Thread Joel Borggren-Franck
Hi, On 2013-09-22, Robert Lougher wrote: > Hi, > > Not a reviewer, but in Field.c the parameter to > getTypeAnnotationBytes0 is a field not a method. > Thanks, will rename that parameter before pushing. cheers /Joel

Re: RFR: 8009719: core reflection should get type annotation data from the VM lazily

2013-09-23 Thread Erik Joelsson
Or wait, you added a c-file to libjava and want the old build to keep working, then you need to add that file to jdk/make/java/java/FILES_c.gmk. /Erik On 2013-09-23 09:59, Erik Joelsson wrote: Build part of the changes are fine. /Erik On 2013-09-21 16:26, Joel Borggren-Franck wrote: Hi A w

Re: RFR: 8009719: core reflection should get type annotation data from the VM lazily

2013-09-23 Thread Erik Joelsson
Build part of the changes are fine. /Erik On 2013-09-21 16:26, Joel Borggren-Franck wrote: Hi A while ago [1] I introduced an extra field in to j.l.r.Method, j.l.r.Constructor, and j.l.r.Field in order to support reflection for type annotations. These fields were intended to be removed later,