Re: Java 8 RFR 8022109: Evaluate adding incrementExact, decrementExact, negateExact to java.lang.Math

Looks good to me. I am glad we were able to get this back into Java 8. Mike On Aug 9 2013, at 17:39 , Brian Burkhalter wrote: > Please review at your convenience: > > Issue http://bugs.sun.com/view_bug.do?bug_id=8022109 > Webrevhttp://cr.openjdk.java.net/~bpb/8022109/ > > The update is

Re: RFR: 8022749: Convert junit tests to testng in test/java/lang/invoke

Looks good to me. Nice cleanup Mani and thank you for sponsoring the change Henry! Mike On Aug 9 2013, at 17:25 , Henry Jen wrote: > Hi, > > Please review a webrev contributed by Mani Sarkar that converts junit > tests in test/java/lang/invoke to testng. > > http://cr.openjdk.java.net/~henryj

Java 8 RFR 8022180: BigInteger Burnikel-Ziegler quotient and remainder calculation assumes quotient parameter is zero

Please review at your convenience: Issue http://bugs.sun.com/view_bug.do?bug_id=8022180 Webrev http://cr.openjdk.java.net/~bpb/8022180/ The update is to clear the quotient if the divisor is larger than the dividend in divideAndRemainderBurnikelZiegler(). Thanks, Brian

Java 8 RFR 8022109: Evaluate adding incrementExact, decrementExact, negateExact to java.lang.Math

Please review at your convenience: Issue http://bugs.sun.com/view_bug.do?bug_id=8022109 Webrev http://cr.openjdk.java.net/~bpb/8022109/ The update is to add the methods incrementExact(), decrementExact(), and negateExact() for int and long parameters to java.lang.Math. Thanks, Brian

RFR: 8022749: Convert junit tests to testng in test/java/lang/invoke

Hi, Please review a webrev contributed by Mani Sarkar that converts junit tests in test/java/lang/invoke to testng. http://cr.openjdk.java.net/~henryjen/tl/8022749/0/webrev/ Cheers, Henry

Re: RFR: JAXP in JDK8/7u40 : 8022548 : SPECJVM2008 has errors introduced in 7u40-b34

On 8/9/2013 1:51 PM, Alan Bateman wrote: On 08/08/2013 22:57, huizhe wang wrote: Hi, The root cause of this issue is that SPECJVM2008 uses a 3rd party parser XOM 1.1 to convert the output to its canonical form. The XOM parser directly references to the JDK parser implementation "SAXParser"

hg: jdk8/tl/langtools: 8022161: javac Null Pointer Exception in Enter.visitTopLevel

Changeset: d601238641e6 Author:ksrini Date: 2013-08-09 15:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d601238641e6 8022161: javac Null Pointer Exception in Enter.visitTopLevel Reviewed-by: jjg, vromero, jlahoda ! src/share/classes/com/sun/tools/javac/comp/Enter.j

Re: RFR: JAXP in JDK8/7u40 : 8022548 : SPECJVM2008 has errors introduced in 7u40-b34

On 08/08/2013 22:57, huizhe wang wrote: Hi, The root cause of this issue is that SPECJVM2008 uses a 3rd party parser XOM 1.1 to convert the output to its canonical form. The XOM parser directly references to the JDK parser implementation "SAXParser" with a different configuration than the def

Re: RFR: 8022547: [verifier] move DefaultMethodRegressionTests.java to jdk

Kumar, Looks good. And thank you - we definitely needed the URLClassLoader so that we actually test the verifier, unless we had a force -Xverify:all flag. Thank you for fixing the major version from 0x33 ->0x34. I presume the push will also delete the file from the current location :-) thanks,

hg: jdk8/tl/jdk: 8022548: SPECJVM2008 has errors introduced in 7u40-b34

Changeset: 8f01ccb0c981 Author:joehw Date: 2013-08-09 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f01ccb0c981 8022548: SPECJVM2008 has errors introduced in 7u40-b34 Reviewed-by: chegar, lancea + test/javax/xml/jaxp/parsers/8022548/JDK8022548.xml + test/javax/xml/ja

hg: jdk8/tl/jaxp: 8022548: SPECJVM2008 has errors introduced in 7u40-b34

Changeset: 4e23bc205d9d Author:joehw Date: 2013-08-09 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/4e23bc205d9d 8022548: SPECJVM2008 has errors introduced in 7u40-b34 Reviewed-by: chegar, lancea ! src/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java

hg: jdk8/tl/jdk: 8020054: (tz) Support tzdata2013d

Changeset: a7c341f30747 Author:sherman Date: 2013-08-09 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7c341f30747 8020054: (tz) Support tzdata2013d Summary: update the jdk8 tz data to version 2013d Reviewed-by: coffeys, peytoia ! make/sun/javazic/tzdata/VERSION ! mak

Re: RFR 8014824: Document Spliterator characteristics and binding policy of java util collection impls

On Aug 9 2013, at 06:04 , Paul Sandoz wrote: > Hi Peter, > > On Aug 8, 2013, at 12:44 PM, Peter Levart wrote: > >> Hi Paul, >> >> Shouldn't Spliterators.EmptySpliterator also be IMMUTABLE, DISTINCT and >> ORDERED? Like Collections.singletonSpliterator... >> > > Perhaps, for consistency. II

hg: jdk8/tl/jdk: 8021977: Opening a file using java.io can throw IOException on Windows

Changeset: 03822f2389bf Author:dxu Date: 2013-08-09 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/03822f2389bf 8021977: Opening a file using java.io can throw IOException on Windows Summary: Remove IOException related error-handling code for backward compatibility Rev

RFR 8022259 MakeClasslist tool is buggy and its README is out of date.

Hi, Please review this small fix for bug 8022259. This change fixes a bug in the MakeClasslist tool and updates its README.txt file. webrev: http://cr.openjdk.java.net/~hseigel/bug_8022259/ bug: http://bugs.sun.com/view_bug.do?bug_id=802

hg: jdk8/tl/jdk: 8022724: lint warnings in j.u.concurrent packages

Changeset: ce1c874903cb Author:dl Date: 2013-08-09 17:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce1c874903cb 8022724: lint warnings in j.u.concurrent packages Reviewed-by: chegar, lancea, darcy ! src/share/classes/java/util/concurrent/CompletableFuture.java ! src/sha

Re: RFR lint warnings in j.u.concurrent.**

Fine from me as well. On Aug 9 2013, at 09:51 , Joe Darcy wrote: > Agreed; looks good. > > Thanks, > > -Joe > > On 8/9/2013 8:27 AM, Lance Andersen - Oracle wrote: >> looks fine chris >> >> Best >> Lance >> On Aug 9, 2013, at 11:03 AM, Chris Hegarty wrote: >> >>> These changes address the re

Re: RFR: JDK-8021977 -- Open File Using Java.IO May Throw IOException On Windows

Thank you. I will use the updated synopsis for my pushtoday. -Dan On 08/09/2013 08:41 AM, mark.reinh...@oracle.com wrote: 2013/8/8 9:26 -0700, dan...@oracle.com: Webrev: http://cr.openjdk.java.net/~dxu/8021977/webrev.00/ Bug: http://bugs.sun.com/view_bug.do?bug_id=8021977 Looks good, but the

Re: RFR lint warnings in j.u.concurrent.**

Agreed; looks good. Thanks, -Joe On 8/9/2013 8:27 AM, Lance Andersen - Oracle wrote: looks fine chris Best Lance On Aug 9, 2013, at 11:03 AM, Chris Hegarty wrote: These changes address the remaining lint warnings in the j.u.concurrent.** package(s). The changes are already in the JSR166 C

Re: RFR [8022584] Memory leak in some NetworkInterface methods

On the regression testcase theme, it got me thinking as to whether we've any java APIs which can query what the native heap usage of the JVM. Is that available over JMX ? I tried the MBeanServer approach but didn't get the expected results. Queried the "NonHeapMemoryUsage" object. something

Re: class SplittableRandom

On 08/09/13 11:43, Aleksey Shipilev wrote: On 08/09/2013 04:29 PM, Doug Lea wrote: Currently at: http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/SplittableRandom.java?view=log Looks good. Stupid questions below: * Why use InetAddress.getLocalHost() for the initial seed

Re: class SplittableRandom

On 08/09/2013 04:29 PM, Doug Lea wrote: > Currently at: > http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/SplittableRandom.java?view=log Looks good. Stupid questions below: * Why use InetAddress.getLocalHost() for the initial seed? I understand you don't want to use Secure

Re: RFR: JDK-8021977 -- Open File Using Java.IO May Throw IOException On Windows

2013/8/8 9:26 -0700, dan...@oracle.com: > Webrev: http://cr.openjdk.java.net/~dxu/8021977/webrev.00/ > Bug: http://bugs.sun.com/view_bug.do?bug_id=8021977 Looks good, but the synopsis is rather horrid ("Java.IO"?). Please use the updated synopsis I just pasted into the bug report: "Opening a file

Re: RFR: JAXP in JDK8/7u40 : 8022548 : SPECJVM2008 has errors introduced in 7u40-b34

Thanks Lance and Chris for the quick review! Joe On 8/9/2013 6:51 AM, Chris Hegarty wrote: On 09/08/2013 11:36, Lance Andersen - Oracle wrote: Hi Joe, The changes look fine +1 Looks ok to me. Pitty we have to maintain this kind of usage! -Chris. Best Lance On Aug 9, 2013, at 1:57 AM, hu

Re: RFR: JDK-8021977 -- Open File Using Java.IO May Throw IOException On Windows

Looks OK Dan Best Lance On Aug 8, 2013, at 7:26 PM, Dan Xu wrote: > Hi All, > > Please review a simple bug fix for JDK8021977. For the backward > compatibility, I have to remove the code that might throw out IOExceptionin > the native side. The issue has never been reported.But it exists in a

Re: RFR lint warnings in j.u.concurrent.**

looks fine chris Best Lance On Aug 9, 2013, at 11:03 AM, Chris Hegarty wrote: > These changes address the remaining lint warnings in the j.u.concurrent.** > package(s). > > The changes are already in the JSR166 CVS, this is a request to bring them > into jdk8. > > diff -r 84004d0e3fdd > src/

Re: RFR [6961766]: PrintStream.write() should flush at most once

Hello David! On 08.08.2013 6:18, David Holmes wrote: Hi Ivan, On 8/08/2013 3:53 AM, Ivan Gerasimov wrote: Hello David! Thanks for review. Yes - this is NOT A BUG this is the spec for this class: "Optionally, a PrintStream can be created so as to flush automatically; this means that the flu

RFR lint warnings in j.u.concurrent.**

These changes address the remaining lint warnings in the j.u.concurrent.** package(s). The changes are already in the JSR166 CVS, this is a request to bring them into jdk8. diff -r 84004d0e3fdd src/share/classes/java/util/concurrent/CompletableFuture.java --- a/src/share/classes/java/util/co

Re: RFR: JAXP in JDK8/7u40 : 8022548 : SPECJVM2008 has errors introduced in 7u40-b34

On 09/08/2013 11:36, Lance Andersen - Oracle wrote: Hi Joe, The changes look fine +1 Looks ok to me. Pitty we have to maintain this kind of usage! -Chris. Best Lance On Aug 9, 2013, at 1:57 AM, huizhe wang wrote: Hi, The root cause of this issue is that SPECJVM2008 uses a 3rd party pars

Re: RFR 8014824: Document Spliterator characteristics and binding policy of java util collection impls

Hi Peter, On Aug 8, 2013, at 12:44 PM, Peter Levart wrote: > Hi Paul, > > Shouldn't Spliterators.EmptySpliterator also be IMMUTABLE, DISTINCT and > ORDERED? Like Collections.singletonSpliterator... > Perhaps, for consistency. IIRC at the time it was felt a little odd to declare such charact

hg: jdk8/tl/jdk: 8022661: InetAddress.writeObject() performs flush() on object output stream

Changeset: 84004d0e3fdd Author:chegar Date: 2013-08-09 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84004d0e3fdd 8022661: InetAddress.writeObject() performs flush() on object output stream Reviewed-by: michaelm, alanb ! src/share/classes/java/net/InetAddress.java

Re: Classes on the stack trace

On 07/31/2013 03:18 PM, Nick Williams wrote: Okay, but I don't think @CallerSensitive is necessary to prevent MethodHandles from spoofing caller classes. I'll admit I don't know very much about MethodHandle, what it does, or how its invocation methods are different from Method.invoke(). In the

Re: class SplittableRandom

After exploring a bunch of algorithmic variants, we committed to one of the simplest for consideration for inclusion in JDK8. Thanks again to everyone sending comments and suggestions that led us to investigate alternatives. The API is unchanged. While we cannot exhaustively quality-check all p

Re: RFR [8022584] Memory leak in some NetworkInterface methods

Hi Chris, On 9/08/2013 8:36 PM, Chris Hegarty wrote: Firstly, I think the memory leak issue should be moved forward separately to this cleanup effort. They are unrelated, and I'm starting to get the feeling that this could take some time to reach conclusion. It seems reasonable to separate the i

Re: RFR: JAXP in JDK8/7u40 : 8022548 : SPECJVM2008 has errors introduced in 7u40-b34

Hi Joe, The changes look fine Best Lance On Aug 9, 2013, at 1:57 AM, huizhe wang wrote: > Hi, > > The root cause of this issue is that SPECJVM2008 uses a 3rd party parser XOM > 1.1 to convert the output to its canonical form. The XOM parser directly > references to the JDK parser implementati

Re: RFR [8022584] Memory leak in some NetworkInterface methods

Firstly, I think the memory leak issue should be moved forward separately to this cleanup effort. They are unrelated, and I'm starting to get the feeling that this could take some time to reach conclusion. It seems reasonable to separate the issues. On 09/08/2013 10:27, Ivan Gerasimov wrote:

hg: jdk8/tl/jdk: 8022326: Spliterator for values of j.u.c.ConcurrentSkipListMap does not report ORDERED

Changeset: c29ca19cb816 Author:psandoz Date: 2013-08-09 11:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c29ca19cb816 8022326: Spliterator for values of j.u.c.ConcurrentSkipListMap does not report ORDERED Reviewed-by: martin, chegar ! src/share/classes/java/util/TreeMap

Re: RFR [8022584] Memory leak in some NetworkInterface methods

Chris, I would use this if ((name_utf = (*env)->GetStringUTFChars(env, name, &isCopy)) == NULL) { JNU_ThrowOutOfMemoryError(env, "GetStringUTFChars failed"); return NULL/JNI_False/-1; } If I understand it correctly, JNU_ThrowOutOfMemoryError throws an exception only if it hasn't been a

Re: RFR JDK-8020054: (tz) Support tzdata2013d

Looks fine to me also Sherman. On a side note, we should look at migrating some closed TZ tests to open repo. I'm not sure why that wasn't done from first day. regards, Sean. On 09/08/2013 08:20, Yuka Kamiya wrote: Hi Sherman, The fix looks good to me. Thanks, -- Yuka (2013/08/09 14:54),

Re: RFR [8022584] Memory leak in some NetworkInterface methods

On 09/08/2013 06:47, David Holmes wrote: Sorry I messed this up. The JNI book says GetStringUTFChars will return NULL and post OOME but the JNI spec (latest version 6.0) does not - it only says it will return NULL on failure. This is indeed strange. Most usages of this function in the jdk expec

Re: RFR JDK-8020054: (tz) Support tzdata2013d

Hi Sherman, The fix looks good to me. Thanks, -- Yuka (2013/08/09 14:54), Xueming Shen wrote: Hi, Please help review the proposed change to update the tz data in JDK8 from 2013c to 2013d. http://cr.openjdk.java.net/~sherman/8020054/webrev http://cr.openjdk.java.net/~sherman/8020054/closed

hg: jdk8/tl/jdk: 6614237: missing codepage Cp290 at java runtime

Changeset: 54f0ccdd9ad7 Author:sherman Date: 2013-08-08 23:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/54f0ccdd9ad7 6614237: missing codepage Cp290 at java runtime Summary: to add charset Cp290 and Cp300 Reviewed-by: okutsu + make/tools/CharsetMapping/IBM290.c2b + make