Thomas,
Are we still waiting for a second core-libs reviewer on this?
David
On 17/05/2013 5:56 PM, Thomas Schatzl wrote:
On Fri, 2013-05-17 at 10:47 +1000, David Holmes wrote:
On 16/05/2013 8:44 PM, Thomas Schatzl wrote:
On Mon, 2013-05-13 at 13:55 +0200, Thomas Schatzl wrote:
I updated
On 22/05/2013 2:51 AM, Jason Mehrens wrote:
Aleksej,
Actually, the readObject calls the super.initCause, because there is no
initCause in XPathException.
I would think that subclasses of XPE will see calls to this.initCause from
readObject. That wouldn't have happened prior to this change.
Hi Dan & All,
I have updated the test based on your comments, Can you please review
the fix? Thanks!
http://cr.openjdk.java.net/~ewang/8009258/webrev.02/
Regards,
Eric
On 2013/4/17 14:36, Dan Xu wrote:
Hi Eric,
Thanks for fixing the test failures. I recently reviewed your changes.
And I lik
Hi Petr,
Sorry for the delay, I somehow missed this one.
I don't understand objective-c, if Mr Petrov is happy I am ok with it.
There seems to be indenting issues 1049-1051
Is there a regression test for this somewhere ?
Thanks
Kumar
Hello,
Yes; Kumar should be one of the reviewers here.
On 24/05/2013 2:48 AM, Aleksey Shipilev wrote:
Also, let's wait for David Holmes to glance over it. He has the immense
capability to spot the weaknesses in the specifications.
Wow talk about pressure! Now I'm obligated to find a weakness. ;-)
Luckily Mike and Peter already touched on a few thi
Hello.
Implementing some RB-tree I found out that
a lot of the null checks from CLR code
could be removed from balancing operations.
Looking at TreeBin
(http://cr.openjdk.java.net/~bchristi/8005698/webrev.01/)
I found some places where such checks could also be removed.
In putTreeNode(...)
On 22/05/2013 21:30, Kumar Srinivasan wrote:
Hello,
Please review trivial fix where the launcher did not parse multiple
back-slashes
correctly. I also added some additional test contributed by Jim Holmlund.
http://cr.openjdk.java.net/~ksrini/8007333/webrev.0/
Thanks
Kumar
This looks okay t
Thank you for having a look, Doug.
Comments inline...
On 5/23/13 5:20 AM, Doug Lea wrote:
* Given that balanced trees are not used in WeakHashMap
or Hashtable, I wonder why the TreeNode etc classes are
not just nested inside HashMap (usable from subclass LinkedHashMap).
And if so, it would be s
Oh yes, the tag on the class-level annotation has no effect.
-Aleksey.
On 05/23/2013 09:37 PM, Peter Levart wrote:
> Hi Aleksey,
>
> What's not very clear is whether the class-level @Contended is the same
> as class-level @Contended("group") - is the tag used or ignored when
> specified on the c
Hi Aleksey,
What's not very clear is whether the class-level @Contended is the same
as class-level @Contended("group") - is the tag used or ignored when
specified on the class-level. What does the following do?
@Contended("x")
class C {
@Contended("x") int a;
@Contended("y") int b;
i
Changeset: 3b23e3529ab3
Author:dl
Date: 2013-05-23 18:34 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b23e3529ab3
8014076: Arrays parallel and serial sorting improvements
Reviewed-by: chegar, mduigou
! src/share/classes/java/util/Arrays.java
! src/share/classes/java/util/
This is a good improvement. I agree that David Holmes is your possible best
reviewer. :-)
Mike
On May 23 2013, at 09:47 , Aleksey Shipilev wrote:
> Ummm... I think that's exactly what the last paragraph says. What if we
> rephrase it as follows?
>
> - 8< ---
On 05/11/2013 12:46 AM, Mike Duigou wrote:
On May 10 2013, at 07:14 , Chris Hegarty wrote:
Updated webrev and specdiff.
http://cr.openjdk.java.net/~chegar/8014076/ver.01/specdiff/java/util/Arrays.html
Docs changes look fine to me.
http://cr.openjdk.java.net/~chegar/8014076/ver.01/webrev
Also, let's wait for David Holmes to glance over it. He has the immense
capability to spot the weaknesses in the specifications.
-Aleksey.
On 05/23/2013 08:47 PM, Aleksey Shipilev wrote:
> Ummm... I think that's exactly what the last paragraph says. What if we
> rephrase it as follows?
>
> -
Ummm... I think that's exactly what the last paragraph says. What if we
rephrase it as follows?
- 8< ---
When the annotation is used at the class level, the effect is
roughly equivalent to placing the {@code @Contended} annotation
with the an
On 05/23/2013 06:33 PM, Mike Duigou wrote:
> A class level annotation on a class containing no annotated fields
> has no effect, correct?
It does have the effect, see the last paragraph in the Javadoc. Should
we refine this a bit?
-Aleksey.
You could add one more sentence to cover the effect of @C on class with no @C
on any field. The response to Peter is great info (but too much detail for
JavaDoc).
Mike
On May 23 2013, at 09:17 , Aleksey Shipilev wrote:
> On 05/23/2013 06:33 PM, Mike Duigou wrote:
>> A class level annotation on
On 05/23/2013 07:57 PM, Peter Levart wrote:
> Have I understood this correctly?
Yes. @Contended on class is currently the shorthand for the @Contended
with the same (but unknown) tag over all the fields. However, in future
this might change, because @Contended on class might also guard the
object
So where do we stand on this?
Can we call it a bug and eligible for inclusion?
And are there other issues to deal with?
I would be happy to discuss exactly what is going on in the mysterious
intrinsic-ful code, if that is an issue for anyone (and sooner is better than
later, else I'll forget the e
On 05/23/2013 04:33 PM, Mike Duigou wrote:
Looks good. If you haven't found someone to push it by tomorrow then I can. (I
am travelling today).
A class level annotation on a class containing no annotated fields has no
effect, correct?
Hi Mike,
As far as I understand the javadoc, it means t
Please help to review:
More tests for 7184826: (reflect) Add support for Project Lambda
concepts in core reflection
This includes:
1. improvement for existing tests with more situations
2. Test for invoking interface default/static method by j.l.r.Method
3. Test for invoking interface default/
Hello Thomas,
There are long standing bugs in this area, it all depends what arguments
are being
passed with Unicode code pages. This is somewhat a convoluted, as the
JNI invocation
APIs are not Unicode friendly. Also we have a common code base for
shared launcher
logic between the *nixes an
Looks good. If you haven't found someone to push it by tomorrow then I can. (I
am travelling today).
A class level annotation on a class containing no annotated fields has no
effect, correct?
Mike
On May 23 2013, at 02:51 , Aleksey Shipilev wrote:
> On 05/21/2013 04:35 PM, Aleksey Shipilev wr
I've observed issues with passing non-ASCII characters through the command
line to a Java program on Windows. It seems that even though I can invoke
java.exe through CreateProcess, passing a full range of Unicode characters, and
even though the Java main accepts strings of Unicode characters,
Changeset: 0da6485cf656
Author:nloodin
Date: 2013-05-23 15:50 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0da6485cf656
8014048: Online user guide of jconsole points incorrect link
Reviewed-by: mchung, sla, jbachorik
! src/share/classes/sun/tools/jconsole/AboutDialog.java
Changeset: 833a9a584b64
Author:attila
Date: 2013-05-21 13:40 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/833a9a584b64
8014953: Have NativeJavaPackage throw a ClassNotFoundException when invoked
Reviewed-by: jlaskey, sundar
! src/jdk/nashorn/internal/runtime/NativeJava
Sorry that it has taken me a while to take a look at this.
Here are some initial comments/questions:
* Given that balanced trees are not used in WeakHashMap
or Hashtable, I wonder why the TreeNode etc classes are
not just nested inside HashMap (usable from subclass LinkedHashMap).
And if so, it
On 05/21/2013 04:35 PM, Aleksey Shipilev wrote:
> Hi,
>
> It is time to add the proper Javadoc to @Contended:
> http://cr.openjdk.java.net/~shade/8014966/webrev.01/
>
> Testing:
> - built jdk8-tl on Linux x86_64/release without a hitch.
>
> Please review and sponsor!
Friendly reminder.
-Al
Hi Alan,
The era of 32 is over in Apple world. Seems that is the time switching
to x64 everywhere. "640K ought to be enough for anybody ". The problem
is in program up-time. If we are discussing about GUI application,
0x is infinity. But from a service point of view it is not so
cle
29 matches
Mail list logo
