Re: Review needed: 8004374 : Fwd: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-09 Thread Frank Ding
Hi Lance, The code refactory looks good. By the way, the newly added unit test is not jtreg test case? Best regards, Frank On 12/5/2012 4:38 AM, Lance Andersen - Oracle wrote: All, Attached is the patch for: 8004374 based off the issue that Frank reported. for http://cr.openjdk.java.

code review request : 8003147 port fix for BCEL bug 39695

2012-12-09 Thread David Buck
Hi! I would like to request a code review of my JDK8 fix for the following issue: [ 8003147 : port fix for BCEL bug 39695 to our copy bundled as part of jaxp ] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003147 In addition to the fix that the BCEL project had for this issue, I need

Re: bottleneck by java.lang.Class.getAnnotations() - rebased patch

2012-12-09 Thread David Holmes
Hi Peter, Sorry for the delay on this. Generally your VolatileData and my ReflectionHelper are doing a similar job. But I agree with your reasoning that all of the cached SoftReferences are likely to be cleared at once, and so a SoftReference to a helper object with direct references, is more

Re: Proposal: Fully Concurrent ClassLoading

2012-12-09 Thread David Holmes
Thanks for the comments Mandy. On 8/12/2012 9:46 AM, Mandy Chung wrote: On 12/5/12 3:59 AM, David Holmes wrote: Java 7 introduced support for parallel classloading by adding to each class loader a ConcurrentHashMap, referenced through a new field, parallelLockMap. This contains a mapping from

Re: Proposal: Fully Concurrent ClassLoading

2012-12-09 Thread David Holmes
Hi David, On 7/12/2012 1:06 AM, David M. Lloyd wrote: On 12/06/2012 05:35 AM, Alan Bateman wrote: On 05/12/2012 11:59, David Holmes wrote: Java 7 introduced support for parallel classloading by adding to each class loader a ConcurrentHashMap, referenced through a new field, parallelLockMap. Th

Re: Proposal: Fully Concurrent ClassLoading

2012-12-09 Thread David Holmes
Hi Peter, I think your middle-ground sounds like it may have been a better choice for JDK 7. But for this proposal I want to try and leave parallel loaders behind and move to the fully concurrent model. The real crux of my proposal is how often you really do get concurrent load attempts and

Re: Proposal: Fully Concurrent ClassLoading

2012-12-09 Thread David Holmes
On 6/12/2012 9:35 PM, Alan Bateman wrote: On 05/12/2012 11:59, David Holmes wrote: Java 7 introduced support for parallel classloading by adding to each class loader a ConcurrentHashMap, referenced through a new field, parallelLockMap. This contains a mapping from class names to Objects to use a

hg: jdk8/tl/jdk: 8000983: Support narrow display names for calendar fields; ...

2012-12-09 Thread masayoshi . okutsu
Changeset: fda257689786 Author:okutsu Date: 2012-12-10 10:52 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fda257689786 8000983: Support narrow display names for calendar fields 8003267: Support generic time zone names in TimeZoneNameProvider (SPI) Reviewed-by: naoto ! make

hg: jdk8/tl/jdk: 7194370: (fs) WatchService fails if volume S/N is 0 [win]

2012-12-09 Thread alan . bateman
Changeset: 343615aa0539 Author:dxu Date: 2012-12-09 19:13 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/343615aa0539 7194370: (fs) WatchService fails if volume S/N is 0 [win] Reviewed-by: alanb, forax ! src/windows/classes/sun/nio/fs/WindowsFileAttributes.java

hg: jdk8/tl/jdk: 8004042: Arrrghs.java test failed on windows with access error.

2012-12-09 Thread kumar . x . srinivasan
Changeset: da387f0cecb7 Author:ksrini Date: 2012-12-09 07:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da387f0cecb7 8004042: Arrrghs.java test failed on windows with access error. Reviewed-by: smarks, jjh, ksrini Contributed-by: [email protected] ! test/tools/lau