Re: bottleneck by java.lang.Class.getAnnotations() - rebased patch

2012-12-02 Thread Peter Levart
Hi David, Alan, Alexander and others, In the meanwhile I have added another annotations space optimization to the patch. If a Class doesn't inherit any annotations from a superclass, which I think is a common case, it assigns the same Map instance to "annotations" as well as "declaredAnnotatio

Re: Request for review (XXS): JDK-8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message

2012-12-02 Thread David Holmes
Hi Kris, On 3/12/2012 4:37 PM, Krystal Mo wrote: On 12/03/2012 08:47 AM, David Holmes wrote: On 3/12/2012 5:36 AM, Krystal Mo wrote: Hi Alan and core-libs-dev, Thanks for the review. I've taken your advise and updated the webrev: http://cr.openjdk.java.net/~kmo/8004066/webrev.00/ Could you p

Re: Request for review (XXS): JDK-8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message

2012-12-02 Thread Krystal Mo
Hi David, On 12/03/2012 08:47 AM, David Holmes wrote: On 3/12/2012 5:36 AM, Krystal Mo wrote: Hi Alan and core-libs-dev, Thanks for the review. I've taken your advise and updated the webrev: http://cr.openjdk.java.net/~kmo/8004066/webrev.00/ Could you please review the updated version? If y

Re: Review Request: 8004201: add reducers to primitive type wrappers

2012-12-02 Thread David Holmes
Hi Akhil, Is it really necessary/desirable to flag all of these as " Suitable for conversion as a method reference to functional interfaces such as ..." ? This style: + * @param a a boolean argument. + * @param b another boolean argument. is at odds with the style used elsewh

Profiles update to jdk8-b65

2012-12-02 Thread David Holmes
Just FYI the Profiles forest has been updated to the jdk8-b65 level. I hope to catch up to b66 this week. There is no new functionality here. The builds are still officially limited to linux only and I will soon add a check for that to allow this to be merged with the mainline repos. David -

Re: bottleneck by java.lang.Class.getAnnotations() - rebased patch

2012-12-02 Thread David Holmes
On 1/12/2012 4:54 AM, Alan Bateman wrote: On 30/11/2012 18:36, Peter Levart wrote: : So, what do you think? What kind of tests should I prepare in addidion to those 3 so that the patch might get a consideration? I think this is good work and thanks for re-basing your patch. I know David plans

Re: Request for review (XXS): JDK-8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message

2012-12-02 Thread David Holmes
On 3/12/2012 5:36 AM, Krystal Mo wrote: Hi Alan and core-libs-dev, Thanks for the review. I've taken your advise and updated the webrev: http://cr.openjdk.java.net/~kmo/8004066/webrev.00/ Could you please review the updated version? If you no longer check the exception message then there's no

Re: RFR- 7200297 jdwp and hprof code do not handle multiple sun.boot.library.path elements correctly

2012-12-02 Thread David Holmes
On 1/12/2012 1:46 AM, BILL PITTORE wrote: Ok, Thanks. David Holmes asked that I send to this alias and he would re-review then push it for me. Yes I wanted a chance for TL folks to see it (Alan has). So re-Reviewed and pushed. Bill: note that I had to re-do the commit as you don't have jdk8

hg: jdk8/tl/jdk: 7200297: agent code does not handle multiple boot library path elements correctly

2012-12-02 Thread david . holmes
Changeset: 60550cd2b527 Author:dholmes Date: 2012-12-02 19:16 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60550cd2b527 7200297: agent code does not handle multiple boot library path elements correctly Summary: When bug 6819213 was fixed it enabled sun.boot.library.path pr

Re: Request for review (XXS): JDK-8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message

2012-12-02 Thread Krystal Mo
Hi Alan and core-libs-dev, Thanks for the review. I've taken your advise and updated the webrev: http://cr.openjdk.java.net/~kmo/8004066/webrev.00/ Could you please review the updated version? Also, could anybody from the JDK side sponsor this change, please? Thanks, Kris On 12/01/2012 11:54

hg: jdk8/tl/jdk: 8003846: Override mechanism for currency data should not require creating currency.properties in java.home

2012-12-02 Thread alan . bateman
Changeset: f657adf4fe78 Author:alanb Date: 2012-12-02 16:37 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f657adf4fe78 8003846: Override mechanism for currency data should not require creating currency.properties in java.home Reviewed-by: naoto ! src/share/classes/java/uti