Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Andrew Hughes
- Original Message - > On 14/08/2012 14:13, Andrew Hughes wrote: > > Can I take that as it's good to push? :-D > No objection from me although if the default is changed to > SYSTEM_ZLIB=true for Linux (and maybe Solaris) then it will require > making sure that it builds everywhere without n

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-14 Thread Naoto Sato
Thanks, Erik! I incorporated your build-infra changes into the main changeset, and created a new combined webrev as follows: http://cr.openjdk.java.net/~naoto/6336885/webrev.02/ Naoto On 8/13/12 11:40 PM, Erik Joelsson wrote: I finished making the changes yesterday, but didn't manage to get

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-14 Thread Naoto Sato
Hi David, We are planning to push the changes through T/L repos. Although I think it's unlikely that our changes and JSR 292 ones would interfere, it would be good to push them in a later promotion build. I will shoot for the next one after the "flag day." Naoto On 8/13/12 11:57 PM, David H

RFR: 7056731: Race condition in CORBA code causes re-use of ABORTed connections

2012-08-14 Thread Seán Coffey
I'm looking to forward port this corba fix from 6u34 to jdk8 (and eventually port to 7u) d.macdon...@auckland.ac.nz originally reported this issue and I'll be marking the fix as contributed by him. He's already signed the OCA. There's a good description in bug report. We have a race like condi

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Alan Bateman
On 14/08/2012 14:13, Andrew Hughes wrote: Can I take that as it's good to push? :-D No objection from me although if the default is changed to SYSTEM_ZLIB=true for Linux (and maybe Solaris) then it will require making sure that it builds everywhere without needing other options. -Alan.

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-14 Thread Jeff Dinkins
Andrew - good catch. We're reviewing. On Aug 14, 2012, at 2:51 AM, Andrew Hughes wrote: > - Original Message - >> Hello, >> >> Please review the JDK8 changes for JEP 127: Improve Locale Data >> Packaging and Adopt Unicode CLDR Data >> (http://openjdk.java.net/jeps/127). The webrev is lo

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Xueming Shen
Yes, you are good to go. Thanks! -Sherman On 8/14/2012 6:13 AM, Andrew Hughes wrote: - Original Message - On 14/08/2012 13:36, Andrew Hughes wrote: : Do you have a static libz.a installed (from zlib1g-dev) and all dependent static libraries? I think you're right about the static li

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Andrew Hughes
- Original Message - > On 14/08/2012 13:36, Andrew Hughes wrote: > > : > > > > Do you have a static libz.a installed (from zlib1g-dev) and all > > dependent static libraries? > I think you're right about the static linking but this was just a > quick > test to see if SYSTEM_ZLIB=true worked

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Alan Bateman
On 14/08/2012 13:36, Andrew Hughes wrote: : Do you have a static libz.a installed (from zlib1g-dev) and all dependent static libraries? I think you're right about the static linking but this was just a quick test to see if SYSTEM_ZLIB=true worked with everything else as default. pack200 has

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Andrew Hughes
- Original Message - > On 10/08/2012 18:40, Andrew Hughes wrote: > > - Original Message - > >> Hi Andrew > >> > >> Alan mentioned the other day that the build (with your latest > >> patch, > >> with zlib-dev) failed at pack200 > >> when he tried to turn it on on linux. Can your doub

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-14 Thread Andrew Hughes
- Original Message - > Hello, > > Please review the JDK8 changes for JEP 127: Improve Locale Data > Packaging and Adopt Unicode CLDR Data > (http://openjdk.java.net/jeps/127). The webrev is located at: > > http://cr.openjdk.java.net/~naoto/6336885/webrev.00/ > > The main bug id for this