Re: PATCH [6901992] : Possible InvalidJarIndexException due to bug in sun.misc.JarIndex.merge()

2012-06-12 Thread Diego Belfer
Hi, I have finally reproduced the InvalidJarIndexException bug as reported in the ticket. I mentioned in a previous email, that the only way I'd found for getting the error was to use an invalid index file (INDEX.LIST), which did not have any sense. That's because I was using jars containing "dire

hg: jdk8/tl/jdk: 7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag properly

2012-06-12 Thread lance . andersen
Changeset: 6b6a73e8c036 Author:lancea Date: 2012-06-12 17:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b6a73e8c036 7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag properly Reviewed-by: joehw ! src/share/classes/com/sun/rowset/internal/XmlReade

Re: Fwd: Review request CR 7171918 XmlReaderContentHandler.endElement does not handle a Delete Tag properly

2012-06-12 Thread Joe Wang
Looks good to me, Lance. Best, Joe On 6/12/2012 1:21 PM, Lance Andersen - Oracle wrote: Still looking for a reviewer on this. All SQE, unit tests, JCK and TCK tests pass. Best Lance Begin forwarded message: From: Lance Andersen - Oracle Date: May 25, 2012 3:56:41 PM EDT To: core-libs-dev

Fwd: Review request CR 7171918 XmlReaderContentHandler.endElement does not handle a Delete Tag properly

2012-06-12 Thread Lance Andersen - Oracle
Still looking for a reviewer on this. All SQE, unit tests, JCK and TCK tests pass. Best Lance Begin forwarded message: > From: Lance Andersen - Oracle > Date: May 25, 2012 3:56:41 PM EDT > To: core-libs-dev core-libs-dev > Subject: Review request CR 7171918 XmlReaderContentHandler.endElemen

Fwd: Review request for 7145913 CachedRowSetSwriter.insertNewRow() throws SQLException

2012-06-12 Thread Lance Andersen - Oracle
Still looking to push this change back but need a reviewer... All JCK, TCK, SQE and unit tests pass thank you in advance Best Lance Begin forwarded message: > From: Lance Andersen - Oracle > Date: June 5, 2012 10:15:36 AM EDT > To: core-libs-dev core-libs-dev > Subject: Fwd: Review request f

hashing and Bug 6932858

2012-06-12 Thread Jim Gish
I'm triaging all outstanding String bugs/RFEs. In light of Mike's recent changes to hashing, I'm seeking opinions on what should be done with bug # 6932858 -- "(str) Tune hashCode() of String". Although we can't change the specification for String.hashCode(), we would certainly be willing to

hg: jdk8/tl/jaxp: 7144423: StAX EventReader swallows the cause of error

2012-06-12 Thread huizhe . wang
Changeset: 0c7f86d9ff8b Author:joehw Date: 2012-06-12 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0c7f86d9ff8b 7144423: StAX EventReader swallows the cause of error Summary: make sure the cause of the error is properly reported Reviewed-by: lancea, psandoz ! src/co

Re: [7u6] RFR (JAXP) : 7144423: StAX EventReader swallows the cause of error

2012-06-12 Thread Joe Wang
Thanks Lance, Paul! Joe On 6/12/2012 5:48 AM, Lance Andersen - Oracle wrote: looks fine best lance On Jun 11, 2012, at 7:23 PM, Joe Wang wrote: Hi, This is patch to make sure the cause of the error is properly reported. It has been in jaxp since Feb. webrev: http://cr.openjdk.java.net/~

Re: specification for null handling in String, StringBuilder, etc.

2012-06-12 Thread Joe Darcy
On 6/12/2012 6:04 AM, Alan Bateman wrote: On 12/06/2012 06:40, David Holmes wrote: This is very, very common in the core libraries. Rather than document every single method where a null parameter triggers NPE they are often covered (directly or indirectly) by blanket statements of the form "

Re: specification for null handling in String, StringBuilder, etc.

2012-06-12 Thread Jim Gish
On 06/12/2012 01:40 AM, David Holmes wrote: Hi Jim, On 12/06/2012 7:59 AM, Jim Gish wrote: While triaging outstanding String bugs, I was looking at 4247235, "(spec str) StringBuffer.insert(int, char[]) specification is inconsistent" Although the description is out of date w.r.t. the current

Re: specification for null handling in String, StringBuilder, etc.

2012-06-12 Thread David Schlosnagle
On Tue, Jun 12, 2012 at 9:04 AM, Alan Bateman wrote: > On 12/06/2012 06:40, David Holmes wrote: >> >> >> This is very, very common in the core libraries. Rather than document >> every single method where a null parameter triggers NPE they are often >> covered (directly or indirectly) by blanket st

Re: specification for null handling in String, StringBuilder, etc.

2012-06-12 Thread Alan Bateman
On 12/06/2012 06:40, David Holmes wrote: This is very, very common in the core libraries. Rather than document every single method where a null parameter triggers NPE they are often covered (directly or indirectly) by blanket statements of the form "unless otherwise stated ...". Right, @throw

Re: [7u6] RFR (JAXP) : 7144423: StAX EventReader swallows the cause of error

2012-06-12 Thread Lance Andersen - Oracle
looks fine best lance On Jun 11, 2012, at 7:23 PM, Joe Wang wrote: > Hi, > > This is patch to make sure the cause of the error is properly reported. It > has been in jaxp since Feb. > > webrev: http://cr.openjdk.java.net/~joehw/7u6/7143711/webrev/ > > Please review. > > Thanks, > Joe Lanc

Re: specification for null handling in String, StringBuilder, etc.

2012-06-12 Thread Stephen Colebourne
> On 06/12/2012 07:40 AM, David Holmes wrote: >> On 12/06/2012 7:59 AM, Jim Gish wrote: >>> My personal feeling is that pre-conditions should be explicitly checked >>> for and be spec'd. >> >> This is very, very common in the core libraries. Rather than document >> every single method where a null

Re: [7u6] RFR (JAXP) : 7144423: StAX EventReader swallows the cause of error

2012-06-12 Thread Paul Sandoz
On Jun 12, 2012, at 1:23 AM, Joe Wang wrote: > Hi, > > This is patch to make sure the cause of the error is properly reported. It > has been in jaxp since Feb. > > webrev: http://cr.openjdk.java.net/~joehw/7u6/7143711/webrev/ > > Please review. > Looks OK to me. Paul.