Re: Re : review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

Jeff, On 1/06/2012 10:19 AM, Jeff Hain wrote: Hi. 185 public boolean waitFor(long timeout, TimeUnit unit) 186 throws InterruptedException { 187 long now = System.nanoTime(); 188 189 long end = now + 190 (timeout<= 0 ? 0 : TimeUnit.NANOSECONDS.convert(time

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

Hi Rob, This looks good to me. I'm glad to see that destroyForcibly mandates that Process instances from ProcessBuilder.start and Runtime.exec must do a forcible destroy. That addresses my concern about documenting the actual implementations. Two minor comments: Process.java: 236 * {

Re : review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

Hi. > 185 public boolean waitFor(long timeout, TimeUnit unit) > 186 throws InterruptedException { > 187 long now = System.nanoTime(); > 188 > 189 long end = now + > 190 (timeout <= 0 ? 0 : TimeUnit.NANOSECONDS.convert(timeout, > unit)); > 191 

Re: Review request for 7145913 CachedRowSetSwriter.insertNewRow() throws SQLException

Here is the revision using the try with resources as David suggested http://cr.openjdk.java.net/~lancea/7145913/webrev.01/ Best Lance On May 31, 2012, at 3:10 PM, David Schlosnagle wrote: > On Thu, May 31, 2012 at 1:50 PM, Lance Andersen - Oracle > wrote: >> Hi, >> >> Looking for a reviewer fo

hg: jdk8/tl/jdk: 3 new changesets

Changeset: 0c6830e7241f Author:mullan Date: 2012-05-30 17:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c6830e7241f 6854712: Revocation checking enhancements (JEP-124) 6637288: Add OCSP support to PKIX CertPathBuilder implementation 7126011: ReverseBuilder.getMatchingCAC

Re: hg: jdk8/tl/jdk: 7126277: Alternative String hashing implementation

On 05/31/12 12:58, Mike Duigou wrote: So couldn't method hash(Object) be moved to AbstractMap? The differences in the avalanche (XOR scrambling) preclude this. It could be decided for Java 8 to use a consistent scrambling implementation. I would want to hear from Doug Lea whether he thinks this

Re: Review request for 7145913 CachedRowSetSwriter.insertNewRow() throws SQLException

Hi David, Thanks for the feedback On May 31, 2012, at 3:10 PM, David Schlosnagle wrote: > On Thu, May 31, 2012 at 1:50 PM, Lance Andersen - Oracle > wrote: >> Hi, >> >> Looking for a reviewer for 7145913. This addresses an issue with where a >> SQLException could be thrown when writing a row

Re: Review request for 7145913 CachedRowSetSwriter.insertNewRow() throws SQLException

On Thu, May 31, 2012 at 1:50 PM, Lance Andersen - Oracle wrote: > Hi, > > Looking for a reviewer for 7145913.  This addresses an issue with where a > SQLException could be thrown when writing a row back with an auto-incremented > column on some databases. > > Webrev is http://cr.openjdk.java.net

Review request for 7145913 CachedRowSetSwriter.insertNewRow() throws SQLException

Hi, Looking for a reviewer for 7145913. This addresses an issue with where a SQLException could be thrown when writing a row back with an auto-incremented column on some databases. Webrev is http://cr.openjdk.java.net/~lancea/7145913/webrev.00/. RowSet TCK, sqe tests and unit tests all pass

Re: hg: jdk8/tl/jdk: 7126277: Alternative String hashing implementation

On May 31 2012, at 01:40 , Ulf Zibis wrote: > Hi Mike, > > some more questions: > > public class Hashmap { > +int hash(Object k) { > +int h = hashSeed; > +if (k instanceof String) { > +return ((String) k).hash32(); > +} else { > +h ^= k.hashCode()

hg: jdk8/tl/langtools: 2 new changesets

Changeset: af6a4c24f4e3 Author:mcimadamore Date: 2012-05-31 17:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/af6a4c24f4e3 7166552: Inference: cleanup usage of Type.ForAll Summary: Remove hack to callback into type-inference from assignment context Reviewed-by: dlsmi

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

That link should be: http://cr.openjdk.java.net/~robm/4244896/webrev.04/ -Rob On 31/05/12 16:05, Rob McKenna wrote: Latest version including work on the spec language: http://cr.openjdk.java.net/~robm/4244896/webrev.04/ -Rob

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

Latest version including work on the spec language: http://cr.openjdk.java.net/~robm/4244896/webrev.04/ -Rob On 10/05/12 19:56, Rob McKenna wrote: Hi folks, The latest version is at: http://cr.openjdk.java.net/~robm/4244896/webrev

Re: hg: jdk8/tl/jdk: 7126277: Alternative String hashing implementation

Hi Mike, some more questions: public class Hashmap { +int hash(Object k) { +int h = hashSeed; +if (k instanceof String) { +return ((String) k).hash32(); +} else { +h ^= k.hashCode(); +} + +// This function ensures that hashCodes tha