Changeset: 7d683ab46571
Author:katleman
Date: 2012-02-23 12:03 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d683ab46571
Added tag jdk8-b27 for changeset c68342532e2e
! .hgtags
Changeset: 2152ac3e4575
Author:dl
Date: 2011-10-12 16:33 +0100
URL: http://hg.op
Changeset: 0ed0960af27d
Author:katleman
Date: 2012-02-23 12:03 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0ed0960af27d
Added tag jdk8-b27 for changeset 3b24e7e01d20
! .hgtags
Changeset: 6a2e8a833460
Author:katleman
Date: 2012-02-23 12:03 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6a2e8a833460
Added tag jdk8-b27 for changeset 38c037af4127
! .hgtags
Changeset: 4289a81ba085
Author:asaha
Date: 2012-02-14 10:22 -0800
URL: http://
Changeset: 8503479162bd
Author:katleman
Date: 2012-02-23 12:03 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8503479162bd
Added tag jdk8-b27 for changeset be456f9c64e8
! .hgtags
Changeset: 3b168225dfc0
Author:asaha
Date: 2012-02-14 10:29 -0800
URL: htt
Changeset: 38cc4c09b847
Author:katleman
Date: 2012-02-23 12:03 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/38cc4c09b847
Added tag jdk8-b27 for changeset 80c47eb83d24
! .hgtags
Changeset: 6fc515ab48c3
Author:asaha
Date: 2012-02-14 10:22 -0800
URL: http://h
Changeset: 97bb465be99d
Author:katleman
Date: 2012-02-23 12:03 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/97bb465be99d
Added tag jdk8-b27 for changeset 1533dfab9903
! .hgtags
Changeset: 9760a2114f51
Author:asaha
Date: 2012-02-14 10:21 -0800
URL: http://hg.ope
Changeset: 7bf4278af030
Author:katleman
Date: 2012-02-23 12:03 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7bf4278af030
Added tag jdk8-b27 for changeset 4fffe75e4edd
! .hgtags
Changeset: 66c7161ee588
Author:coffeys
Date: 2011-11-17 10:51 -0800
URL: http:
On 29/02/2012 10:29 AM, David Holmes wrote:
Hi Joe,
On 29/02/2012 3:03 AM, Joe Darcy wrote:
Belatedly catching up on email, please review the patch below to address
the issues you've raised. I searched for "method" and replaced it with
"executable" as appropriate throughout the javadoc of the c
Hi Mike,
On 29/02/2012 5:23 AM, Mike Duigou wrote:
On Feb 27 2012, at 20:50 , David Holmes wrote:
Hi Mike,
The problem with changing initialization order is that you can never enumerate
all the possible initialization paths. I don't see anything problematic with
the move in relation to Thr
Right, I remember this issue. In the email you referenced [1] Max said "I
remember we agreed on several rules" which were basically to use diamond if
it's an initializer at the point of declaration. I guess it depends on who "we"
are. I recall that discussion occurring with the security team (of
Hi Joe,
On 29/02/2012 3:03 AM, Joe Darcy wrote:
Belatedly catching up on email, please review the patch below to address
the issues you've raised. I searched for "method" and replaced it with
"executable" as appropriate throughout the javadoc of the class.
That substitution seems fine in the p
Mike,
I can certainly try to do that. Given how trivial the change is and the
somewhat obvious observation that Long.parseLong would avoid boxing
compared to Long.decode, I was simply pointing out a fairly easy change
that could be made in case the maintainers of this class simply haven't
looked
Hi Stuart,
Thanks for your comments. Regarding the use of diamonds, I remember
this issue coming up when i was
fixing networking warnings. See :
http://mail.openjdk.java.net/pipermail/net-dev/2011-September/003547.html
We had stuck to using diamond only when both declaration and assignment
Hi Kurchi,
I looked at the rest of the files. Pretty good, taking on diamond, multi-catch,
and try-with-resources as well!
I have several comments. Mostly nitpicks, but a few items worthy of some
discussion, but overall still minor changes, I think.
com/sun/rmi/rmid/ExecOptionPermission.ja
Changeset: b62922b54170
Author:darcy
Date: 2012-02-28 13:14 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b62922b54170
7149626: (reflect) Improve javadoc of java.lang.reflect.Executable
Reviewed-by: mduigou
! src/share/classes/java/lang/reflect/Executable.java
On Feb 27 2012, at 20:50 , David Holmes wrote:
> Hi Mike,
>
> The problem with changing initialization order is that you can never
> enumerate all the possible initialization paths. I don't see anything
> problematic with the move in relation to Thread.currentThread() or
> ThreadGroup.add().
On 2/28/2012 10:52 AM, Mike Duigou wrote:
These changes look good to me. Is there a new CR for the javadoc changes?
Thanks Mike; I was planning to file the bug after the reviews came in.
-Joe
Mike
On Feb 28 2012, at 09:03 , Joe Darcy wrote:
Hi David,
Belatedly catching up on email, plea
These changes look good to me. Is there a new CR for the javadoc changes?
Mike
On Feb 28 2012, at 09:03 , Joe Darcy wrote:
> Hi David,
>
> Belatedly catching up on email, please review the patch below to address the
> issues you've raised. I searched for "method" and replaced it with
> "exe
Changeset: 6b86f7274c0a
Author:jjg
Date: 2012-02-28 10:48 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6b86f7274c0a
7147183: test/tools/javac/apt.sh can be removed from tl/langtools repository
Reviewed-by: jjg
Contributed-by: sonali.g...@oracle.com
- test/tools/javac
Changeset: 62e611704863
Author:jjg
Date: 2012-02-28 10:33 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/62e611704863
7093891: support multiple task listeners
Reviewed-by: darcy, mcimadamore
! src/share/classes/com/sun/source/util/JavacTask.java
+ src/share/classes/com
The easiest wat to proceed would be for you to submit a webrev patch with both
changes along with your microbenchmark test. Once the change is incorporated in
the jdk8 mainline the sustaining teams can evaluate it for backporting to jdk 7
and 6.
Mike
On Feb 28 2012, at 06:26 , Vitaly Davidovic
Changeset: c4d6a8884ed8
Author:jjg
Date: 2012-02-28 10:25 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c4d6a8884ed8
7144951: fix minor javadoc issues
Reviewed-by: darcy
! src/share/classes/com/sun/source/tree/MemberReferenceTree.java
! src/share/classes/com/sun/tools
Hi David,
Belatedly catching up on email, please review the patch below to address
the issues you've raised. I searched for "method" and replaced it with
"executable" as appropriate throughout the javadoc of the class.
Thanks,
-Joe
--- a/src/share/classes/java/lang/reflect/Executable.java
On 28/02/2012 14:59, Pavel Tisnovsky wrote:
:
Hi Alan and Rémi,
thank you for review.
According to rules I've prepared webrew for JDK8
http://cr.openjdk.java.net/~ptisnovs/ScriptEngineManager_jdk8/
(changed texts are the same, but line numbers differ)
Pavel
PS: I have not a chance to push an
Alan Bateman wrote:
> On 28/02/2012 13:36, Pavel Tisnovsky wrote:
>> Hi,
>>
>> I'd like to fix three typos in ScriptEngineManager class's JavaDoc.
>> This class contains method getEngineFactories() which returns
>> list of factories, not an array of factories.
>>
>> Here is a webrew created against
Alan,
Sorry I should've stated that I looked at this in detail in java 6 but only
glanced at the UUID impl in 7 just now on my phone. If String.split() has
a fast path now then forget my suggestion #1 :). Using Long.parseLong
should still be applicable though.
Thanks
Sent from my phone
On Feb
On 28/02/2012 14:26, Vitaly Davidovich wrote:
Hi all,
I noticed that this method could be made a bit more performant by:
1) creating a statically initialized Pattern for "-" and then calling
split() on that. Currently the method calls name.split() which compiles
the pattern on each invocation.
Hi all,
I noticed that this method could be made a bit more performant by:
1) creating a statically initialized Pattern for "-" and then calling
split() on that. Currently the method calls name.split() which compiles
the pattern on each invocation.
2) use Long.parseLong() instead of Long.decode
On 02/28/2012 02:48 PM, Alan Bateman wrote:
On 28/02/2012 13:36, Pavel Tisnovsky wrote:
Hi,
I'd like to fix three typos in ScriptEngineManager class's JavaDoc.
This class contains method getEngineFactories() which returns
list of factories, not an array of factories.
Here is a webrew created a
On 28/02/2012 13:36, Pavel Tisnovsky wrote:
Hi,
I'd like to fix three typos in ScriptEngineManager class's JavaDoc.
This class contains method getEngineFactories() which returns
list of factories, not an array of factories.
Here is a webrew created against OpenJDK7:
http://cr.openjdk.java.net/
Hi,
I'd like to fix three typos in ScriptEngineManager class's JavaDoc.
This class contains method getEngineFactories() which returns
list of factories, not an array of factories.
Here is a webrew created against OpenJDK7:
http://cr.openjdk.java.net/~ptisnovs/ScriptEngineManager/
Can anybody re
31 matches
Mail list logo
