Re: JDK 8 code review request for initial unsigned integer arithmetic library support

On 20 January 2012 17:53, Ulf Zibis wrote: > Am 21.01.2012 01:35, schrieb Joseph Darcy: > >> On 1/19/2012 8:05 AM, Ulf Zibis wrote: >> >>> But again, moving the entire method to BigInteger would additionally >>> avoid to clown around with the available BigInteger's public APIs. Having >>> the met

hg: jdk8/tl/jdk: 4504839: Java libraries should provide support for unsigned integer arithmetic; ...

Changeset: 71200c517524 Author:darcy Date: 2012-01-20 17:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71200c517524 4504839: Java libraries should provide support for unsigned integer arithmetic 4215269: Some Integer.toHexString(int) results cannot be decoded back to an i

Re: JDK 8 code review request for initial unsigned integer arithmetic library support

Am 21.01.2012 01:35, schrieb Joseph Darcy: On 1/19/2012 8:05 AM, Ulf Zibis wrote: But again, moving the entire method to BigInteger would additionally avoid to clown around with the available BigInteger's public APIs. Having the method at BigInteger would allow elegant direct access to the priv

Re: JDK 8 code review request for initial unsigned integer arithmetic library support

Thanks for your feedback. Am 21.01.2012 01:31, schrieb Joseph Darcy: On 1/18/2012 7:52 PM, Ulf Zibis wrote: Am 18.01.2012 03:54, schrieb Joe Darcy: I've posted a revised webrev at http://cr.openjdk.java.net/~darcy/4504839.2 Instead '\u0030' you can use {@code '\u005Cu0030'} That i

Re: JDK 8 code review request for initial unsigned integer arithmetic library support

On 1/19/2012 8:05 AM, Ulf Zibis wrote: Am 19.01.2012 07:43, schrieb Eamonn McManus: Ulf Zibis writes: > What about: > private static final BigInteger BEYOND_UNSIGNED_LONG = BigInteger.valueOf(1).shiftLeft(64); > private static BigInteger toUnsignedBigInteger(long i) { > BigInteger resul

Re: JDK 8 code review request for initial unsigned integer arithmetic library support

On 1/18/2012 7:52 PM, Ulf Zibis wrote: Am 18.01.2012 03:54, schrieb Joe Darcy: I've posted a revised webrev at http://cr.openjdk.java.net/~darcy/4504839.2 Instead '\u0030' you can use {@code '\u005Cu0030'} That is a fine cleanup, but I'll do a bulk conversion of all the instances o

Re: JDK 8 code review request for initial unsigned integer arithmetic library support

Am 20.01.2012 16:12, schrieb Ulf Zibis: A little different approach... Instead e.g. int Byte.unsignedIntValueOf(byte x) aka int Byte.toUnsignedInt(byte x) I would vote for int Integer.unsignedValueOf(byte x) Alternative: int Integer.valueAsUnsigned(byte x) -Ulf

Re: Code review request for #6469160, #7088271

As a general comment, I find a seven-digit bug id in isolation extremely uninformative in terms of letting me know whether or not an issue is of interest to me. For the messages I send to the list, I always try to include the synopsis of the bugs in question in at least one of the subject lin

Code review request for #6469160, #7088271

Resending again... Hello core-libs. I was wondering of somebody could be please review the following fix for #6469160 and #7088271. The changes in the webrev fix both bugs. Information is below: Webrev URL: http://cr.openjdk.java.net/~bpassani/6469160_7088271/1/

Code Review Request for Bug #7129285

Please review this patch to fix Bug #7129285. This fix addresses comments made by Jason Mehrens to the commit of the fix for bug #4533691, including adding a Collections.emptyNavigableSet method. Tests are included. Webrev, can be found here: http://cr.openjdk.java.net/~dmocek/7129285/webre

Re: JDK 8 code review request for initial unsigned integer arithmetic library support

A little different approach... I worry about the wording of e.g. toUnsignedInt(x). At first look, it claims to return an unsigned integer, which fairly doesn't exist in Java for now. 1. Better: unsignedIntValueOf(x) 2. We could have a naming problem if unsigned integers were introduced in any fu