Hi Sean,
On 13/12/2011 5:21 PM, Sean Chou wrote:
When I was reading the code of AbstractCollection.toArray(T[] ), I
found its behavior maybe different from the spec in multithread
environment. The spec says "If the collection fits in the specified
array, it is returned therein. Otherwise, a new
Hi all,
When I was reading the code of AbstractCollection.toArray(T[] ), I
found its
behavior maybe different from the spec in multithread environment. The spec
says "If the collection fits in the specified array, it is returned
therein. Otherwise,
a new array is allocated with the runtime typ
Hi Fred,
A couple of minor comments on the JDK side:
HotSpotDiagnosticMXBean.java:
Sorry if this is old ground but a query on the API design: is there a
specific reason to use Lists rather than the arrays the VM will provide?
HotSpotDiagnostic.java:
139 public List getDiagnosticCommand
Thanks Sherman,
I have added the regression test for the case below and added a
"continue" statement after line 1622 to get the case to pass.
I have updated the webrev.
Steve.
On 12/12/2011 02:22 PM, Xueming Shen wrote:
Hi Steve,
The \x3[0-9] approach is interesting, it appears to solve th
Thanks Gary,
I have added the bug number to the tag and updated the webrev.
Steve.
On 12/12/2011 10:05 AM, Gary Adams wrote:
I think you want to add 6990617 to the @bug tag in RegExTest.
On 12/10/11 01:05 AM, Stephen Flores wrote:
Please review the following webrev (includes new test to demo
On 12/13/2011 11:02 AM, David Holmes wrote:
It seems that 7089443 is fixed as a by-product of your changes Charles
- provided getnameinfo does the right thing :)
David
--
On 13/12/2011 12:26 PM, Charles Lee wrote:
On 12/13/2011 06:50 AM, Darryl Mocek wrote:
Hello. Please review this patc
It seems that 7089443 is fixed as a by-product of your changes Charles -
provided getnameinfo does the right thing :)
David
--
On 13/12/2011 12:26 PM, Charles Lee wrote:
On 12/13/2011 06:50 AM, Darryl Mocek wrote:
Hello. Please review this patch to fix InetAddress.getLocalHost fails
if th
I tried once, and it was dropped because "the platform is not supported."
On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards wrote:
> On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote:
> > Hi,
> >
> >
> >I'm not sure what to do for it next, shall I create a bug for it
> > now ? But I
> > don't t
On 12/13/2011 06:50 AM, Darryl Mocek wrote:
Hello. Please review this patch to fix InetAddress.getLocalHost fails
if the host name is larger HOST_NAME_MAX. The fix is to use strncpy,
and supply the max length the host name can be, instead of using
strcpy. There is no test supplied for this f
Changeset: a482d45c93e9
Author:ohair
Date: 2011-12-12 08:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a482d45c93e9
7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac
Reviewed-by: alanb
! build.xml
Changeset: a49db7c01db7
Author:ohair
Date: 201
Changeset: 4822dfe0922b
Author:ohair
Date: 2011-12-12 08:15 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4822dfe0922b
7119829: Adjust default jprt testing configuration
Reviewed-by: alanb
! make/jprt.properties
Changeset: 6d622b1b4db0
Author:ohair
Date: 2011-12-12 08:13 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6d622b1b4db0
7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac
Reviewed-by: alanb
! build.xml
Changeset: 6d2030eacdac
Author:ohair
Date: 20
Changeset: 75529c21094f
Author:ohair
Date: 2011-12-12 08:15 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/75529c21094f
7119829: Adjust default jprt testing configuration
Reviewed-by: alanb
! make/jprt.properties
Changeset: 9acd7374ff8a
Author:ohair
Date: 2011-12-12 08:11 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/9acd7374ff8a
7119829: Adjust default jprt testing configuration
Reviewed-by: alanb
! make/jprt.properties
! test/Makefile
Changeset: 9c0a6185188f
Author:ohair
Date: 2011-12-12 08:17 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c0a6185188f
7119829: Adjust default jprt testing configuration
Reviewed-by: alanb
! make/jprt.properties
! test/Makefile
Hello. Please review this patch to fix InetAddress.getLocalHost fails
if the host name is larger HOST_NAME_MAX. The fix is to use strncpy,
and supply the max length the host name can be, instead of using
strcpy. There is no test supplied for this fix as I was unable to set
the host name larg
On 12/12/11 8:56 AM, Frederic Parain wrote:
Minor updates:
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.04/
src/share/vm/services/attachListener.cpp
The new include should be in alpha-order (between lines 36 & 37).
I'm pretty sure that's the new style...
Block comment
Hi Steve,
The \x3[0-9] approach is interesting, it appears to solve the problem
without
paying a higher cost I originally thought (looking back, for example).
The logic of initializing/setting/unsetting of "beginQuote" to
true/false appears to
be incorrect when there are multiple \Qn...\E in
On 12/12/2011 6:31 AM, Frederic Parain wrote:
http://cr.openjdk.java.net/~fparain/7104647/webrev.jdk.03/
The jdk change looks okay to me.
Mandy
Looks good.
Thanks,
Paul
On 12/12/11 10:56 AM, Frederic Parain wrote:
Minor updates:
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.04/
Fred
On 12/12/11 03:29 PM, Frederic Parain wrote:
Hi Paul,
Thank you for the review.
I've applied all your recommendations except the refactor
Minor updates:
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.04/
Fred
On 12/12/11 03:29 PM, Frederic Parain wrote:
Hi Paul,
Thank you for the review.
I've applied all your recommendations except the refactoring
in diagnosticCommandFramework.cpp (too few lines can be really
factore
On Dec 12, 2011, at 3:02 AM, Alan Bateman wrote:
> On 11/12/2011 21:48, Kelly O'Hair wrote:
>> Re-organized the testing targets, moved jdk_tools1 out of the default test
>> targets.
>>
>> Running "cd test&& make" should run the default test list, and should be
>> 100% pass, in theory.
>> (Not
I think you want to add 6990617 to the @bug tag in RegExTest.
On 12/10/11 01:05 AM, Stephen Flores wrote:
Please review the following webrev (includes new test to demonstrate the bug):
http://cr.openjdk.java.net/~sflores/6990617/
for bug: 6990617 Regular expression doesn't match if unicode
Hi Paul,
Thank you for the review.
I've applied all your recommendations except the refactoring
in diagnosticCommandFramework.cpp (too few lines can be really
factored out without passing many arguments).
New webrev is here:
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.03/
Regards
Hi Robert,
These issues should be solved with the new webrevs:
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.03/
http://cr.openjdk.java.net/~fparain/7104647/webrev.jdk.03/
Regards,
Fred
On 12/ 9/11 03:17 PM, Robert Ottenhag wrote:
Adding to the review of jmm.h, that is modified
On 12/12/2011 13:09, Neil Richards wrote:
:
As a matter of interest, can someone with suitable powers look into why
the bug mentioned above (7119285) is not publically viewable ?
Bug reports that are submitted to bugs.sun.com are initially treated as
"incidents" where they are filtered before m
On Fri, 2011-12-09 at 15:00 +0800, Sean Chou wrote:
> Hi all,
>
> I reported a bug(rrf) to request that OSInfo class recognizes AIX
> platform.
> As we know there are more platforms supporting java than platforms supported
> by openjdk. So I think OSInfo can add the feature to recognize these
Changeset: 3216717f96f5
Author:dl
Date: 2011-12-12 10:45 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3216717f96f5
7118066: Warnings in java.util.concurrent package
Reviewed-by: chegar, dholmes
! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java
! src/share/cl
Changeset: c508f38245f8
Author:ngmr
Date: 2011-12-12 11:41 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c508f38245f8
7118907: InetAddress.isReachable() should return false if sendto fails with
EHOSTUNREACH
Reviewed-by: alanb, chegar
Contributed-by: Charles Lee
! src/sola
On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote:
> Hi,
>
>
>I'm not sure what to do for it next, shall I create a bug for it
> now ? But I
> don't think the bug system support AIX platform. I remembered it
> would
> report something like "we are not supporting the platform".
>
Hi Sean,
On 11/12/2011 21:48, Kelly O'Hair wrote:
Re-organized the testing targets, moved jdk_tools1 out of the default test
targets.
Running "cd test&& make" should run the default test list, and should be 100%
pass, in theory.
(Note: Use of the jdk/test/Makefile utilizes jtreg with a default set of
On 09/12/2011 11:05, Doug Lea wrote:
On 12/08/11 23:16, David Holmes wrote:
Maybe we still need something that tests SynchronousQueue to verify
its iterator
is indeed empty.
Bear in mind that we have all the tck tests for j.u.c, that cover
such things. The JCK folks at Oracle regularly run t
32 matches
Mail list logo
