I split the patch as it would be better to divide the platform recognizing
in OSInfo class
and the system laf returned by UIManager. I sent the OSInfo part into
core-libs-dev
list. Here is the link:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-December/008638.html
On Tue, Dec 6, 201
Hi all,
I reported a bug(rrf) to request that OSInfo class recognizes AIX
platform.
As we know there are more platforms supporting java than platforms supported
by openjdk. So I think OSInfo can add the feature to recognize these
platforms.
This patch uses AIX as an example.
The bug link
On 8/12/2011 9:33 PM, Chris Hegarty wrote:
On 08/12/2011 05:13, David Holmes wrote:
I also think the SynchronousQueue has no business being used in this
test. Though I confess I'm unclear what this test is for - is it for
emptyIterator() or for "iterators of empty collections" ?
Thanks D
On 12/06/2011 10:29 PM, Mike Duigou wrote:
I have reviewed this patch and also run it against the java/util jtreg test. It
looks good to me.
Some comments:
Currency.java:
- The current mercurial source has one of your changes but the remaining two
changes, diamond and @SW are still valid.
Re
Changeset: 9bb7c3b97384
Author:smarks
Date: 2011-12-08 14:57 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bb7c3b97384
7118546: fix warnings in javax.xml.crypto, javax.script
Reviewed-by: mullan
! src/share/classes/javax/script/ScriptException.java
! src/share/classes/java
On Dec 8, 2011, at 1:55 AM, Florian Weimer wrote:
> * John Rose:
>
>> But, in order to respect the "general aim" you are mentioning, I have
>> unhoisted one of the two words from the Class instance itself. This
>> will cause a minor slowdown in JSR 292 use cases.
>
> What about using ClassValue
Changeset: f8897baf40ea
Author:omajid
Date: 2011-12-08 13:48 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8897baf40ea
7117612: Miscellaneous warnings in java.lang
Reviewed-by: smarks, dholmes, alanb, darcy
! src/share/classes/java/lang/Boolean.java
! src/share/classes/jav
On 12/08/2011 01:25 PM, Stuart Marks wrote:
On 12/8/11 8:25 AM, Omair Majid wrote:
On 12/7/11 3:13 PM, Omair Majid wrote:
You have commit rights, don't you? I'd say it's OK to proceed with the
push. Or, if you prefer, Alan should be online in just a couple hours,
and I'm sure he can give the fin
For the hotspot part at
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.00/
Most of my comments are style-related. Nice job on the implementation
architecture.
In attachListener.cpp:
You might want to delete the first "return JNI_OK;" line, since the code
under
HAS_PENDING_EXCEP
On 12/8/11 8:25 AM, Omair Majid wrote:
On 12/7/11 3:13 PM, Omair Majid wrote:
You have commit rights, don't you? I'd say it's OK to proceed with the
push. Or, if you prefer, Alan should be online in just a couple hours,
and I'm sure he can give the final go-ahead.
Yes, I do have commit rights a
On 12/08/2011 01:22 AM, Stuart Marks wrote:
On 12/7/11 3:13 PM, Omair Majid wrote:
On 12/07/2011 05:43 AM, Alan Bateman wrote:
I looked through the latest webrev. In
EnumConstantNotPresentException.java then the
@SuppressWarnings("rawtypes") should probably have a comment to explain
why it is n
On 08/12/2011 15:21, Mike Duigou wrote:
Was the SnychronousQueue test recently added or did something else change to
cause the failure?
This failure has not happened yet, but is will when I push the "warning"
changes for j.u.c ( with some minor impl changes ).
SynchronousQueue.iterator()
Was the SnychronousQueue test recently added or did something else change to
cause the failure?
Mike
On Dec 8 2011, at 03:33 , Chris Hegarty wrote:
> On 08/12/2011 05:13, David Holmes wrote:
>>
>>
>> I also think the SynchronousQueue has no business being used in this
>> test. Though I co
On 08/12/2011 05:13, David Holmes wrote:
I also think the SynchronousQueue has no business being used in this
test. Though I confess I'm unclear what this test is for - is it for
emptyIterator() or for "iterators of empty collections" ?
Thanks David, so the proposed change is to simple re
* John Rose:
> But, in order to respect the "general aim" you are mentioning, I have
> unhoisted one of the two words from the Class instance itself. This
> will cause a minor slowdown in JSR 292 use cases.
What about using ClassValue for the various caches instead?
enumConstants and enumConstan
On 08/12/2011 06:22, Stuart Marks wrote:
Hi Omair,
Everything looks good to me. I think Alan was lamenting that adding
the local variable for the sole purpose of adding the
@SuppressWarnings annotation makes the method appear longer and more
complex. The alternative is to put @SuppressWarnin
16 matches
Mail list logo
