On 12/7/11 3:13 PM, Omair Majid wrote:
On 12/07/2011 05:43 AM, Alan Bateman wrote:
I looked through the latest webrev. In
EnumConstantNotPresentException.java then the
@SuppressWarnings("rawtypes") should probably have a comment to explain
why it is needed. In ThreadLocal.get then it's a pity th
Chris,
On 7/12/2011 10:09 PM, Chris Hegarty wrote:
Thanks David and Doug,
So we should be ready to integrate this change, right? NO, not yet!
There is a failing regression test, java.util.Collections.EmptyIterator.
This test does a reference comparison ( '==' ) on the iterator returned
from an
On 12/07/2011 05:43 AM, Alan Bateman wrote:
On 05/12/2011 22:09, Omair Majid wrote:
I have posted a new webrev:
http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/03/
This includes all the changes from the feedback so far, as well as
changes to ThreadLocal.
I will not be posting a p
Changeset: abfa0d8ea803
Author:ksrini
Date: 2011-12-07 10:47 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abfa0d8ea803
7086015: fix test/tools/javac/parser/netbeans/JavacParserTest.java
Reviewed-by: ksrini, jjg
Contributed-by: matherey.nu...@oracle.com
! test/tools/j
On 12/7/2011 1:30 PM, Frederic Parain wrote:
The execute method doesn't throw any exception other than
IAE. What happens if the specified command execution fails
in the target VM? If no exception is thrown, how does the
caller detect if the command succeeds or not and handle it
gracefully? It
On 12/7/2011 2:04 PM, Mandy Chung wrote:
On 12/7/2011 1:30 PM, Frederic Parain wrote:
The execute method doesn't throw any exception other than
IAE. What happens if the specified command execution fails
in the target VM? If no exception is thrown, how does the
caller detect if the command suc
On 12/7/11 2:34 AM, Michael Barker wrote:
Michael - the Contributed-by line is usually the individual's name (+ mail
address) or a list of names (and their mail addresses). I think Stuart is
suggesting that this would be better than "London Java Community".
Okay, no problem:
Contributed-by: Pr
Changeset: 4f0f9f9c4892
Author:smarks
Date: 2011-12-07 12:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f0f9f9c4892
7117249: fix warnings in java.util.jar, .logging, .prefs, .zip
Reviewed-by: alanb, dholmes, forax, sherman, smarks
Contributed-by: Prasannaa , Martijn Verb
On 12/7/11 2:32 AM, Mandy Chung wrote:
On 12/2/2011 5:57 AM, Frederic Parain wrote:
http://cr.openjdk.java.net/~fparain/7104647/webrev.jdk.00/
L112: Since you are in this file, can you fix the typo
"java.security.SecurityException" to "java.lang.SecurityException"?
Fixed.
The execute met
This is just the start of a review: fumble-fingers sent it well before
it's time.
Paul
On 12/7/11 4:15 PM, Paul Hohensee wrote:
For the hotspot part:
In attachListener.cpp, you might want to delete the first "return
JNI_OK;"
line, since the code under HAS_PENDING_EXCEPTION just falls throug
On Dec 4, 2011, at 6:25 PM, David Holmes wrote:
>>> In the mean time, all the non-Groovy, non-JRuby, non-Nashorn, etc.
>>> uses of class Class and all the classes not visible in those
>>> environments when they are being used will be larger.
>>>
>>> Adding the fields may be the right time/space
For the hotspot part:
In attachListener.cpp, you might want to delete the first "return JNI_OK;"
line, since the code under HAS_PENDING_EXCEPTION just falls through.
In jmm.h, minor formatting nit: be nice to indent "(JNIEnv" on lines 318,
319 and 325 the same as the existing declarations. Add
Thanks David and Doug,
So we should be ready to integrate this change, right? NO, not yet!
There is a failing regression test, java.util.Collections.EmptyIterator.
This test does a reference comparison ( '==' ) on the iterator returned
from an empty SynchronousQueue and the iterator returned b
On 7/12/2011 9:12 PM, Martijn Verburg wrote:
Hi all,
Question on contributions, I assume that as the patch is coming from Mike,
his OCA covers the rest of us?
These patches are simple enough that OCA is not necessary - any
Participant can submit simple patches [1]
David
--
[1] http://o
Hi all,
Question on contributions, I assume that as the patch is coming from Mike,
his OCA covers the rest of us?
Cheers,
Martijn
On Wednesday, 7 December 2011, Alan Bateman wrote:
> On 07/12/2011 08:43, Michael Barker wrote:
>>
>> :
>>>
>>> 7117249: fix warnings in java.util.jar, .logging, .p
On 05/12/2011 22:09, Omair Majid wrote:
I have posted a new webrev:
http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/03/
This includes all the changes from the feedback so far, as well as
changes to ThreadLocal.
I will not be posting a patch for ClassValue since (as you kindly
p
On 07/12/2011 08:43, Michael Barker wrote:
:
7117249: fix warnings in java.util.jar, .logging, .prefs, .zip
Reviewed-by: alanb, dholmes, forax, sherman, smarks
Contributed-by: London Java Community and Michael Barker
Since the changeset comment is baked for all eternity, :-) I wanted to
17 matches
Mail list logo
