Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

On Aug 9, 2011, at 10:16 AM, Alexandre Boulgakov wrote: > I can change it back to LdapNamingEnumeration. I just thought it would be > more consistent with LdapBindingEnumeration and LdapSearchEnumeration. I did > not think of the back-porting issue. Would it be better to change > AbstractLd

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

I can change it back to LdapNamingEnumeration. I just thought it would be more consistent with LdapBindingEnumeration and LdapSearchEnumeration. I did not think of the back-porting issue. Would it be better to change AbstractLdapNamingEnumeration to LdapNamingEnumeration, as far as back-porting,

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

On 8/6/2011 2:11 AM, Alexandre Boulgakov wrote: > Here's the second version: > http://cr.openjdk.java.net/~mduigou/7072353/2/webrev/ > > > * Changed LdapResult.referrals to be a Vector>; > * Refactored > o com/sun/jndi/dns/DnsCont

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 0f1b4b3bc833 Author:mchung Date: 2011-08-08 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f1b4b3bc833 7036518: TEST_BUG: add cygwin support to test/java/nio/charset/coders/CheckSJISMappingProp.sh 7036519: TEST_BUG: add cygwin support to test/demo/zipfs/bas

Re: Review request: Test bugs to add cygwin support

Looks fine. -Joe On 8/8/2011 4:06 PM, Mandy Chung wrote: Sherman, Thanks. Can you review one more fix: 7012365: TEST_BUG: test/java/nio/charset/spi/basic.sh can be run with Cygwin Webrev at: http://cr.openjdk.java.net/~mchung/7012365/webrev.00/ Mandy On 8/8/11 3:16 PM, Xueming Shen wro

Re: Review request: Test bugs to add cygwin support

Sherman, Thanks. Can you review one more fix: 7012365: TEST_BUG: test/java/nio/charset/spi/basic.sh can be run with Cygwin Webrev at: http://cr.openjdk.java.net/~mchung/7012365/webrev.00/ Mandy On 8/8/11 3:16 PM, Xueming Shen wrote: Looks good. Thanks for fixing them. On 08/08/2011 02:37

Re: Review request: Test bugs to add cygwin support

Looks good. Thanks for fixing them. On 08/08/2011 02:37 PM, Mandy Chung wrote: > Simple fix on these tests to run on cygwin. > > 7036518: TEST_BUG: add cygwin support to > test/java/nio/charset/coders/CheckSJISMappingProp.sh > 7036519: TEST_BUG: add cygwin support to test/demo/zipfs/basic.sh > > W

Review request: Test bugs to add cygwin support

Simple fix on these tests to run on cygwin. 7036518: TEST_BUG: add cygwin support to test/java/nio/charset/coders/CheckSJISMappingProp.sh 7036519: TEST_BUG: add cygwin support to test/demo/zipfs/basic.sh Webrev at: http://cr.openjdk.java.net/~mchung/7036518/webrev.00/ Thanks Mandy

Re: JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

On Mon, Aug 8, 2011 at 4:57 PM, Sebastian Sickelmann wrote: > These ones are candidates for cleanup too, but i want to discuss if someone > sees a good argument to not to change to >    throw new InternalError(e.getMessage(),e); >    or >    throw new InternalError("Lorem ipsum",e); > > Also i don

Re: JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

I have picked my first Exception in this project. And unfortunatly i picked InternalError which seems to be used quite often. :-) I tried to change all initCause calls to the new Constructor and found many places where there is code like this: throw new InternalError(e.toString()); or

Re: Found 3 NullPointerExceptions

Yes it looks OK. I am in the process of figuring out what I need to do for including your contribution... I will be putting it back to openjdk8 first On Aug 8, 2011, at 4:28 PM, Patrick Reinhart wrote: > Hi Lance, > > I hope you got the time to look in my changes in the meantime: > > http:/

Re: JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Thanks for encouraging me. I opened a bug [1] at bugs.openjdk.java.net. Hope that is a right first step to getting started. I wanted to investigate the calls to initCause in jdk-source first to pick the most valueable Exceptions first. I thinks there are many exceptions out of scope of core-lib

Re: JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Hello. On 8/8/2011 7:24 AM, Sebastian Sickelmann wrote: Looks good to me. But i have one question: Why there are two ways to plumb the causes of an exception? The history of this situation is covered in older versions of the javadoc of Throwable: http://download.oracle.com/javase/6/doc

hg: jdk8/tl/jdk: 6380161: (reflect) Exception from newInstance() not chained to cause.

Changeset: d4ab25d65adb Author:darcy Date: 2011-08-08 09:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4ab25d65adb 6380161: (reflect) Exception from newInstance() not chained to cause. Reviewed-by: dholmes, lancea, forax ! src/share/classes/java/lang/Class.java

Re: JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

David, Lance, and Rémi, Thanks for the prompt reviews, -Joe Rémi Forax wrote: Agree, looks good. Rémi On 08/08/2011 03:41 PM, Lance Andersen - Oracle wrote: Looks fine to me Joe Best Lance On Aug 8, 2011, at 1:24 AM, Joe Darcy wrote: Hello. Please review this small fix, developed after

Re: Request for review: Make MethodHandleProxies.getSingleMethod() agnostic of ordering of methods returned from Class.getMethods()

Neil Richards wrote: : . Can I interest a core-libs committer in helping me to get this change committed? It might be better to have this come through mlvm-dev as that is where the JSR-292 work has been happening. -Alan.

Re: Iterable support for Enumeration

Sorry for the typo. I wanted to write.: Should we open a new discussion on this, or is meaningless to create better support for good old enumerations. Sebastian Sickelmann schrieb: >Hi, > >Maybe my mail [1] got lost in thread-history. But i think that Colin had >a good idea in [2]. >Should w

Re: JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Looks good to me. But i have one question: Why there are two ways to plumb the causes of an exception? In many exceptions-classes you can use a constuctor-level argument to specify the cause, and in some classes you must use the initCause method. Is it: "When you often need a caus

Iterable support for Enumeration

Hi, Maybe my mail [1] got lost in thread-history. But i think that Colin had a good idea in [2]. Should we open a new discussion on this, are is meaningless to create better support for good old enumerations. -Sebastian [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-August/00

Re: JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Agree, looks good. Rémi On 08/08/2011 03:41 PM, Lance Andersen - Oracle wrote: Looks fine to me Joe Best Lance On Aug 8, 2011, at 1:24 AM, Joe Darcy wrote: Hello. Please review this small fix, developed after I went through my open bug list; patch below, webrev at: 6380161 (reflect) Ex

Re: JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Looks fine to me Joe Best Lance On Aug 8, 2011, at 1:24 AM, Joe Darcy wrote: > Hello. > > Please review this small fix, developed after I went through my open bug > list; patch below, webrev at: > > 6380161 (reflect) Exception from newInstance() not chained to cause. > http://cr.openjdk.ja

hg: jdk8/tl/jdk: 7076215: (jli) jdk/src/share/bin/jli_util.h should include function prototypes for str functions

Changeset: 94934ebbb654 Author:alanb Date: 2011-08-08 13:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94934ebbb654 7076215: (jli) jdk/src/share/bin/jli_util.h should include function prototypes for str functions Reviewed-by: alanb Contributed-by: neil.richa...@ngmr.net

Re: Request for review: #include ANSI headers for functions referred to in jli_util.h

Neil Richards wrote: Hi, I've noticed that jdk/src/share/bin/jli_util.h does not currently include the ANSI headers for the functions that it #defines aliases for, which is not good practice. Please find below a suggested change which adds the necessary #include statements to correct this. Plea

Re: Help: ContextClassLoader in jtreg tests

David Holmes wrote: b) jtreg has explicitly changed the current thread's context classloader I don't jtreg does this but when running tests in -samevm or -agentvm mode then jtreg creates a class loader per test. It could be that some test is setting the current thread's context class loader an

Re: JDK 8 code review request for 7075098: Remove unused fdlibm files

Joe Darcy writes: > One of my long-term goals is to finish the > small matter of programming [2] to port FDLIBM from C to Java, which > would immunize the JDK from this class of problem. In case people are not aware, FastMath from Apache commons-math is a pure Java implementation: http://svn.a