hg: jdk7/tl/langtools: 7006178: findbugs high priority issues in new javadoc

2011-03-11 Thread bhavesh . patel
Changeset: b60754fe206d Author:bpatel Date: 2011-03-11 15:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b60754fe206d 7006178: findbugs high priority issues in new javadoc Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java !

Re: Code review request for 7026898 DriverManager to now use CopyOnWriteArrayList

2011-03-11 Thread David Schlosnagle
On Fri, Mar 11, 2011 at 3:03 PM, Lance Andersen - Oracle wrote: > I have posted the diffs to DriverManager for review at > http://cr.openjdk.java.net/~lancea/7026898/.  This change utilizes > CopyOnWriteArrayList instead of the Vectors previously used. Lance, Shouldn't the logSync lock field b

hg: jdk7/tl/langtools: 7026868: Apply specification changes fro 6505047

2011-03-11 Thread joe . darcy
Changeset: 46ed58a098ad Author:darcy Date: 2011-03-11 14:07 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/46ed58a098ad 7026868: Apply specification changes fro 6505047 Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax

Re: Review Request -- 5045147 : When TreeMap is empty explicitly check for null keys in put()

2011-03-11 Thread Alan Bateman
Mike Duigou wrote but nobody heard: This is a review request for an issue which was previously committed in 2006 but was quickly withdrawn because it was believed to cause a regression in other software. That removal was mistaken and this fix appears to be bona-fide beneficial. http://cr.open

Re: Code review request for 7026898 DriverManager to now use CopyOnWriteArrayList

2011-03-11 Thread Lance Andersen - Oracle
Hi Ulf, Thank you for the note. On Mar 11, 2011, at 3:18 PM, Ulf Zibis wrote: > Maybe you could update the javadoc style ( -> @code etc.) and move the > constructor to the begining. I need to go through all of the java.sql & javax.sql classes to address HTML issues over the coming weeks, I

Re: Code review request for 7026898 DriverManager to now use CopyOnWriteArrayList

2011-03-11 Thread Ulf Zibis
Maybe you could update the javadoc style ( -> @code etc.) and move the constructor to the begining. -Ulf Am 11.03.2011 21:03, schrieb Lance Andersen - Oracle: Hi, I have posted the diffs to DriverManager for review at http://cr.openjdk.java.net/~lancea/7026898/. This change utilizes CopyO

Code review request for 7026898 DriverManager to now use CopyOnWriteArrayList

2011-03-11 Thread Lance Andersen - Oracle
Hi, I have posted the diffs to DriverManager for review at http://cr.openjdk.java.net/~lancea/7026898/. This change utilizes CopyOnWriteArrayList instead of the Vectors previously used. Regards, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Enginee

hg: jdk7/tl/jdk: 7023613: (lc) Incorrect string returned by Locale.toString() with non-empty script field

2011-03-11 Thread naoto . sato
Changeset: 8216ad5fabb8 Author:naoto Date: 2011-03-11 11:31 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8216ad5fabb8 7023613: (lc) Incorrect string returned by Locale.toString() with non-empty script field Reviewed-by: srl ! src/share/classes/java/util/Locale.java ! test

core-dev Missing mails

2011-03-11 Thread Mike Duigou
(apologies to those on build-dev who also got this message in error) It appears that there was a transient problem with the openjdk email server earlier this week and that, as a result, some core-lib-dev emails were not sent to the subscriber list. Of interest to me are two review requests: "R

hg: jdk7/tl/jdk: 7023416: (pack200) fix parfait issues

2011-03-11 Thread kumar . x . srinivasan
Changeset: ed87479c96c2 Author:ksrini Date: 2011-03-11 10:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed87479c96c2 7023416: (pack200) fix parfait issues Reviewed-by: jrose ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp

hg: jdk7/tl/jdk: 7026346: URLConnection.guessContentTypeFromStream does not support UTF-8 and UTF-32 xml streams with BOM

2011-03-11 Thread chris . hegarty
Changeset: 107d55ecd50d Author:chegar Date: 2011-03-11 08:57 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/107d55ecd50d 7026346: URLConnection.guessContentTypeFromStream does not support UTF-8 and UTF-32 xml streams with BOM Reviewed-by: alanb Contributed-by: Charles Lee