Re: Code Review for 7001933: Deadlock in java.lang.classloader.getPackage()

2011-02-25 Thread Valerie (Yu-Ching) Peng
David, Thanks for the comments. I've updated the webrev accordingly at: http://cr.openjdk.java.net/~valeriep/7001933/webrev.01/ In the case of a race condition, we'll just return the earlier defined package object, i.e. pkg2 in your code sample. Or, we could also get rid of this code block alto

Re: How to find IBM's contributions?

2011-02-25 Thread Mike Duigou
I can only speak to the patches I've been involved with; currently the IBM employees post their webrevs for review to the public -dev lists and upon completion the webrevs are committed by an openJDK committer (who need not be an Oracle employee). IBM employees are expected to have their own ope

Re: How to find IBM's contributions?

2011-02-25 Thread Paul Benedict
Mike, are the commits coming directly from an IBM address, or are they submitted as patches for Oracle employees to apply? On Fri, Feb 25, 2011 at 3:42 PM, Mike Duigou wrote: > Two patches by Neil Richards have also gone in during the last week. There > were some organizational logistic issues w

Re: How to find IBM's contributions?

2011-02-25 Thread Mike Duigou
Two patches by Neil Richards have also gone in during the last week. There were some organizational logistic issues which resulted in a slow start but the pace can be expected to increase. Mike On Feb 25 2011, at 21:48 , Dr Andrew John Hughes wrote: > On 25 February 2011 20:15, Paul Benedict

hg: jdk7/tl/jdk: 7021582: convert jar/zip code and tests to use try-with-resources

2011-02-25 Thread stuart . marks
Changeset: 8887cb2f5d19 Author:smarks Date: 2011-02-25 02:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8887cb2f5d19 7021582: convert jar/zip code and tests to use try-with-resources Reviewed-by: alanb, dholmes, sherman ! src/share/classes/java/util/jar/JarFile.java ! te

Re: How to find IBM's contributions?

2011-02-25 Thread Dr Andrew John Hughes
On 25 February 2011 20:15, Paul Benedict wrote: > To the community, > > Is there any easily identifiable way to determine when IBM contributes > fixes/patches to the repositories? I know all Oracle employees have Oracle > email addresses. What about those from IBM? I was hoping to see what they >

Re: Review request for 7020513 : Add com.sun.xml.internal to the "package.access" property in java.security

2011-02-25 Thread Sean Mullan
Looks good to me. --Sean On 2/25/11 1:12 PM, Rama Pulavarthi wrote: Please review this updated webrev that has the patch for JDK 7 repo. http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxws-7020513-open/webrev/ For background on this issue, this is not a new one. I am trying to port the ol

hg: jdk7/tl/langtools: 7022310: test/tools/javac/diags/Example: args added twice

2011-02-25 Thread jonathan . gibbons
Changeset: 23b64ad3eec8 Author:jjg Date: 2011-02-25 12:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/23b64ad3eec8 7022310: test/tools/javac/diags/Example: args added twice Reviewed-by: mcimadamore ! test/tools/javac/diags/Example.java

How to find IBM's contributions?

2011-02-25 Thread Paul Benedict
To the community, Is there any easily identifiable way to determine when IBM contributes fixes/patches to the repositories? I know all Oracle employees have Oracle email addresses. What about those from IBM? I was hoping to see what they contribute since they joined OpenJDK. Thanks! Paul

hg: jdk7/tl/jdk: 7016707: Remove the BootClassLoaderHook for jkernel support

2011-02-25 Thread mandy . chung
Changeset: 5dc98de2a35e Author:mchung Date: 2011-02-25 12:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5dc98de2a35e 7016707: Remove the BootClassLoaderHook for jkernel support Reviewed-by: alanb, ohair ! make/java/java/FILES_java.gmk ! src/share/classes/java/awt/color/I

hg: jdk7/tl/langtools: 7021650: fix Context issues

2011-02-25 Thread jonathan . gibbons
Changeset: 8f0dcb9499db Author:jjg Date: 2011-02-25 12:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8f0dcb9499db 7021650: fix Context issues Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/util/Bark.java ! src/share/classes/com/sun/tools/javac/api/J

hg: jdk7/tl/jdk: 7021939: com.oracle.net is not a NON_CORE_PKGS

2011-02-25 Thread mandy . chung
Changeset: 32dc1cb2b995 Author:mchung Date: 2011-02-25 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/32dc1cb2b995 7021939: com.oracle.net is not a NON_CORE_PKGS Reviewed-by: ohair, alanb ! make/common/Release.gmk ! make/docs/NON_CORE_PKGS.gmk

Re: Review request for 7020513 : Add com.sun.xml.internal to the "package.access" property in java.security

2011-02-25 Thread Rama Pulavarthi
Please review this updated webrev that has the patch for JDK 7 repo. http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxws-7020513-open/webrev/ For background on this issue, this is not a new one. I am trying to port the old fixes made in jdk repo as part of earlier jax-ws integrations in to Op

Re: updated review request for 7021582, use try-with-resources in jar/zip implementation and tests

2011-02-25 Thread Alan Bateman
Stuart Marks wrote: Hi all, updated webrev is here: http://cr.openjdk.java.net/~smarks/reviews/7021582/webrev.1/ I've removed the pack200 files (i.e. those in src/share/classes/com/sun/java/util/jar/pack) so I can do more thorough deploy/install testing per Kumar's request. The change to Pro

hg: jdk7/tl/jdk: 7022383: add reference to CR for ReadLongZipFileName test to problem list

2011-02-25 Thread stuart . marks
Changeset: b74f1b830484 Author:smarks Date: 2011-02-24 22:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b74f1b830484 7022383: add reference to CR for ReadLongZipFileName test to problem list Reviewed-by: ohair ! test/ProblemList.txt