Re: Please review java.util.jar.pack.* cleanup/refactoring/generificaiton

2010-11-15 Thread Kumar Srinivasan
Hi John, et. al., This revision contains all fixes noted by Brian below and other comments from Alan. http://cr.openjdk.java.net/~ksrini/6990106/webrev.01/ Thanks Kumar Mostly style issues, but at least one likely bug. In a few places, you've used @SuppressWarnings("unchecked"). While this

Re: Please review -XshowSettings a java launcher option.

2010-11-15 Thread Kumar Srinivasan
Hi Naoto, If there is another round of changes required I will consider your suggestion otherwise I will fix it later as a bug fix. Thanks Kumar Hi Kumar, I just noticed this locale printing feature. In JDK7, we have provided the default locale for UIs (Locale.getDefault(LocaleCategory.DI

Re: Please review -XshowSettings a java launcher option.

2010-11-15 Thread Naoto Sato
Hi Kumar, I just noticed this locale printing feature. In JDK7, we have provided the default locale for UIs (Locale.getDefault(LocaleCategory.DISPLAY)), and the one for formatting (Locale.getDefault(LocaleCategory.FORMAT)), so you may want to show them along with the original default locale.

hg: jdk7/tl/jdk: 6544278: SecurityException not thrown for Indexed Jar file whose signature is corrupted

2010-11-15 Thread xueming . shen
Changeset: 23ccf9a8451f Author:sherman Date: 2010-11-15 09:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/23ccf9a8451f 6544278: SecurityException not thrown for Indexed Jar file whose signature is corrupted Summary: Added code to deal with the index case specially. Review

hg: jdk7/tl/jdk: 6994145: (zipfs) README should be updated; ...

2010-11-15 Thread xueming . shen
Changeset: 0682c9357897 Author:sherman Date: 2010-11-15 09:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0682c9357897 6994145: (zipfs) README should be updated 6994161: (zipfs) newFileSystem method should FileSystemAlreadyExistsException 6994152: (zipfs) copyTo ignores CO

hg: jdk7/tl/jdk: 6993789: LinkedBlockingDeque iterator/descendingIterator loops and owns lock forever

2010-11-15 Thread chris . hegarty
Changeset: bf284d2db008 Author:chegar Date: 2010-11-15 15:11 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf284d2db008 6993789: LinkedBlockingDeque iterator/descendingIterator loops and owns lock forever Reviewed-by: dl, dholmes ! src/share/classes/java/util/concurrent/Li

hg: jdk7/tl/langtools: 2 new changesets

2010-11-15 Thread maurizio . cimadamore
Changeset: a7ea58fa3e9a Author:mcimadamore Date: 2010-11-15 13:50 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a7ea58fa3e9a 6985719: Alike methods in interfaces (Inheritance and Overriding) Summary: javac should report error when interface inherits unrelated method w

hg: jdk7/tl/jdk: 6999915: TEST_BUG: test/java/nio/channels/AsynchronousSocketChannel/Leaky.java failed intermittently (win)

2010-11-15 Thread alan . bateman
Changeset: f88048284eb6 Author:alanb Date: 2010-11-15 14:34 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f88048284eb6 615: TEST_BUG: test/java/nio/channels/AsynchronousSocketChannel/Leaky.java failed intermittently (win) Reviewed-by: forax ! test/java/nio/channels/Asy

Re: Please review correction of regression test Test6929067

2010-11-15 Thread Pavel Tisnovsky
Alan Bateman wrote: > Pavel Tisnovsky wrote: >> Hi, >> >> can anybody please review correction of regression test >> runtime/6929067/Test6929067? >> >> I changed this test in a way that it now correctly works on x86_64 >> platform for example. >> >> Webrev is available at: >> http://cr.openjdk.java

Re: Please review correction of regression test Test6929067

2010-11-15 Thread Alan Bateman
Pavel Tisnovsky wrote: Hi, can anybody please review correction of regression test runtime/6929067/Test6929067? I changed this test in a way that it now correctly works on x86_64 platform for example. Webrev is available at: http://cr.openjdk.java.net/~ptisnovs/JTreg_Test6929067/ Thank you in

Please review correction of regression test Test6929067

2010-11-15 Thread Pavel Tisnovsky
Hi, can anybody please review correction of regression test runtime/6929067/Test6929067? I changed this test in a way that it now correctly works on x86_64 platform for example. Webrev is available at: http://cr.openjdk.java.net/~ptisnovs/JTreg_Test6929067/ Thank you in advance Pavel