Re: PING: Re: Fix build failure with JAVAC_MAX_WARNINGS=true in sun/nio/cs

2010-06-08 Thread Florian Weimer
* Andrew John Hughes: > On 7 June 2010 23:04, Xueming Shen wrote: >> Hi Andrew, >> >> 6959197: When building with JAVAC_MAX_WARNINGS=true, the build fails in >> sun/nio/cs due to the use of -Werror >> >> (1)sun/io/ByteTocharISO2022JP.java >>   #129,  #151 >> >>   if ((byte1 & (byte)0x80) != 0){ >

hg: jdk7/tl/jdk: 6935997: Please add a nested throwable constructor to AssertionError

2010-06-08 Thread joe . darcy
Changeset: a21e3a29ca9d Author:darcy Date: 2010-06-08 18:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a21e3a29ca9d 6935997: Please add a nested throwable constructor to AssertionError Reviewed-by: martin, forax, wetmore ! src/share/classes/java/lang/AssertionError.java

Re: Must call RegisterNatives after getMethodID, else get UnsatisfiedLinkError

2010-06-08 Thread David Holmes
Hi Martin, Not sure it's a classloader issue or a JNI issue ... My initial thoughts are that RegisterNatives is not dealing with an uninitialized class - the GetMethodID forces initialization. But I don't, at a causal look, see why that should be. Can you add -XX:+PrintJNIResolving and see w

Must call RegisterNatives after getMethodID, else get UnsatisfiedLinkError

2010-06-08 Thread Martin Buchholz
Hi ClassLoader maintainers, This is a bug report. (I think this is a hotspot bug, but it might be a core library ClassLoader bug or even a URLClassLoader bug) If you use RegisterNatives with a class loaded using URLClassLoader, you must call GetMethodID before RegisterNatives, or you get an Unsa

Re: PING: Re: Fix build failure with JAVAC_MAX_WARNINGS=true in sun/nio/cs

2010-06-08 Thread David Schlosnagle
On Tue, Jun 8, 2010 at 5:47 PM, Andrew John Hughes wrote: > New webrev: > > http://cr.openjdk.java.net/~andrew/warnings/webrev.04/ > Andrew, In src/share/classes/sun/nio/cs/ext/HKSCS.java, the following change seems odd setting a static field in the HKSCS.Decoder constructor. Is this correct fun

Re: Code review request for 6935997 "Please add a nested throwable constructor to AssertionError"

2010-06-08 Thread Brad Wetmore
As we discussed here, this looks fine. Brad On 6/8/2010 8:31 AM, Joe Darcy wrote: Thanks Martin and Rémi for the quick reviews! Upon further consideration, before doing the push I decided to look for instances in the jdk repo where this new constructor could be used and I found one in java.se

Re: PING: Re: Fix build failure with JAVAC_MAX_WARNINGS=true in sun/nio/cs

2010-06-08 Thread Andrew John Hughes
On 7 June 2010 23:04, Xueming Shen wrote: > Hi Andrew, > > 6959197: When building with JAVAC_MAX_WARNINGS=true, the build fails in > sun/nio/cs due to the use of -Werror > > (1)sun/io/ByteTocharISO2022JP.java >   #129,  #151 > >   if ((byte1 & (byte)0x80) != 0){ > >       if ((byte2 & (byte)0x80)

Re: Code review request for 6935997 "Please add a nested throwable constructor to AssertionError"

2010-06-08 Thread Joe Darcy
Thanks Martin and Rémi for the quick reviews! Upon further consideration, before doing the push I decided to look for instances in the jdk repo where this new constructor could be used and I found one in java.security.Security: --- old/src/share/classes/java/security/Security.java2010-06-

hg: jdk7/tl/jdk: 6957375: java/net/ResponseCache getResponseCode and ResponseCacheTest fail after rebranding

2010-06-08 Thread chris . hegarty
Changeset: 489c1720757b Author:chegar Date: 2010-06-08 10:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/489c1720757b 6957375: java/net/ResponseCache getResponseCode and ResponseCacheTest fail after rebranding Reviewed-by: ohair, wetmore, alanb ! test/java/net/ResponseCa