On Wed, May 12, 2010 at 23:46, Xueming Shen wrote:
> Thanks for the review.
>
> The Z_SYNC_FLUSH is supposed to fully replace the Z_PARTIAL_FLUSH.
>
> We concluded last round that Z_SYNC_FLUSH is enough for the "high-level"
> DOS, as well as the GZIPOS, use Deflater directly if more needed. I hop
Thanks for the review.
The Z_SYNC_FLUSH is supposed to fully replace the Z_PARTIAL_FLUSH.
We concluded last round that Z_SYNC_FLUSH is enough for the "high-level"
DOS, as well as the GZIPOS, use Deflater directly if more needed. I
hope you
are not suggesting we go back to redo the flush to in
zlib 1.2.5 is out!
Quite notably, there are now more flush modes
and the comment claiming that Z_PARTIAL_FLUSH
will be removed has been removed!
As I recall saying in a previous email,
we should support Z_PARTIAL_FLUSH at least
because the ssh protocol requires it.
I think the flush parameter sho
Changeset: 2d54e4cae441
Author:ohair
Date: 2010-05-12 21:35 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2d54e4cae441
6943915: Adjust jdk/test/Makefile to deal with .dll and .so libraries needing
execute permissions
Summary: And adjustments to test problem list.
Reviewed-b
Hi Martin,
Bugtraq is offline so I can't file a CR right now.
The was caught by Mauve tests. Kelly sent a link to the mailing list but
I don't think he's a member so it's probably held up for approval.
Martin Buchholz said the following on 05/13/10 11:38:
Webrev at
http://cr.openjdk.java.ne
Webrev at
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/StringBuffer-capacity/StringBuffer-capacity.patch
Martin
On Wed, May 12, 2010 at 18:23, Martin Buchholz wrote:
> Alright, I'm convinced this is a bug. Please file one in bugtraq
> (or expunge from tl in the unlikely event that would
Alright, I'm convinced this is a bug. Please file one in bugtraq
(or expunge from tl in the unlikely event that would be permitted).
It appears we very carefully specified the capacity manipulation behavior,
but didn't have any jtreg tests for it.
Do y'all run the Mauve tests? (Probably a good id
If it helps, I found an open test that should demonstrate it:
http://www.sourceware.org/cgi-bin/cvsweb.cgi/mauve/gnu/testlet/java/lang/StringBuffer/StringBufferTest.java?rev=1.7&content-type=text/x-cvsweb-markup&cvsroot=mauve
-kto
On May 12, 2010, at 5:31 PM, David Holmes wrote:
Chris, Marti
Chris, Martin,
The changes to AbstractStringBuilder violate the specification for
ensureCapacity: it has to grow from N to 2N+2. The new code in:
http://hg.openjdk.java.net/jdk7/tl-gate/jdk/rev/ec45423a4700
void expandCapacity(int minimumCapacity) {
- int newCapacity = (value.length + 1) * 2
Martin,
Would you please help review the change for
4813885: RFE: GZIPOutputStream should implement flush using Z_SYNC_FLUSH
http://cr.openjdk.java.net/~sherman/4813885/webrev
It appears people want to have the same flush option in GZIPOutputStream
as the
one we provided in DeflaterOutputStre
Changeset: 05c9ff89bcdc
Author:mchung
Date: 2010-05-12 14:41 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/05c9ff89bcdc
6951661: Eliminate jvmstat dependency on sun.management.counter
Summary: jvmstat keeps its own copy of Units and Variability class
Reviewed-by: alanb
! sr
Hello Dmytro,
Thank you for reviewing float/double section!
I'll look at your code and run tests tomorrow
and let you know results.
Best regards,
Vladimir
Dmytro Sheyko wrote:
Vladimir,
Your changes are good for me.
Additionally I have some comments/proposals regarding dealing with
negative
Hello Dmytro,
Could you please send new version of DPQ
with your changes?
Thanks,
Vladimir
Dmytro Sheyko wrote:
Vladimir,
Your changes are good for me.
Additionally I have some comments/proposals regarding dealing with
negative zeros.
1. Scanning for the first zero we can avoid range chec
Vladimir,
Your changes are good for me.
Additionally I have some comments/proposals regarding dealing with negative
zeros.
1. Scanning for the first zero we can avoid range check (i >= left) if we have
at least one negative value.
--- DualPivotQuicksort.javaTue May 11 09:04:19 2010
+++ Du
14 matches
Mail list logo
