hg: jdk7/tl/jdk: 6586707: NTLM authentication with proxy fails

2010-03-22 Thread weijun . wang
Changeset: 31dcf23042f9 Author:weijun Date: 2010-03-23 10:41 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/31dcf23042f9 6586707: NTLM authentication with proxy fails Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java

Re: String.lastIndexOf confused by unpaired trailing surrogate

2010-03-22 Thread Xueming Shen
Thanks Ulf! Fixed:-) Ulf Zibis wrote: Sherman, can you have a look on your PC clock. I guess it's dis-adjusted. -Ulf

Re: String.lastIndexOf confused by unpaired trailing surrogate

2010-03-22 Thread Ulf Zibis
Sherman, can you have a look on your PC clock. I guess it's dis-adjusted. -Ulf

Re: String.lastIndexOf confused by unpaired trailing surrogate

2010-03-22 Thread Ulf Zibis
Am 22.03.2010 21:08, schrieb Martin Buchholz: On Mon, Mar 22, 2010 at 07:45, Ulf Zibis wrote: Am 21.03.2010 18:38, schrieb Martin Buchholz: Even if I'm wrong, and this cold code is actually hot, I don't think there will be a big performance loss. The method call is outside the lo

Re: Kinda ?

2010-03-22 Thread Paul Hohensee
"in a way" plus "somewhat", as in "it's kinda bad" == "in a way, it's somewhat bad". On 3/22/10 7:02 PM, Ulf Zibis wrote: Can somebody betray the sense of "Kinda" to me? -Ulf

Kinda ?

2010-03-22 Thread Ulf Zibis
Can somebody betray the sense of "Kinda" to me? -Ulf

Re: String.lastIndexOf confused by unpaired trailing surrogate

2010-03-22 Thread Martin Buchholz
Masayoshi, Ulf and I are working on a few changes to supplementary character handling. Character.isSurrogate has already gone in. The following are in the pipeline: 6934268: Better implementation of Character.isValidCodePoint http://cr.openjdk.java.net/~martin/webrevs/openjdk7/isValidCodePoint 6

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

2010-03-22 Thread Martin Buchholz
Ulf, I'd like to start a mq patch containing changes to the String exception handling in the string classes. Please provide me with a patch that uses the blessed conventional names from Preconditions.java. For the version that checks an offset and length for containment within a larger sequence,

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

2010-03-22 Thread Martin Buchholz
On Mon, Mar 22, 2010 at 08:29, Ulf Zibis wrote: > Am 21.03.2010 20:39, schrieb Martin Buchholz: >> >> On Sun, Mar 21, 2010 at 00:56, Martin Buchholz >>  wrote: >> >> >>> >>> Study also: >> http://code.google.com/p/guava-libraries/source/browse/trunk/src/com/google/common/base/Preconditions.java >>

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

2010-03-22 Thread Martin Buchholz
On Mon, Mar 22, 2010 at 07:34, Ulf Zibis wrote: > Am 21.03.2010 17:16, schrieb Martin Buchholz: >> There is a debate about whether to reuse existing exception classes >> or to throw class-specific subclasses.  IMO, IOOBE is a sufficiently >> expressive >> exception that I might have used just tha

Re: String.lastIndexOf confused by unpaired trailing surrogate

2010-03-22 Thread Martin Buchholz
On Mon, Mar 22, 2010 at 07:45, Ulf Zibis wrote: > Am 21.03.2010 18:38, schrieb Martin Buchholz: >> Even if I'm wrong, and this cold code is actually hot, >> I don't think there will be a big performance loss. >> The method call is outside the loop. >> > > What about at least reusing the cached va

Re: String.lastIndexOf confused by unpaired trailing surrogate

2010-03-22 Thread Martin Buchholz
On Tue, Mar 23, 2010 at 13:32, Xueming Shen wrote: > 6937112: String.lastIndexOf confused by unpaired trailing surrogate > > Kinda guess that it might bring us some performance benefit to separate the > supplementary handling > code out into its own method (to help the not that smart hotspot:-)?),

Re: String.lastIndexOf confused by unpaired trailing surrogate

2010-03-22 Thread Xueming Shen
CCed Masayoshi. Masayoshi, Martin and Ulf are doing some "small" overhaul on those supplementary methods guess you might be interested to review the change. Martin, Ulf, please CC Masayoshi if you are touching the supplementary handling code. -Sherman Xueming Shen wrote: 6937112: String.l

Re: String.lastIndexOf confused by unpaired trailing surrogate

2010-03-22 Thread Xueming Shen
6937112: String.lastIndexOf confused by unpaired trailing surrogate Kinda guess that it might bring us some performance benefit to separate the supplementary handling code out into its own method (to help the not that smart hotspot:-)?), but doubt it is really something worth doing. At least y

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

2010-03-22 Thread Ulf Zibis
Am 21.03.2010 20:39, schrieb Martin Buchholz: On Sun, Mar 21, 2010 at 00:56, Martin Buchholz wrote: Study also: http://code.google.com/p/google-collections/source/browse/trunk/src/com/google/common/base/Preconditions.java Sorry, the best (most recent) version of Preconditions to stu

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

2010-03-22 Thread Ulf Zibis
Am 22.03.2010 15:33, schrieb Rémi Forax: Le 22/03/2010 14:57, Ulf Zibis a écrit : Oh, on parle français. Je l'aime beaucoup. Totally off topic but You're free to add some opinion to the main topic. ;-) You mean: "j'aime beaucoup". je l'aime beaucoup means I love him/her a lot. ... ou "l

Re: String.lastIndexOf confused by unpaired trailing surrogate

2010-03-22 Thread Ulf Zibis
Am 21.03.2010 18:38, schrieb Martin Buchholz: On Sun, Mar 21, 2010 at 06:35, Ulf Zibis wrote: On Sun, Mar 21, 2010 at 03:24, Ulf Zibiswrote: Am 21.03.2010 09:05, schrieb Martin Buchholz: On Sat, Mar 20, 2010 at 15:50, Ulf Zibis wrote:

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

2010-03-22 Thread Ulf Zibis
Am 21.03.2010 17:16, schrieb Martin Buchholz: On Sun, Mar 21, 2010 at 05:00, Ulf Zibis wrote: On Sat, Mar 20, 2010 at 14:52, Ulf Zibiswrote: - A little "bug" in javadoc: @exception ArrayIndexOutOfBoundsException insteadIndexOutOfBoundsException Not a bug. Yes, but decrease

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

2010-03-22 Thread Rémi Forax
Le 22/03/2010 14:57, Ulf Zibis a écrit : Am 21.03.2010 17:23, schrieb Martin Buchholz: On Sun, Mar 21, 2010 at 04:28, Ulf Zibis wrote: On Sat, Mar 20, 2010 at 17:13, Ulf Zibis wrote: I don't think it's a performance problem in the real world. Hm, if someone uses: if (Character.isBMPCo

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

2010-03-22 Thread Ulf Zibis
Am 21.03.2010 17:23, schrieb Martin Buchholz: On Sun, Mar 21, 2010 at 04:28, Ulf Zibis wrote: On Sat, Mar 20, 2010 at 17:13, Ulf Zibis wrote: I don't think it's a performance problem in the real world. Hm, if someone uses: if (Character.isBMPCodePoint(codePoint))

hg: jdk7/tl/jdk: 6632169: HttpClient and HttpsClient should not try to reverse lookup IP address of a proxy server

2010-03-22 Thread christopher . hegarty
Changeset: c40572afb29e Author:chegar Date: 2010-03-22 11:55 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c40572afb29e 6632169: HttpClient and HttpsClient should not try to reverse lookup IP address of a proxy server Reviewed-by: michaelm ! src/share/classes/sun/net/www/p