hg: jdk7/tl/langtools: 6572945: javah should be written as an annotation processor, not a doclet

2009-09-23 Thread jonathan . gibbons
Changeset: c287d51c57da Author:jjg Date: 2009-09-23 19:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c287d51c57da 6572945: javah should be written as an annotation processor, not a doclet Reviewed-by: darcy ! make/build.xml ! src/share/classes/com/sun/tools/javah/G

hg: jdk7/tl/langtools: 6410637: Make decision on deprecated methods in DefaultFileManager and BaseFileObject.; ...

2009-09-23 Thread jonathan . gibbons
Changeset: 49359d0e6a9c Author:jjg Date: 2009-09-23 18:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/49359d0e6a9c 6410637: Make decision on deprecated methods in DefaultFileManager and BaseFileObject. 6747645: ZipFileObject.getName is incorrectly deprecated 6885123

hg: jdk7/tl/langtools: 6517779: javax.lang.model.util.Elements.getConstantExpression() doesn't throw any exception; ...

2009-09-23 Thread joe . darcy
Changeset: e992e602788e Author:darcy Date: 2009-09-23 18:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e992e602788e 6517779: javax.lang.model.util.Elements.getConstantExpression() doesn't throw any exception 6517907: javax.lang.model.util.Elements.getConstantExpres

Re: 4206909 - adding Z_SYNC_FLUSH support to deflaters

2009-09-23 Thread Martin Buchholz
[+Brandon] For the test copyright line, use * Copyright 2009 Google, Inc. All Rights Reserved. as in other test cases. Whether, in addition, to have a Sun copyright depends on whether you made "substantive modifications". Heuristic for that is 10 lines of code. Obviously, the Sun copyright g

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Kelly O'Hair
Andrew John Hughes wrote: 2009/9/23 Andrew Haley : Andrew John Hughes wrote: 2009/9/23 Andrew Haley : Christopher Hegarty -Sun Microsystems Ireland wrote: [cc'ing net-dev] I see you have push access, so if you make the appropriate changes (mentioned above) I can review the webrev and you c

Re: 4206909 - adding Z_SYNC_FLUSH support to deflaters

2009-09-23 Thread Xueming Shen
Martin, thanks for the comments. webrev has been updated accordingly, I will submit it for the CCC. What should the "google copyright" look like for InflateIn_DeflateOut.java? I picked it from http://cr.openjdk.java.net/~martin/webrevs/openjdk7/Z_SYNC_FLUSH/test/java/util/zip/InflateIn_Deflat

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Christopher Hegarty -Sun Microsystems Ireland
Pavel, This change should be integrated into the tl/jdk [1] repository. You can plan to integrate after code review, or if you prefer just let me know and I can take care of it for you. -Chris. [1] http://hg.openjdk.java.net/jdk7/tl/jdk/ Pavel Tisnovsky wrote: Christopher, thank you for y

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Andrew John Hughes
2009/9/23 Andrew Haley : > Andrew John Hughes wrote: >> 2009/9/23 Andrew Haley : >>> Christopher Hegarty -Sun Microsystems Ireland wrote: [cc'ing net-dev] I see you have push access, so if you make the appropriate changes (mentioned above) I can review the webrev and you can use

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Andrew Haley
Andrew John Hughes wrote: > 2009/9/23 Andrew Haley : >> Christopher Hegarty -Sun Microsystems Ireland wrote: >>> [cc'ing net-dev] >>> >>> I see you have push access, so if you make the appropriate changes >>> (mentioned above) I can review the webrev and you can use the above bug >>> number and des

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Andrew John Hughes
2009/9/23 Andrew Haley : > Christopher Hegarty -Sun Microsystems Ireland wrote: >> [cc'ing net-dev] >> >> Alan Bateman wrote: >>> Pavel Tisnovsky wrote: Hi, two-lines patch for regression test java/net/MulticastSocket/SetOutgoingIf.java is exposed at http://cr.openjdk.java.

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Andrew Haley
Christopher Hegarty -Sun Microsystems Ireland wrote: > [cc'ing net-dev] > > Alan Bateman wrote: >> Pavel Tisnovsky wrote: >>> Hi, >>> >>> two-lines patch for regression test >>> java/net/MulticastSocket/SetOutgoingIf.java is exposed at >>> http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinIf/ >

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Pavel Tisnovsky
Christopher, thank you for your answer. I'll update the test and make the webrev. FYI: in fact, the test java/net/MulticastSocket/Test.java fails too on my machine, but I just not (yet) investigated the issue. It fails with exception java.net.SocketException: Cannot assign requested address.

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Christopher Hegarty -Sun Microsystems Ireland
[cc'ing net-dev] Alan Bateman wrote: Pavel Tisnovsky wrote: Hi, two-lines patch for regression test java/net/MulticastSocket/SetOutgoingIf.java is exposed at http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinIf/ The test machine (where this test fails) has six network interfaces, but o

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Alan Bateman
Pavel Tisnovsky wrote: Hi, two-lines patch for regression test java/net/MulticastSocket/SetOutgoingIf.java is exposed at http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinIf/ The test machine (where this test fails) has six network interfaces, but only two of them, namely eth2 and virbr0

Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Pavel Tisnovsky
Hi, two-lines patch for regression test java/net/MulticastSocket/SetOutgoingIf.java is exposed at http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinIf/ The test machine (where this test fails) has six network interfaces, but only two of them, namely eth2 and virbr0, can be used to send mu