Re: Review Request for 6878481: Add performance counters in the JDK

2009-09-02 Thread David Holmes - Sun Microsystems
Hi Mandy, Mandy Chung said the following on 09/03/09 05:25: This is related to 6857194: Add hotspot new perf counters to aid class loading performance measurement. It's useful to add performance counters in the library code so that perf data from the JDK and VM can be collected and output in

Re: Regex named-group and backreference syntax

2009-09-02 Thread Alan Moore
On Wed, Sep 2, 2009 at 3:21 PM, Xueming Shen wrote: > > RFE#6878475 has been filed to trace this issue. > > At this point we are going to update the doc and implementation to > (1)disallow the group name started with digit character > (2)use ${name} for the group reference in replacement string. G

Re: Review Request for 6878481: Add performance counters in the JDK

2009-09-02 Thread Rémi Forax
Le 03/09/2009 01:04, ir...@alum.mit.edu a écrit : Hi, Mandy. This is related to 6857194: Add hotspot new perf counters to aid class loading performance measurement. [ ... ] Webrev: http://cr.openjdk.java.net/~mchung/6878481/webrev.00/ Looks good. iris In Per

RE: Review Request for 6878481: Add performance counters in the JDK

2009-09-02 Thread irisg
Hi, Mandy. > This is related to 6857194: Add hotspot new perf counters to aid class > loading performance measurement. [ ... ] > Webrev: > http://cr.openjdk.java.net/~mchung/6878481/webrev.00/ Looks good. iris

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread Ulf Zibis
Am 03.09.2009 00:10, Martin Buchholz schrieb: On Wed, Sep 2, 2009 at 14:58, Ulf Zibis wrote: Doesn't {...@code "t\u005Cu0131tle"} work too ? I think so. So can I securely replace all occurrences of ... by {...@code ...} using \u005Cu in Character.java ? -Ulf

Re: Regex named-group and backreference syntax

2009-09-02 Thread Xueming Shen
RFE#6878475 has been filed to trace this issue. At this point we are going to update the doc and implementation to (1)disallow the group name started with digit character (2)use ${name} for the group reference in replacement string. The \k and ${n} can leave for further discussion (whether or n

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread Martin Buchholz
On Wed, Sep 2, 2009 at 14:58, Ulf Zibis wrote: > Am 02.09.2009 22:29, Martin Buchholz schrieb: > Doesn't {...@code "t\u005Cu0131tle"} work too ? I think so. This would make it easier to globally replace with {...@code. Here's a bit of Emacs Lisp to get you started: (defun tt-code () (intera

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread Ulf Zibis
Am 02.09.2009 22:29, Martin Buchholz schrieb: On Wed, Sep 2, 2009 at 12:46, Ulf Zibis wrote: Am 02.09.2009 19:11, David M. Lloyd schrieb: On 09/02/2009 12:03 PM, Martin Buchholz wrote: On Wed, Sep 2, 2009 at 09:40, David M. Lloyd mailto:david.ll...@redhat.com>> wrote: Why not

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread Martin Buchholz
On Wed, Sep 2, 2009 at 12:46, Ulf Zibis wrote: > Am 02.09.2009 19:11, David M. Lloyd schrieb: >> >> On 09/02/2009 12:03 PM, Martin Buchholz wrote: >>> >>> On Wed, Sep 2, 2009 at 09:40, David M. Lloyd >> > wrote: >>>    Why not just do {...@code \uD800}?  I'm like 60%

Re: hg: jdk7/tl/jdk: 16 new changesets

2009-09-02 Thread Ulf Zibis
Am 30.08.2009 08:54, tim.b...@sun.com schrieb: Changeset: 4c6a5ea563ba Author:peytoia Date: 2009-07-30 14:45 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4c6a5ea563ba 6866243: Javadoc for java.lang.Character still refers to Unicode 4 instead of 5 Reviewed-by: okutsu ! sr

Re: Regex named-group and backreference syntax

2009-09-02 Thread Mark Reinhold
> Date: Wed, 02 Sep 2009 18:55:49 +0100 > From: Andrew John Hughes > 2009/9/2 Mark Reinhold : >> I'd say ${name} is the best option here given that it will be familiar, >> at least, to Perl and .NET developers. > > It's also used for substitution in shell and Makefiles :) That too! - Mark

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread Ulf Zibis
Am 02.09.2009 19:11, David M. Lloyd schrieb: On 09/02/2009 12:03 PM, Martin Buchholz wrote: On Wed, Sep 2, 2009 at 09:40, David M. Lloyd > wrote: Why not just do {...@code \uD800}? I'm like 60% sure that would work just fine. :-) I'm pretty sure it would

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread Ulf Zibis
Am 02.09.2009 18:27, Martin Buchholz schrieb: On Wed, Sep 2, 2009 at 01:07, Ulf Zibis > wrote: Am 02.09.2009 05:21, Martin Buchholz schrieb: /** - * The minimum value of a Unicode surrogate code unit in the UTF-16 encoding. + * The minimum value o

Review Request for 6878481: Add performance counters in the JDK

2009-09-02 Thread Mandy Chung
This is related to 6857194: Add hotspot new perf counters to aid class loading performance measurement. It's useful to add performance counters in the library code so that perf data from the JDK and VM can be collected and output in a unified way (written in the jvmstat shared memory buffer).

Re: Regex named-group and backreference syntax

2009-09-02 Thread Andrew John Hughes
2009/9/2 Mark Reinhold : >> Date: Wed, 02 Sep 2009 01:58:46 -0700 >> From: uncle.al...@gmail.com > >... > I'd say ${name} is the best option here given that it will be familiar, > at least, to Perl and .NET developers. > It's also used for substitution in shell and Makefiles :) > - Mark > --

hg: jdk7/tl/langtools: 6874249: Check has duplicate local variable and field for "source"

2009-09-02 Thread jonathan . gibbons
Changeset: 8d999cb7ec09 Author:jjg Date: 2009-09-02 10:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8d999cb7ec09 6874249: Check has duplicate local variable and field for "source" Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread David M. Lloyd
On 09/02/2009 12:03 PM, Martin Buchholz wrote: On Wed, Sep 2, 2009 at 09:40, David M. Lloyd mailto:david.ll...@redhat.com>> wrote: Why not just do {...@code \uD800}? I'm like 60% sure that would work just fine. :-) I'm pretty sure it would fail. Prove me wrong! Searching the JDK sour

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread Martin Buchholz
On Wed, Sep 2, 2009 at 09:40, David M. Lloyd wrote: > On 09/02/2009 11:27 AM, Martin Buchholz wrote: > >> On Wed, Sep 2, 2009 at 01:07, Ulf Zibis > ulf.zi...@gmx.de>> wrote: >>Am 02.09.2009 05:21, Martin Buchholz schrieb: >> >>>On Tue, Sep 1, 2009 at 01:29, Ulf Zibis >>

Re: Regex named-group and backreference syntax

2009-09-02 Thread Mark Reinhold
> Date: Wed, 02 Sep 2009 01:58:46 -0700 > From: uncle.al...@gmail.com > On Wed, Sep 2, 2009 at 12:15 AM, Xueming Shen wrote: >> It would be an "ambiguity" (and then confused) only if we >> had the \k and $ as the legally supported group >> reference syntax:-) That said I have to admit that it does

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread David M. Lloyd
On 09/02/2009 11:27 AM, Martin Buchholz wrote: On Wed, Sep 2, 2009 at 01:07, Ulf Zibis mailto:ulf.zi...@gmx.de>> wrote: Am 02.09.2009 05:21, Martin Buchholz schrieb: On Tue, Sep 1, 2009 at 01:29, Ulf Zibis mailto:ulf.zi...@gmx.de>> wrote: {...@code is now the preferred way. I tried

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread Martin Buchholz
On Wed, Sep 2, 2009 at 01:07, Ulf Zibis wrote: > Am 02.09.2009 05:21, Martin Buchholz schrieb: > > > > On Tue, Sep 1, 2009 at 01:29, Ulf Zibis wrote: > > > {...@code is now the preferred way. I tried to modify the methods I changed, > but didn't try to change the whole file. > > > You also hav

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread Ulf Zibis
Am 02.09.2009 05:21, Martin Buchholz schrieb: - I would like to see backwards-referring like: public static final int MIN_CODE_POINT = MIN_VALUE; public static final int MIN_SUPPLEMENTARY_CODE_POINT = MAX_VALUE + 1; Those would work, but would add to the confusion between

Re: Regex named-group and backreference syntax

2009-09-02 Thread Alan Moore
Hi Sherman, On Wed, Sep 2, 2009 at 12:15 AM, Xueming Shen wrote: > It would be an "ambiguity" (and then confused) only if we > had the \k and $ as the legally supported group > reference syntax:-) That said I have to admit that it does > not have any value-add to allow the a group name begins > wi

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

2009-09-02 Thread Ulf Zibis
Am 02.09.2009 05:21, Martin Buchholz schrieb: On Tue, Sep 1, 2009 at 01:29, Ulf Zibis > wrote: {...@code is now the preferred way. I tried to modify the methods I changed, but didn't try to change the whole file. You also have added old style, so I asked why you h

Re: Regex named-group and backreference syntax

2009-09-02 Thread Xueming Shen
Hi Alan, It would be an "ambiguity" (and then confused) only if we had the \k and $ as the legally supported group reference syntax:-) That said I have to admit that it does not have any value-add to allow the a group name begins with a digit character. So if we have a consensus I would be hap