Re: SecurityException in AnnotationInvocationHandler.getMemberMethods

2008-10-21 Thread Martin Buchholz
If I had known when I started how hard it would be, I would never have started writing one... Where are annotations tests supposed to go? They seem under-test-covered. I've put it into a new directory, test/java/lang/annotation Please review. The following fails with current openjdk, passes with

Re: [security-dev 00357]: Re: SecurityException in AnnotationInvocationHandler.getMemberMethods

2008-10-21 Thread Sean Mullan
I looked at the code changes and it seems fine to me. --Sean Joe Darcy wrote: Hello. On 10/16/08 12:46 PM, Martin Buchholz wrote: Hi all, This is a bug report with fix. Joe Darcy, please file a bug and review this change, I've filed 6761678 "(ann) SecurityException in AnnotationInvocat

Is InputMap serializable or not?

2008-10-21 Thread Paulo Levi
Hi. I found that the component input map advertises itself as serializable, but it is really not, because somehow it seems to hold a reference to a not serializable ActionMap. A test case, sorry about the write/read functions, they were copied from a utility class (as you can see i had to replace

Re: Technical review was: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-21 Thread Alan Bateman
Jaroslav Tulach wrote: OK, so now, after Mark's reply, we know that it is possible to include such little, compatible extensions of an existing APIs into the Maintenance JSR. Good. Now please tell me, what shall I do to make it happen[1]? Will Mark or someone else from core-libs@ do a technical

Technical review was: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-21 Thread Jaroslav Tulach
OK, so now, after Mark's reply, we know that it is possible to include such little, compatible extensions of an existing APIs into the Maintenance JSR. Good. Now please tell me, what shall I do to make it happen[1]? Will Mark or someone else from core-libs@ do a technical review of my patch? By wh