hg: jdk7/tl/langtools: 6760930: empty element on bootclasspath breaks test/tools/apt/Discovery/discovery.sh

2008-10-17 Thread jonathan . gibbons
Changeset: 2eec479619d8 Author:jjg Date: 2008-10-17 16:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2eec479619d8 6760930: empty element on bootclasspath breaks test/tools/apt/Discovery/discovery.sh Reviewed-by: darcy ! test/tools/apt/Discovery/discovery.sh

Re: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)

2008-10-17 Thread David M. Lloyd
One could always go the awt route: public interface CharSequence2 extends CharSequence { ...new methods here... } then change things to implement CharSequence2 instead, using covariance as appropriate (thus at least somewhat avoiding the casting problem). At least then the program would f

Re: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)

2008-10-17 Thread Brian Duff
This doesn't just introduce a source incompatibility (requiring code to be recompiled), it also introduces a binary incompatibility. If any object receives a CharSequence instance that happened to have been compiled against an older version of the platform, it will have no way of knowing th

Re: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)

2008-10-17 Thread Paulo Levi
Can't be changed? No user of the api is currently using getChars on a Charsequence (because it doesn't exist!) If you're talking about other implementers of Charsequence than the jdk, well, i don't see why do we have to suffer ignominious interface incompleteness just because someone doesn't want

Re: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)

2008-10-17 Thread Martin Buchholz
Paulo, I think you're right, that bulk char reading operations should have been part of this interface. But it's too late now; interfaces can never be changed. Hotspot does not do such a bad job optimizing calls through interfaces. Do we know what the penalty is? (usual micro-benchmark warning

Re: Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)

2008-10-17 Thread Paulo Levi
Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin) should be Why does CharSequence not have CharSequence getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin) With appropriate covariant returns down the inheritance tree.

Why does CharSequence not have String getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)

2008-10-17 Thread Paulo Levi
Get chars could be always implemented by a method already existing on the interface (getChar(int i)) but more efficently. Moreover this is the only missing piece to create read-only api's that work on all kinds of charsequences, be it swing.text Content, String, Stringbuffer, StringBuilder, CharBu

hg: jdk7/tl/langtools: 6760805: empty element on bootclasspath breaks test/tools/apt/Compile/compile.sh

2008-10-17 Thread jonathan . gibbons
Changeset: eca4bf37b66e Author:jjg Date: 2008-10-17 10:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/eca4bf37b66e 6760805: empty element on bootclasspath breaks test/tools/apt/Compile/compile.sh Reviewed-by: darcy ! test/tools/apt/Compile/compile.sh

Re: Maintenance Reviews was: [PATCH] Enhance ServiceLoader to understand factory methods

2008-10-17 Thread Jaroslav Tulach
Thanks for the clarification, Mark. I've heard about some umbrella JSR for each release of the JDK before and I was hoping that my proposed change could be covered as part of it. Thanks for confirming that such aggregation is possible. > With regard to this particular proposal, as the original au